starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Some newlines appear to be broken #5764

New Issue
Closed
opened 2026-01-31 00:21:05 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:21:05 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Jan 3, 2020).

As an example, the one you see when PowerShell starts up:

bad

image

good

image

Originally created by @DHowett-MSFT on GitHub (Jan 3, 2020). As an example, the one you see when PowerShell starts up: ## bad ![image](https://user-images.githubusercontent.com/14316954/71752084-96b66600-2e32-11ea-931d-319e06661b2f.png) ## good ![image](https://user-images.githubusercontent.com/14316954/71752088-9b7b1a00-2e32-11ea-89fd-f15f05707e88.png)
claunia commented 2026-01-31 00:21:06 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 3, 2020):

Looks like only WT...

@DHowett-MSFT commented on GitHub (Jan 3, 2020): Looks like only WT...
claunia commented 2026-01-31 00:21:06 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 4, 2020):

Is this a recent regression? I would have thought it might be #3271 but that hasn't merged yet.

@zadjii-msft commented on GitHub (Jan 4, 2020): Is this a recent regression? I would have thought it might be #3271 but that hasn't merged yet.
claunia commented 2026-01-31 00:21:06 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 4, 2020):

Very. The current selfhost build from 12/31 does not exhibit this issue. Maybe related to the audit mode refactoring?

@DHowett-MSFT commented on GitHub (Jan 4, 2020): Very. The current selfhost build from 12/31 does not exhibit this issue. Maybe related to the audit mode refactoring?
claunia commented 2026-01-31 00:21:07 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 5, 2020):

I believe the problem is in the TerminalDispatch::CursorPosition method here:
d711d731d7/src/cascadia/TerminalCore/TerminalDispatch.cpp (L40-L44)

If the SizeTToShort calls succeed, then the FAILED tests are going to be false, and the RETURN_BOOL_IF_FALSE will force the method to abort.

@j4james commented on GitHub (Jan 5, 2020): I believe the problem is in the `TerminalDispatch::CursorPosition` method here: https://github.com/microsoft/terminal/blob/d711d731d7d00259b2e0fe5847928c9f1c1121ed/src/cascadia/TerminalCore/TerminalDispatch.cpp#L40-L44 If the `SizeTToShort` calls succeed, then the `FAILED` tests are going to be false, and the `RETURN_BOOL_IF_FALSE` will force the method to abort.
claunia commented 2026-01-31 00:21:07 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 5, 2020):

Oof. Thanks.

@DHowett-MSFT commented on GitHub (Jan 5, 2020): Oof. Thanks.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5764
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?