starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Create til namespaces shorthanding the chromium safe math #5860

New Issue
Closed
opened 2026-01-31 00:23:39 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 00:23:39 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (Jan 10, 2020).

We may actually want to namespace a bunch of this stuff into til (with using), more than what @lhecker's already suggested. It'll make us more robust if we ever do want to change things up in the future, and avoid littering chromium::numerics::whatever all over every part of the code.

Originally posted by @DHowett-MSFT in https://github.com/microsoft/terminal/pull/4144#issuecomment-572804554

This represents putting something like til::saturated<T> as the shorthand for the chromium::numerics::ClampedNumeric<T> and so forth for the other representations per @DHowett-MSFT's comment.

Originally created by @miniksa on GitHub (Jan 10, 2020). We may actually want to namespace a bunch of this stuff into `til` (with `using`), more than what @lhecker's already suggested. It'll make us more robust if we ever do want to change things up in the future, _and_ avoid littering `chromium::numerics::whatever` all over every part of the code. _Originally posted by @DHowett-MSFT in https://github.com/microsoft/terminal/pull/4144#issuecomment-572804554_ This represents putting something like `til::saturated<T>` as the shorthand for the `chromium::numerics::ClampedNumeric<T>` and so forth for the other representations per @DHowett-MSFT's comment.
claunia commented 2026-01-31 00:23:40 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 18, 2020):

We may have decided we don't need to do this, actually. The namespace isn't all that bad. I don't recall, though.

@DHowett-MSFT commented on GitHub (Feb 18, 2020): We may have decided we don't need to do this, actually. The namespace isn't all that bad. I don't recall, though.
claunia commented 2026-01-31 00:23:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 9, 2021):

Hey @miniksa @DHowett, it's been two years of this and I don't think this is bothering anyone. Close?

@zadjii-msft commented on GitHub (Dec 9, 2021): Hey @miniksa @DHowett, it's been two years of this and I don't think this is bothering anyone. Close?
claunia commented 2026-01-31 00:23:41 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Dec 9, 2021):

@lhecker, as the current master of the til namespace, what's your opinion here?

@miniksa commented on GitHub (Dec 9, 2021): @lhecker, as the current master of the `til` namespace, what's your opinion here?
claunia commented 2026-01-31 00:23:41 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Dec 9, 2021):

maybe... no

@lhecker commented on GitHub (Dec 9, 2021): ![maybe... no](https://media.giphy.com/media/LSFwEyHmoBwF0S3YM5/giphy-downsized.gif)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Task Needs-Attention Needs-Tag-Fix Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5860
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?