starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ConPty in CMake/Qt project - pipes don't work #587

New Issue
Closed
opened 2026-01-30 21:56:13 +00:00 by claunia · 4 comments
claunia commented 2026-01-30 21:56:13 +00:00
Owner
Copy Link

Originally created by @kafeg on GitHub (Mar 17, 2019).

Hello!

I try to create Qt binding for ConPty and I use CMake as build-system for my project. And my problem is: ConPty doesn't write its own output to a pipe, it just write all into stdout of my main process. As if a child and my parent stdout channels merged. I try to create a realization with named and anonymous pipes (from EchoCon example), but it both fail =(

I don't know what I do wrong - all my code are the same of EchoCon example, but project not work as expected.

Information about my system:

  • Microsoft Windows [Version 10.0.18342.8]
  • Windows SDK Version 10.0.18346.0

I build my project with cmake in Qt Creator with MSVC. I double checked, cmake use latest available SDK. Also original EchoCon sample is working fine on my system, but copied from it code built with cmake - not =(

You can find not working code here: https://github.com/kafeg/ptyqt/blob/master/core/conptyanonymouspipeprocess.cpp

Originally created by @kafeg on GitHub (Mar 17, 2019). Hello! I try to create Qt binding for ConPty and I use CMake as build-system for my project. And my problem is: ConPty doesn't write its own output to a pipe, it just write all into stdout of my main process. As if a child and my parent stdout channels merged. I try to create a realization with named and anonymous pipes (from EchoCon example), but it both fail =( I don't know what I do wrong - all my code are the same of EchoCon example, but project not work as expected. Information about my system: - Microsoft Windows [Version 10.0.18342.8] - Windows SDK Version 10.0.18346.0 I build my project with cmake in Qt Creator with MSVC. I double checked, cmake use latest available SDK. Also original EchoCon sample is working fine on my system, but copied from it code built with cmake - not =( You can find not working code here: https://github.com/kafeg/ptyqt/blob/master/core/conptyanonymouspipeprocess.cpp
claunia commented 2026-01-30 21:56:14 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 17, 2019):

Hey @kafeg,
It looks like you're reading from the input pipe and writing to the output pipe. Try switching those around and seeing what ends up in your read buffer.

@DHowett-MSFT commented on GitHub (Mar 17, 2019): Hey @kafeg, It looks like you're [reading from the input pipe](https://github.com/kafeg/ptyqt/blob/master/core/conptyanonymouspipeprocess.cpp#L190) and [writing to the output pipe](https://github.com/kafeg/ptyqt/blob/master/core/conptyanonymouspipeprocess.cpp#L301). Try switching those around and seeing what ends up in your read buffer.
claunia commented 2026-01-30 21:56:14 +00:00
Author
Owner
Copy Link

@kafeg commented on GitHub (Mar 18, 2019):

@DHowett-MSFT, sorry, but are you sure?

In original example are the same pipe used to read from Pty:

//  Create the Pseudo Console and pipes to it
HANDLE hPipeIn{ INVALID_HANDLE_VALUE };
HANDLE hPipeOut{ INVALID_HANDLE_VALUE };
hr = CreatePseudoConsoleAndPipes(&hPC, &hPipeIn, &hPipeOut);
...

// Here used 'hPipeIn' as parameter for PipeListener
HANDLE hPipeListenerThread{ reinterpret_cast<HANDLE>(_beginthread(PipeListener, 0, hPipeIn)) };
...

//and PipeListener:
void __cdecl PipeListener(LPVOID pipe)
{
    HANDLE hPipe{ pipe };
    ...
    fRead = ReadFile(hPipe, szBuffer, BUFF_SIZE, &dwBytesRead, NULL);
    ...
}

And this combination works.

@kafeg commented on GitHub (Mar 18, 2019): @DHowett-MSFT, sorry, but are you sure? In original example are the same pipe used to read from Pty: ```cpp // Create the Pseudo Console and pipes to it HANDLE hPipeIn{ INVALID_HANDLE_VALUE }; HANDLE hPipeOut{ INVALID_HANDLE_VALUE }; hr = CreatePseudoConsoleAndPipes(&hPC, &hPipeIn, &hPipeOut); ... // Here used 'hPipeIn' as parameter for PipeListener HANDLE hPipeListenerThread{ reinterpret_cast<HANDLE>(_beginthread(PipeListener, 0, hPipeIn)) }; ... //and PipeListener: void __cdecl PipeListener(LPVOID pipe) { HANDLE hPipe{ pipe }; ... fRead = ReadFile(hPipe, szBuffer, BUFF_SIZE, &dwBytesRead, NULL); ... } ``` And this combination works.
claunia commented 2026-01-30 21:56:14 +00:00
Author
Owner
Copy Link

@kafeg commented on GitHub (Mar 18, 2019):

So, I try switch pipes, but it still not work =(

@kafeg commented on GitHub (Mar 18, 2019): So, I try switch pipes, but it still not work =(
claunia commented 2026-01-30 21:56:15 +00:00
Author
Owner
Copy Link

@kafeg commented on GitHub (Mar 19, 2019):

All works fine, an important part is to run the application from the existing console window.

@kafeg commented on GitHub (Mar 19, 2019): All works fine, an important part is to run the application from the existing console window.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#587
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?