starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Closing tabs with the mouse wheel button causes an immediate crash of the entire Terminal #5937

New Issue
Closed
opened 2026-01-31 00:25:56 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 00:25:56 +00:00
Owner
Copy Link

Originally created by @glitch100 on GitHub (Jan 15, 2020).

I assume this is to do with the TabViewItem.CloseRequested Event not being respected properly or some sort of bad subscription to it.

For what it's worth I would be happy to take a swing at this one if you aren't going to prioritise it but would need some pointers. CPP isn't my main, (C# is) but I suspect the event that is required or used somewhere might be in the CPP modules.

Environment

Windows build number:  Win32NT 10.0.18362.0 Microsoft Windows NT 10.0.18362.0
Windows Terminal version (if applicable): 0.8.10091

Any other software?
None

Steps to reproduce

  • Open Terminal
  • Add new Tab
  • Use Mousewheel to second tab
  • Crash

Expected behavior

New tabs being closed don't cause crashes

Actual behavior

New tabs being closed by mousewheel cause issues

Originally created by @glitch100 on GitHub (Jan 15, 2020). I assume this is to do with the `TabViewItem.CloseRequested` Event not being respected properly or some sort of bad subscription to it. For what it's worth I would be happy to take a swing at this one if you aren't going to prioritise it but would need some pointers. CPP isn't my main, (C# is) but I suspect the event that is required or used somewhere might be in the CPP modules. # Environment ```none Windows build number: Win32NT 10.0.18362.0 Microsoft Windows NT 10.0.18362.0 Windows Terminal version (if applicable): 0.8.10091 Any other software? None ``` # Steps to reproduce - Open Terminal - Add new Tab - Use Mousewheel to second tab - **Crash** # Expected behavior New tabs being closed don't cause crashes # Actual behavior New tabs being closed by mousewheel cause issues
claunia commented 2026-01-31 00:25:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 15, 2020):

Does this only happen with certain profiles and not others? I can't get this to repro on 0.8 myself, but who knows. There could be any number of reasons why this is happening, it's hard to say definitively without a stack trace. Could you maybe capture it with the Feedback hub and share the link, so we could investigate? /feedback

Though, if you're feeling brave enough to build the code and repro this under the debugger, you'll probably get a lot more relevant information than the Feedback hub can give us.

@zadjii-msft commented on GitHub (Jan 15, 2020): Does this only happen with certain profiles and not others? I can't get this to repro on 0.8 myself, but who knows. There could be any number of reasons why this is happening, it's hard to say definitively without a stack trace. Could you maybe capture it with the Feedback hub and share the link, so we could investigate? /feedback Though, if you're feeling brave enough to build the code and repro this under the debugger, you'll probably get a lot more relevant information than the Feedback hub can give us.
claunia commented 2026-01-31 00:25:58 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 15, 2020):

Hi there!

Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?

Thanks!

image image

@ghost commented on GitHub (Jan 15, 2020): Hi there!<br><br>Can you please send us feedback with the Feedback Hub with this issue and paste the link here so we can more easily find your crash information on the back end?<br><br>Thanks!<br><br>![image](https://user-images.githubusercontent.com/18221333/62478757-b69d0d00-b760-11e9-9626-1fa33c91e7c5.png) ![image](https://user-images.githubusercontent.com/18221333/62478649-6de55400-b760-11e9-806e-5aab7e085a9f.png)
claunia commented 2026-01-31 00:25:59 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 19, 2020):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Jan 19, 2020): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Author-Feedback Needs-Triage No-Recent-Activity Priority-1 Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#5937
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?