bracketed paste in conhost #596

@oising commented on GitHub (Mar 27, 2019):

@DHowett-MSFT -- worth ingesting this page here concerning the security issues various implementations of bracketed paste mode may have: https://lwn.net/Articles/749992/ -- particularly http://thejh.net/misc/website-terminal-copy-paste

@oising commented on GitHub (Mar 27, 2019): @DHowett-MSFT -- worth ingesting this page here concerning the security issues various implementations of bracketed paste mode may have: https://lwn.net/Articles/749992/ -- particularly http://thejh.net/misc/website-terminal-copy-paste

claunia commented

@miniksa commented on GitHub (Mar 27, 2019):

@oising, thank you for that read. I think the best thing we could do is write tests for the specific security issues listed there and attempt to mitigate them as we implement the bracketed paste mode.

@miniksa commented on GitHub (Mar 27, 2019): @oising, thank you for that read. I think the best thing we could do is write tests for the specific security issues listed there and attempt to mitigate them as we implement the bracketed paste mode.

claunia commented

@chris-morgan commented on GitHub (Nov 10, 2019):

Would it be possible and/or reasonable for starters to just have ConPTY pass through ESC [ ? 2004 h and ESC [ ? 2004 l on stdout, and ESC [ 200 ~ and ESC [ 201 ~ on stdin, so that other terminals that support bracketed paste (e.g. Alacritty) can support it? (It makes me sad when such terminal emulators are blocked from supporting functionality on Windows because ConPTY filters out the magic.)

@chris-morgan commented on GitHub (Nov 10, 2019): Would it be possible and/or reasonable for starters to just have ConPTY pass through `ESC [ ? 2004 h` and `ESC [ ? 2004 l` on stdout, and `ESC [ 200 ~` and `ESC [ 201 ~` on stdin, so that other terminals that support bracketed paste (e.g. Alacritty) can support it? (It makes me sad when such terminal emulators are blocked from supporting functionality on Windows because ConPTY filters out the magic.)

claunia commented

@FlipperPA commented on GitHub (Mar 16, 2020):

@DHowett Dustin, thanks for pointing me to this issue from the one I had opened concerning pasting into IPython / vi. Are there any workarounds in the meantime?

@FlipperPA commented on GitHub (Mar 16, 2020): @DHowett Dustin, thanks for pointing me to this issue from the one I had opened concerning pasting into IPython / vi. Are there any workarounds in the meantime?

claunia commented

@DHowett-MSFT commented on GitHub (Mar 16, 2020):

In the meantime, before/after pasting in vim you can :set paste and :set nopaste. I'm not certain what ipy needs here, unfortunately. ☹️

@DHowett-MSFT commented on GitHub (Mar 16, 2020): In the meantime, before/after pasting in vim you can `:set paste` and `:set nopaste`. I'm not certain what ipy needs here, unfortunately. ☹️

claunia commented

@FlipperPA commented on GitHub (Mar 22, 2020):

Several similar workarounds for ipython on Ubuntu for anyone looking:

Type %autoindent to turn off automatic indentation, then pasting will work.
Type %cpaste and then paste, and then -- to end, and it will work, if you want to leave automatic indentation on.

This will not persist between ipython sessions. To make this change permanent, you can create a configuration file a la vi ~/.ipython/profile_default/ipython_config.py, and put these contents in it:

c = get_config()
c.InteractiveShell.autoindent = False

I hope this helps someone!

@FlipperPA commented on GitHub (Mar 22, 2020): Several similar workarounds for `ipython` on Ubuntu for anyone looking: * Type `%autoindent` to turn off automatic indentation, then pasting will work. * Type `%cpaste` and then paste, and then `--` to end, and it will work, if you want to leave automatic indentation on. This will not persist between `ipython` sessions. To make this change permanent, you can create a configuration file a la `vi ~/.ipython/profile_default/ipython_config.py`, and put these contents in it: ``` c = get_config() c.InteractiveShell.autoindent = False ``` I hope this helps someone!

claunia commented

@skyline75489 commented on GitHub (Feb 14, 2021):

For the 8 people who subscribed this (one of them being an obsolete account of Dustin), the bracketed paste mode in Windows Terminal is implemented in #9034 and should be available in 1.7 preview 🎉 .

Thanks everyone for the discussion about the potential security issues. I believe most of them has been taken care of in the implementation. Feel free to contact me if you have any questions about the current implementation.

@skyline75489 commented on GitHub (Feb 14, 2021): For the 8 people who subscribed this (one of them being an obsolete account of Dustin), the bracketed paste mode in Windows Terminal is implemented in #9034 and should be available in 1.7 preview 🎉 . Thanks everyone for the discussion about the potential security issues. I believe most of them has been taken care of in the implementation. Feel free to contact me if you have any questions about the current implementation.

claunia commented

@oising commented on GitHub (Feb 16, 2021):

@skyline75489 ! Woo

@oising commented on GitHub (Feb 16, 2021): @skyline75489 ! Woo

claunia commented

@FlipperPA commented on GitHub (Feb 19, 2021):

This is fantastic, @skyline75489 - thank you to everyone who worked on it.

@FlipperPA commented on GitHub (Feb 19, 2021): This is fantastic, @skyline75489 - thank you to everyone who worked on it.

claunia commented

@gbtec-markusmeier commented on GitHub (Mar 3, 2021):

Wasn't subscribing, but watching silently for some months - just saw that @cinnamon-msft mentioned this great feature in Terminal Preview 1.7. Looking forward to next month's release!

@gbtec-markusmeier commented on GitHub (Mar 3, 2021): Wasn't subscribing, but watching silently for some months - just saw that @cinnamon-msft mentioned this great feature in Terminal Preview 1.7. Looking forward to next month's release!

claunia commented

@DHowett commented on GitHub (Mar 3, 2021):

@gbtec-markusmeier Preview is fairly stable itself; you could switch over today!

@DHowett commented on GitHub (Mar 3, 2021): @gbtec-markusmeier Preview is fairly stable itself; you could switch over today!

claunia commented

@davidanthoff commented on GitHub (Mar 3, 2021):

Fantastic, thanks for implementing this! I'm closing this issue, because I guess it is all done :)

@davidanthoff commented on GitHub (Mar 3, 2021): Fantastic, thanks for implementing this! I'm closing this issue, because I guess it is all done :)

claunia commented

@skyline75489 commented on GitHub (Mar 3, 2021):

@davidanthoff my work is to bring bracketed paste into Windows Terminal. The support for bracketed paste in Conhost is yet to be done. I understand this issue is probably opened when Windows Terminal wasn’t really a thing, but here it is.

We may want to reopen this and change the title to just “bracketed paste in conhost”.

@skyline75489 commented on GitHub (Mar 3, 2021): @davidanthoff my work is to bring bracketed paste into Windows Terminal. The support for bracketed paste in Conhost is yet to be done. I understand this issue is probably opened when Windows Terminal wasn’t really a thing, but here it is. We may want to reopen this and change the title to just “bracketed paste in conhost”.

claunia commented

@davidanthoff commented on GitHub (Mar 4, 2021):

Done!

@davidanthoff commented on GitHub (Mar 4, 2021): Done!

claunia commented

@FlipperPA commented on GitHub (Mar 4, 2021):

Just a big THANK YOU to everyone involved - this is a huge time saver and help for my workflow.

@FlipperPA commented on GitHub (Mar 4, 2021): Just a big THANK YOU to everyone involved - this is a huge time saver and help for my workflow.

claunia commented

@blayz3r commented on GitHub (Mar 9, 2021):

@davidanthoff my work is to bring bracketed paste into Windows Terminal. The support for bracketed paste in Conhost is yet to be done. I understand this issue is probably opened when Windows Terminal wasn’t really a thing, but here it is.

We may want to reopen this and change the title to just “bracketed paste in conhost”.

So bracketed paste will not work in ConPTY atm? correct?

@blayz3r commented on GitHub (Mar 9, 2021): > > > @davidanthoff my work is to bring bracketed paste into Windows Terminal. The support for bracketed paste in Conhost is yet to be done. I understand this issue is probably opened when Windows Terminal wasn’t really a thing, but here it is. > > We may want to reopen this and change the title to just “bracketed paste in conhost”. So bracketed paste will not work in ConPTY atm? correct?

claunia commented

@zadjii-msft commented on GitHub (Mar 9, 2021):

No it should work just fine in conpty (the Terminal uses conpty too 😉). Conhost (the vintage console) still needs to implement support for this itself, but that should be much simpler now.

@zadjii-msft commented on GitHub (Mar 9, 2021): No it should work just fine in conpty (the Terminal uses conpty too 😉). Conhost (the vintage console) still needs to implement support for this itself, but that should be much simpler now.

claunia commented