starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Build fails after commit 62765f1 #6023

New Issue
Closed
opened 2026-01-31 00:28:01 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 00:28:01 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 17, 2020).

Environment

Windows build number: Version 10.0.18362.535

Any other software?
Visual Studio 2019 version 16.4.2

Steps to reproduce

  1. Checkout commit 62765f152e
  2. Rebuild solution from within Visual Studio

Expected behavior

The build should succeed.

Actual behavior

I get the following errors:

Error	LNK2001	unresolved external symbol "public: __cdecl Microsoft::Console::Render::GdiEngine::GdiEngine(void)" (??0GdiEngine@Render@Console@Microsoft@@QEAA@XZ)	UnitTests_TerminalCore	\terminal\src\cascadia\UnitTests_TerminalCore\ConInteractivityWin32Lib.lib(Window.obj)	1	
Error	LNK2001	unresolved external symbol "public: long __cdecl Microsoft::Console::Render::GdiEngine::SetHwnd(struct HWND__ * const)" (?SetHwnd@GdiEngine@Render@Console@Microsoft@@QEAAJQEAUHWND__@@@Z)	UnitTests_TerminalCore	\terminal\src\cascadia\UnitTests_TerminalCore\ConInteractivityWin32Lib.lib(Window.obj)	1	
Error	LNK1120	2 unresolved externals	UnitTests_TerminalCore	\terminal\bin\x64\Release\Terminal.Core.Unit.Tests.dll	1

If I checkout one revision back (77dd51af39), the build succeeds.

Is this just me, or is something busted?

Originally created by @j4james on GitHub (Jan 17, 2020). # Environment ```none Windows build number: Version 10.0.18362.535 Any other software? Visual Studio 2019 version 16.4.2 ``` # Steps to reproduce 1. Checkout commit 62765f152e1fc9732a2ff212c9b98c1d0dbb9665 2. Rebuild solution from within Visual Studio # Expected behavior The build should succeed. # Actual behavior I get the following errors: ``` Error LNK2001 unresolved external symbol "public: __cdecl Microsoft::Console::Render::GdiEngine::GdiEngine(void)" (??0GdiEngine@Render@Console@Microsoft@@QEAA@XZ) UnitTests_TerminalCore \terminal\src\cascadia\UnitTests_TerminalCore\ConInteractivityWin32Lib.lib(Window.obj) 1 Error LNK2001 unresolved external symbol "public: long __cdecl Microsoft::Console::Render::GdiEngine::SetHwnd(struct HWND__ * const)" (?SetHwnd@GdiEngine@Render@Console@Microsoft@@QEAAJQEAUHWND__@@@Z) UnitTests_TerminalCore \terminal\src\cascadia\UnitTests_TerminalCore\ConInteractivityWin32Lib.lib(Window.obj) 1 Error LNK1120 2 unresolved externals UnitTests_TerminalCore \terminal\bin\x64\Release\Terminal.Core.Unit.Tests.dll 1 ``` If I checkout one revision back (77dd51af39d4f083403bbbe34052f6bdcada9ec3), the build succeeds. Is this just me, or is something busted?
claunia added the Needs-TriageResolution-Fix-CommittedNeeds-Tag-Fix labels 2026-01-31 00:28:01 +00:00
claunia commented 2026-01-31 00:28:02 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 17, 2020):

Looking at the results for the merge build, there are errors reported, but that just appears to be a timeout while running the unit tests, which doesn't necessarily indicate a problem. And the build in the PR (#4213) was definitely successful. Maybe it is just me.

@j4james commented on GitHub (Jan 17, 2020): Looking at the [results for the merge build](https://dev.azure.com/ms/Terminal/_build/results?buildId=58951&view=results), there are errors reported, but that just appears to be a timeout while running the unit tests, which doesn't necessarily indicate a problem. And the build in the PR (#4213) was definitely successful. Maybe it is just me.
claunia commented 2026-01-31 00:28:03 +00:00
Author
Owner
Copy Link

@mkitzan commented on GitHub (Jan 18, 2020):

My fork also fails to build with the same linker errors after the latest commit.

@mkitzan commented on GitHub (Jan 18, 2020): My fork also fails to build with the same linker errors after the latest commit.
claunia commented 2026-01-31 00:28:03 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 18, 2020):

You might be able to work around this by building GdiRenderer manually. I think I missed that in the dependencies for that project, but didn't catch it since GdiRenderer.lib was already built on my machine.

I can take more of a look probably Wednesday at the earliest

@zadjii-msft commented on GitHub (Jan 18, 2020): You might be able to work around this by building GdiRenderer manually. I think I missed that in the dependencies for that project, but didn't catch it since GdiRenderer.lib was already built on my machine. I can take more of a look probably Wednesday at the earliest
claunia commented 2026-01-31 00:28:03 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 18, 2020):

You might be able to work around this by building GdiRenderer manually.

That didn't seem to help, but what did work for me was adding RendererGdi as a reference in the UnitTests_TerminalCore project. I don't know if that's the right solution, but it does at least build.

For now, though, I'm just branching off the previous commit, so it's not a major problem.

@j4james commented on GitHub (Jan 18, 2020): > You might be able to work around this by building GdiRenderer manually. That didn't seem to help, but what did work for me was adding _RendererGdi_ as a reference in the _UnitTests_TerminalCore_ project. I don't know if that's the right solution, but it does at least build. For now, though, I'm just branching off the previous commit, so it's not a major problem.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6023
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?