starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Incorrect space sanitization for shell creation #6087

New Issue
Closed
opened 2026-01-31 00:29:28 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 00:29:28 +00:00
Owner
Copy Link

Originally created by @sqlrob on GitHub (Jan 21, 2020).

Environment

> [Environment]::OSVersion

Platform ServicePack Version      VersionString
-------- ----------- -------      -------------
 Win32NT             10.0.18363.0 Microsoft Windows NT 10.0.18363.0

Terminal version 0.8.10091.0

Steps to reproduce

  1. Create a file C:\Program, contents irrelevant; this applies to en-us, other languages will have different names.
  2. Open a powershell tab (other shells may have the issue, didn't check)

Expected behavior

Tab opens with a usable Powershell

Actual behavior

Window opens with the message

[error 0x800700c1 when launching `powershell.exe']
Originally created by @sqlrob on GitHub (Jan 21, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none > [Environment]::OSVersion Platform ServicePack Version VersionString -------- ----------- ------- ------------- Win32NT 10.0.18363.0 Microsoft Windows NT 10.0.18363.0 ``` Terminal version 0.8.10091.0 # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. Create a file `C:\Program`, contents irrelevant; this applies to en-us, other languages will have different names. 2. Open a powershell tab (other shells may have the issue, didn't check) # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> Tab opens with a usable Powershell # Actual behavior <!-- What's actually happening? --> Window opens with the message ```none [error 0x800700c1 when launching `powershell.exe'] ```
claunia added the Resolution-Duplicate label 2026-01-31 00:29:28 +00:00
claunia commented 2026-01-31 00:29:28 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 21, 2020):

(For the shell,)
This is, and always will be, how CreateProcess with search path expansion works. Sorry.

  • We're relying on the system to do PATH resolution
  • If we implement our own heuristics here, we have to expand PATH and PATHEXT to properly populate the first arg to CreateProcess.
  • Even if we fix this, other applications will fail in the same way.
  • You need to be an admin to make a file there; there are far easier ways to break Terminal

(For the console host,)
This was fixed by #4172, which will be in the next servicing update... which may make this a /dup of #4061

@DHowett-MSFT commented on GitHub (Jan 21, 2020): (For the shell,) This is, and always will be, how CreateProcess with search path expansion works. Sorry. * We're relying on the system to do `PATH` resolution * If we implement our own heuristics here, we have to expand `PATH` _and_ `PATHEXT` to properly populate the first arg to `CreateProcess`. * Even if we fix this, other applications will fail in the same way. * You need to be an admin to make a file there; there are far easier ways to break Terminal (For the console host,) This was fixed by #4172, which will be in the next servicing update... which may make this a /dup of #4061
claunia commented 2026-01-31 00:29:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 21, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jan 21, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 00:29:29 +00:00
Author
Owner
Copy Link

@sqlrob commented on GitHub (Jan 21, 2020):

Shells are in well defined locations. Why is PATH even being used?

@sqlrob commented on GitHub (Jan 21, 2020): Shells are in well defined locations. Why is PATH even being used?
claunia commented 2026-01-31 00:29:29 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 21, 2020):

I'm not sure I agree that shells are in well-defined locations- A user's entitled to reorganize PATH such that their preferred instance of pwsh.exe comes first, or so that they can set version priorities for OpenSSH. Shells are wherever the user wants to put them!

@DHowett-MSFT commented on GitHub (Jan 21, 2020): I'm not sure I agree that shells are in well-defined locations- A user's entitled to reorganize `PATH` such that their preferred instance of `pwsh.exe` comes first, or so that they can set version priorities for OpenSSH. Shells are wherever the user wants to put them!
claunia commented 2026-01-31 00:29:29 +00:00
Author
Owner
Copy Link

@eryksun commented on GitHub (Jan 22, 2020):

* If we implement our own heuristics here, we have to expand `PATH` _and_ `PATHEXT` to properly populate the first arg to `CreateProcess`.

CreateProcessW doesn't use PATHEXT. It calls SearchPathW with an optional ".EXE" extension.

@eryksun commented on GitHub (Jan 22, 2020): > * If we implement our own heuristics here, we have to expand `PATH` _and_ `PATHEXT` to properly populate the first arg to `CreateProcess`. `CreateProcessW` doesn't use `PATHEXT`. It calls `SearchPathW` with an optional ".EXE" extension.
claunia commented 2026-01-31 00:29:29 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 22, 2020):

Fair enough.

@DHowett-MSFT commented on GitHub (Jan 22, 2020): Fair enough.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6087
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?