starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

The Resize Window escape sequence doesn't support omitted and zero parameters #6216

New Issue
Open
opened 2026-01-31 00:32:37 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 00:32:37 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 30, 2020).

Environment

Windows build number: Version 10.0.18362.535

Steps to reproduce

  1. Open a bash shell in conshot
  2. Set the window size to 80x25 with printf "\e[8;25;80t"
  3. Set just the height parameter to 30 with printf "\e[8;30t"
  4. Set just the width parameter to 100 with printf "\e[8;;100t"
  5. Set both width and height to zero with printf "\e[8;0;0t"

Expected behavior

According to the XTerm documentation, omitted parameters should reuse the current height or width, while zero parameters should use the display's height or width.

  • Step 2 should set the window size to 80x25
  • Step 3 should set the window size to 80x30 (i.e. just changing the height)
  • Step 4 should set the window size to 100x30 (i.e. just changing the width)
  • Step 5 should set the window size to full screen.

Actual behavior

Step 2 works as expected, but the remaining steps have no effect.

That said, this functionality doesn't seem to be widely supported (the only terminals I've seen that got it right were XTerm and Mintty), so it's probably not that important.

Originally created by @j4james on GitHub (Jan 30, 2020). # Environment ```none Windows build number: Version 10.0.18362.535 ``` # Steps to reproduce 1. Open a bash shell in conshot 2. Set the window size to 80x25 with `printf "\e[8;25;80t"` 3. Set just the height parameter to 30 with `printf "\e[8;30t"` 4. Set just the width parameter to 100 with `printf "\e[8;;100t"` 5. Set both width and height to zero with `printf "\e[8;0;0t"` # Expected behavior According to the [XTerm documentation](https://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h4-Functions-using-CSI-_-ordered-by-the-final-character-lparen-s-rparen:CSI-Ps;Ps;Ps-t:Ps-=-8;height;width.2519), omitted parameters should reuse the current height or width, while zero parameters should use the display's height or width. * Step 2 should set the window size to 80x25 * Step 3 should set the window size to 80x30 (i.e. just changing the height) * Step 4 should set the window size to 100x30 (i.e. just changing the width) * Step 5 should set the window size to full screen. # Actual behavior Step 2 works as expected, but the remaining steps have no effect. That said, this functionality doesn't seem to be widely supported (the only terminals I've seen that got it right were XTerm and Mintty), so it's probably not that important.
claunia added the Product-ConhostIssue-BugArea-VT labels 2026-01-31 00:32:37 +00:00
claunia commented 2026-01-31 00:32:38 +00:00
Author
Owner
Copy Link

@egmontkob commented on GitHub (Jan 30, 2020):

omitted parameters should reuse the current height or width, while zero parameters should use the display's height or width

My interpretation of ECMA-48 5.4.2

e) An empty parameter sub-string represents a default value which depends on the control function

is that an empty parameter must be equivalent to a certain valid explicitly specified value. Given that the values in this context are expected to be unsigned integers, the default must also be an unsigned int, like 0, 1, 999 or so – leaving room for only one special action for the number 0, and not being able to express two different special actions ("unchanged" vs. "maximized"). I might be wrong, though.

On a more important note, I believe that this escape sequence with a fixed size is borderline problematic/harmful, whereas this one with the "maximized" value, and other nearby escape sequences, are straight harmful (just like when webpages that are allowed to move/resize the browser window – everyone hates that, right?) and terminals should deliberately refuse to implement. (Yeah I know vttest tests for 80/132 column switching...) See also https://gitlab.gnome.org/GNOME/vte/issues/128#note_524609.

@egmontkob commented on GitHub (Jan 30, 2020): > omitted parameters should reuse the current height or width, while zero parameters should use the display's height or width My interpretation of ECMA-48 5.4.2 e) An empty parameter sub-string represents a default value which depends on the control function is that an empty parameter _must_ be equivalent to a certain valid explicitly specified value. Given that the values in this context are expected to be unsigned integers, the default must also be an unsigned int, like 0, 1, 999 or so – leaving room for only one special action for the number 0, and not being able to express two different special actions ("unchanged" vs. "maximized"). I might be wrong, though. On a more important note, I believe that this escape sequence with a fixed size is borderline problematic/harmful, whereas this one with the "maximized" value, and other nearby escape sequences, are straight harmful (just like when webpages that are allowed to move/resize the browser window – everyone hates that, right?) and terminals should deliberately refuse to implement. (Yeah I know vttest tests for 80/132 column switching...) See also https://gitlab.gnome.org/GNOME/vte/issues/128#note_524609.
claunia commented 2026-01-31 00:32:38 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 30, 2020):

My interpretation of ECMA-48 5.4.2

e) An empty parameter sub-string represents a default value which depends on the control function

is that an empty parameter must be equivalent to a certain valid explicitly specified value.

I think you're reading too much into that. At any rate, this sort of thing isn't without precedent. The second parameter of DECSTBM has a default value of "current number of lines per screen" (although in that case, zero is at least the same as the default).

Still, like it or not, that's how the operation is defined. Whether you choose to support it or not is a separate question, and not one I expect everyone to agree on. We already do support it (at least in conhost), so this issue is just about getting us more closely aligned with the specification.

On a more important note, I believe that this escape sequence with a fixed size is borderline problematic/harmful, whereas this one with the "maximized" value, and other nearby escape sequences, are straight harmful

Personally I don't have a problem with apps resizing the window, because a regular Windows console app would already be able to do that. And I wouldn't want to ban all apps from using certain functionality just because some trollish app might decide to do something annoying with that functionality - a resized window isn't going to kill me. And if that is a major concern for users, we could always add an option to disable sizing ops (I think XTerm has something like that).

@j4james commented on GitHub (Jan 30, 2020): > My interpretation of ECMA-48 5.4.2 > > > e) An empty parameter sub-string represents a default value which depends on the control function > > is that an empty parameter _must_ be equivalent to a certain valid explicitly specified value. I think you're reading too much into that. At any rate, this sort of thing isn't without precedent. The second parameter of `DECSTBM` has a default value of "current number of lines per screen" (although in that case, zero is at least the same as the default). Still, like it or not, that's how the operation is defined. Whether you choose to support it or not is a separate question, and not one I expect everyone to agree on. We already do support it (at least in conhost), so this issue is just about getting us more closely aligned with the specification. > On a more important note, I believe that this escape sequence with a fixed size is borderline problematic/harmful, whereas this one with the "maximized" value, and other nearby escape sequences, are straight harmful Personally I don't have a problem with apps resizing the window, because a regular Windows console app would already be able to do that. And I wouldn't want to ban all apps from using certain functionality just because some trollish app might decide to do something annoying with that functionality - a resized window isn't going to kill me. And if that is a major concern for users, we could always add an option to disable sizing ops (I think XTerm has something like that).
claunia commented 2026-01-31 00:32:38 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 31, 2020):

From the perspective of "conhost supports this, so WT should support this" I totally agree.

Alternatively, I rather dislike how this works in a world where multiple terminals might be hosted in one application window. This will be uncomfortable to implement with split panes as well. 😄

@DHowett-MSFT commented on GitHub (Jan 31, 2020): From the perspective of "conhost supports this, so WT should support this" I totally agree. Alternatively, I rather dislike how this works in a world where multiple terminals might be hosted in one application window. This will be uncomfortable to implement with split panes as well. :smile:
claunia commented 2026-01-31 00:32:38 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 31, 2020):

(I do think that conhost should do something with 0, so I've tagged this up mostly for conhost's sake. What that thing is should be determined by what most other terminal emulators do.)

@DHowett-MSFT commented on GitHub (Jan 31, 2020): (I do think that conhost should do _something_ with `0`, so I've tagged this up mostly for conhost's sake. What that thing _is_ should be determined by what most other terminal emulators do.)
claunia commented 2026-01-31 00:32:39 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 31, 2020):

I was only expecting this to work in conhost. WT's handling of programmatic resizing is completely broken, and I'm not sure if there is any way to fix it. At any rate, I think it's a big enough problem that it should probably be dealt with as a separate issue.

@j4james commented on GitHub (Jan 31, 2020): I was only expecting this to work in conhost. WT's handling of programmatic resizing is completely broken, and I'm not sure if there is any way to fix it. At any rate, I think it's a big enough problem that it should probably be dealt with as a separate issue.
claunia commented 2026-01-31 00:32:39 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jan 31, 2020):

Excellent. Re-tagged.

@DHowett-MSFT commented on GitHub (Jan 31, 2020): Excellent. Re-tagged.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?