starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ColorTool: parser bugfixes and small code refactor #624

New Issue
Closed
opened 2026-01-30 21:57:17 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 21:57:17 +00:00
Owner
Copy Link

Originally created by @waf on GitHub (Apr 21, 2019).

I'm using ColorTool as part of managing a theme for cmd / powershell, and I've run into a few issues using it:

  1. Error messages being thrown from parsers that are unused, e.g. the INI parser tries to run even if you are using itermcolors, so it throws errors because XML is not a valid INI file.
  2. Foreground / Background indexes aren't saved when using --defaults (or --both).

These are easy enough fixes and I'm happy to fix them. I was thinking of cleaning up the code a little bit while I'm there, namely:

  1. Allowing parsers to conditionally run, so not all parsers run for every file (should squelch some errors)
  2. Adding a common interface for "setting current console properties" and "console defaults," so it's harder to forget implementing functionality for either.

However, before I start working on this, I wanted to give you a heads-up, and make sure I wasn't working at cross-purposes with someone on the project. Would you be interested in a PR that fixes the above 2 points?

Thanks!

Originally created by @waf on GitHub (Apr 21, 2019). I'm using ColorTool as part of managing a theme for cmd / powershell, and I've run into a few issues using it: 1. Error messages being thrown from parsers that are unused, e.g. the INI parser tries to run even if you are using `itermcolors`, so it throws errors because XML is not a valid INI file. 2. Foreground / Background indexes aren't saved when using `--defaults` (or `--both`). These are easy enough fixes and I'm happy to fix them. I was thinking of cleaning up the code a little bit while I'm there, namely: 1. Allowing parsers to conditionally run, so not all parsers run for every file (should squelch some errors) 2. Adding a common interface for "setting current console properties" and "console defaults," so it's harder to forget implementing functionality for either. However, before I start working on this, I wanted to give you a heads-up, and make sure I wasn't working at cross-purposes with someone on the project. Would you be interested in a PR that fixes the above 2 points? Thanks!
claunia added the Product-ColortoolResolution-Fix-AvailableArea-SettingsIssue-Bug labels 2026-01-30 21:57:17 +00:00
claunia commented 2026-01-30 21:57:18 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 21, 2019):

@waf, that would be a very welcome change. Nobody on our side is currently working on either of those.

@DHowett-MSFT commented on GitHub (Apr 21, 2019): @waf, that would be a very welcome change. Nobody on our side is currently working on either of those.
claunia commented 2026-01-30 21:57:18 +00:00
Author
Owner
Copy Link

@waf commented on GitHub (Apr 25, 2019):

@DHowett-MSFT thanks, I've opened #418 for this.

@waf commented on GitHub (Apr 25, 2019): @DHowett-MSFT thanks, I've opened #418 for this.
claunia commented 2026-01-30 21:57:18 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 18, 2019):

I believe this is now available in the release I made a few weeks ago.

@miniksa commented on GitHub (May 18, 2019): I believe this is now available in the release I made a few weeks ago.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Product-Colortool Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#624
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?