starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ParseSplitPaneIntoArgs unit test is failing #6241

New Issue
Closed
opened 2026-01-31 00:33:13 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 00:33:13 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Feb 1, 2020).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: Version 10.0.18362.535
Windows Terminal version (if applicable): Commit 55b638801b

Steps to reproduce

  1. Build the OpenConsole solution.
  2. Run the unit tests with the runut.cmd script.

Expected behavior

All the tests should pass.

Actual behavior

The CommandlineTest::ParseSplitPaneIntoArgs test fails on line 593 with the message:

Error: Verify: AreEqual(SplitState::Vertical, myArgs.SplitStyle()) - Values (1, 4294967295) [File: \terminal\src\cascadia\LocalTests_TerminalApp\CommandlineTest.cpp, Function: TerminalAppLocalTests::CommandlineTest::ParseSplitPaneIntoArgs, Line: 593]
EndGroup: TerminalAppLocalTests::CommandlineTest::ParseSplitPaneIntoArgs [Failed]

That particular error looks to me like a mistake in the test itself. If the command line doesn't include a specific style, I would expect the style to be SplitState::Automatic. I'm guessing this is the result of a change in behavior as the code evolved. And I believe the tests on line 653 and line 707 will fail for the same reason.

Even with those cases fixed, though, there is still a failure which I think is an indication of a real bug in the code. The test on line 633 is failing because it's expecting the style to be Vertical but the return value is Automatic. The code that is to blame is in the AppCommandlineArgs::_buildSplitPaneParser method:

b6ec670bd8/src/cascadia/TerminalApp/AppCommandlineArgs.cpp (L220-L230)

There are two problems with this code. The first is that the initial branch isn't even passed unless _splitHorizontal is true, so the _splitVertical case is never handled. The second is that even with that fixed, the _splitVertical case will end up setting the style to Horizontal rather than Vertical.

Originally created by @j4james on GitHub (Feb 1, 2020). Originally assigned to: @zadjii-msft on GitHub. # Environment Windows build number: Version 10.0.18362.535 Windows Terminal version (if applicable): Commit 55b638801b0eac586f0a3db00e8a375655f8ead0 # Steps to reproduce 1. Build the _OpenConsole_ solution. 2. Run the unit tests with the `runut.cmd` script. # Expected behavior All the tests should pass. # Actual behavior The `CommandlineTest::ParseSplitPaneIntoArgs` test fails on [line 593](https://github.com/microsoft/terminal/blob/3487664cb0068d49b930e9524d1641bae55a32a9/src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp#L593) with the message: ``` Error: Verify: AreEqual(SplitState::Vertical, myArgs.SplitStyle()) - Values (1, 4294967295) [File: \terminal\src\cascadia\LocalTests_TerminalApp\CommandlineTest.cpp, Function: TerminalAppLocalTests::CommandlineTest::ParseSplitPaneIntoArgs, Line: 593] EndGroup: TerminalAppLocalTests::CommandlineTest::ParseSplitPaneIntoArgs [Failed] ``` That particular error looks to me like a mistake in the test itself. If the command line doesn't include a specific style, I would expect the style to be `SplitState::Automatic`. I'm guessing this is the result of a change in behavior as the code evolved. And I believe the tests on [line 653](https://github.com/microsoft/terminal/blob/3487664cb0068d49b930e9524d1641bae55a32a9/src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp#L653) and [line 707](https://github.com/microsoft/terminal/blob/3487664cb0068d49b930e9524d1641bae55a32a9/src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp#L707) will fail for the same reason. Even with those cases fixed, though, there is still a failure which I think is an indication of a real bug in the code. The test on [line 633](https://github.com/microsoft/terminal/blob/3487664cb0068d49b930e9524d1641bae55a32a9/src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp#L633) is failing because it's expecting the style to be `Vertical` but the return value is `Automatic`. The code that is to blame is in the `AppCommandlineArgs::_buildSplitPaneParser` method: https://github.com/microsoft/terminal/blob/b6ec670bd8cf8ac7f6f7e67ac28a0210ba56b2c8/src/cascadia/TerminalApp/AppCommandlineArgs.cpp#L220-L230 There are two problems with this code. The first is that the initial branch isn't even passed unless `_splitHorizontal` is true, so the `_splitVertical` case is never handled. The second is that even with that fixed, the `_splitVertical` case will end up setting the style to `Horizontal` rather than `Vertical`.
claunia commented 2026-01-31 00:33:15 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 7, 2020):

Yanking triage- i hit this as well, thanks for filing a followup

@DHowett-MSFT commented on GitHub (Feb 7, 2020): Yanking triage- i hit this as well, thanks for filing a followup
claunia commented 2026-01-31 00:33:15 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 7, 2020):

I've put a test bug into v1.0 because it's in a feature we added and are shipping, and we darn well better make sure it works right.

@DHowett-MSFT commented on GitHub (Feb 7, 2020): I've put a test bug into v1.0 because it's in a feature we added and are shipping, and we darn well better make sure it works right.
claunia commented 2026-01-31 00:33:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 21, 2020):

Hey I just ran this locally and it looks like we must have fixed this recently. Hard to say for sure, but I bet it was back when we made auto the default behavior.

Fortunately with #6992 set up, we'll be more diligent about these tests in the future. Thanks!

@zadjii-msft commented on GitHub (Aug 21, 2020): Hey I just ran this locally and it looks like we must have fixed this recently. Hard to say for sure, but I bet it was back when we made `auto` the default behavior. Fortunately with #6992 set up, we'll be more diligent about these tests in the future. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-Commandline Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6241
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?