starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Inconsistent touch screen scrolling #6383

New Issue
Open
opened 2026-01-31 00:37:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 00:37:14 +00:00
Owner
Copy Link

Originally created by @jamestut on GitHub (Feb 12, 2020).

Environment

Windows build number: 10.0.18363.628
Windows Terminal version (if applicable): 543f5339d73ed49ccf3392627663c59cd5e51aec

Any other software?

Steps to reproduce

Scroll the terminal viewport using touch screen.

Expected behavior

Viewport should move consistently, line by line, and the scrolling should "follow the finger".

Actual behavior

Scrolling is not consistent, and jellying/jumping. This is very apparent especially when scrolling the viewport up, where the line moves by 2 instead of 1. Also when scrolling quickly, the actual scrolling lags a little bit.

Proposed Fix

Since this is caused by rounding errors, I modified the scrolling to operate on _scrollBar's Value directly (which uses double) instead of calculating the previous offset from GetScrollOffset in TermControl.cpp.

Tested this and I didn't found any glitches with this approach, and now the touch screen scrolling works as expected.

Originally created by @jamestut on GitHub (Feb 12, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.18363.628 Windows Terminal version (if applicable): 543f5339d73ed49ccf3392627663c59cd5e51aec Any other software? ``` # Steps to reproduce Scroll the terminal viewport using touch screen. <!-- A description of how to trigger this bug. --> # Expected behavior Viewport should move consistently, line by line, and the scrolling should "follow the finger". <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior Scrolling is not consistent, and jellying/jumping. This is very apparent especially when scrolling the viewport up, where the line moves by 2 instead of 1. Also when scrolling quickly, the actual scrolling lags a little bit. <!-- What's actually happening? --> # Proposed Fix Since this is caused by rounding errors, I modified the scrolling to operate on `_scrollBar`'s `Value` directly (which uses `double`) instead of calculating the previous offset from `GetScrollOffset` in `TermControl.cpp`. Tested this and I didn't found any glitches with this approach, and now the touch screen scrolling works as expected.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6383
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?