starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ambiguous width character incorrectly sized when UseDx enabled in conhost #6466

New Issue
Closed
opened 2026-01-31 00:39:32 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 00:39:32 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Feb 15, 2020).

Environment

Windows build number: Version 10.0.18362.535
Windows Terminal version (if applicable): n/a
Conhost built from commit 4634a68a9b

Steps to reproduce

  1. Set the UseDx registry entry to 1
  2. Open a WSL bash shell in conhost
  3. Run the command printf "12\n\uFFFD\n"

Expected behavior

U+FFFD is an ambiguous width character, which I thought we were supposed to be interpreting as narrow (see PR #2928). It certainly seems to work that way in Windows Terminal.

image

Actual behavior

In conhost (when UseDx is enabled), ambiguous width characters appear to be dependent on the font, so on my system this character is being rendered over two columns as if it were a wide character.

image

Looking at PR #2928, I see we made the glyph width fallback method in TermControl.cpp return false for all values. If I do something similar for the SetGlyphWidthFallback call in srvinit.cpp, that fixes the problem. Is there a reason why we don't want to do that? Are there backwards compatibility issues?

Originally created by @j4james on GitHub (Feb 15, 2020). # Environment Windows build number: Version 10.0.18362.535 Windows Terminal version (if applicable): n/a Conhost built from commit 4634a68a9bbedd860f62cca5748d36c79afb1f82 # Steps to reproduce 1. Set the _UseDx_ registry entry to 1 2. Open a WSL bash shell in conhost 3. Run the command `printf "12\n\uFFFD\n"` # Expected behavior `U+FFFD` is an ambiguous width character, which I thought we were supposed to be interpreting as narrow (see PR #2928). It certainly seems to work that way in Windows Terminal. ![image](https://user-images.githubusercontent.com/4181424/74591836-37439c80-5013-11ea-9207-a8a69eb90450.png) # Actual behavior In conhost (when _UseDx_ is enabled), ambiguous width characters appear to be dependent on the font, so on my system this character is being rendered over two columns as if it were a wide character. ![image](https://user-images.githubusercontent.com/4181424/74591847-52aea780-5013-11ea-88dd-088e553f6ca8.png) Looking at PR #2928, I see we made the glyph width fallback method in [_TermControl.cpp_](https://github.com/microsoft/terminal/blob/38ebf48d79f65d6460451e1b4ff5c5f6f010d9b9/src/cascadia/TerminalControl/TermControl.cpp#L29-L46) return false for all values. If I do something similar for the `SetGlyphWidthFallback` call in [_srvinit.cpp_](https://github.com/microsoft/terminal/blob/a13ccfd0f5c1a63ba602d78afba72ab3abaabf34/src/host/srvinit.cpp#L550-L553), that fixes the problem. Is there a reason why we don't want to do that? Are there backwards compatibility issues?
claunia commented 2026-01-31 00:39:33 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 18, 2020):

This is just one of those weird things that the console host is going to have to do for compatibility--this behavior is conserved with the GDI renderer, where I believe we always queried the font when we didn't know. To change that would, perhaps, pose a compatibility issue for CJK/"FE" consumers. ☹️
(@miniksa can keep me honest here)

@DHowett-MSFT commented on GitHub (Feb 18, 2020): This is just one of those _weird_ things that the console host is going to have to do for compatibility--this behavior is conserved with the GDI renderer, where I believe we always queried the font when we didn't know. To change that would, perhaps, pose a compatibility issue for CJK/"FE" consumers. ☹️ (@miniksa can keep me honest here)
claunia commented 2026-01-31 00:39:34 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Feb 18, 2020):

I figured it might be something like that. But I thought maybe we could apply the narrow-ambiguous behavior only when in VT mode, and/or only when UseDx is enabled, assuming those are both opt-in modes. Not the end of the world though.

@j4james commented on GitHub (Feb 18, 2020): I figured it might be something like that. But I thought maybe we could apply the narrow-ambiguous behavior only when in VT mode, and/or only when _UseDx_ is enabled, assuming those are both opt-in modes. Not the end of the world though.
claunia commented 2026-01-31 00:39:34 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 18, 2020):

In the fullness of time, Dx will (fingers crossed, schedules permitting, etc., etc.) be a viable renderer for the inbox console host as well, and unfortunately VT mode doesn't preclude an application from reading out the output buffer because that application is insane. 😄

This might be a good candidate for the I_SOLEMNLY_SWEAR_I_WILL_BE_A_GOOD_CITIZEN console mode.

@DHowett-MSFT commented on GitHub (Feb 18, 2020): In the fullness of time, Dx will (fingers crossed, schedules permitting, etc., etc.) be a viable renderer for the inbox console host as well, and unfortunately VT mode doesn't preclude an application from reading out the output buffer because that application is insane. :smile: This might be a good candidate for the `I_SOLEMNLY_SWEAR_I_WILL_BE_A_GOOD_CITIZEN` console mode.
claunia commented 2026-01-31 00:39:34 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 18, 2020):

I'm gonna close this one out with my condolences.

@DHowett-MSFT commented on GitHub (Feb 18, 2020): I'm gonna close this one out with my condolences.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-3 Product-Conhost Resolution-Won't-Fix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6466
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?