starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash: _terminal (and other members?) used after freed in TermControl #6475

New Issue
Closed
opened 2026-01-31 00:39:44 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 00:39:44 +00:00
Owner
Copy Link

Originally created by @beviu on GitHub (Feb 16, 2020).

Originally assigned to: @DHowett-MSFT on GitHub.

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable): master (672010a1)

Any other software?

Steps to reproduce

  1. Open the terminal
  2. Put your mouse cursor on the + button to open a new tab
  3. Quickly click with the left mouse button and then click with the middle mouse button to open a tab and close it. If you do it right, you should get this error message (which might be a bug in and of itself?): image
  4. Don't click OK yet!
  5. Focus the terminal window, behind that error message.
  6. Repeat 3. Nothing will happen because the application is frozen while you click OK in the dialog.
  7. Click OK in the dialog.
  8. Now, the dialog closes and another dialog with the same error message opens. If it didn't open, you need to start again from 2. You'll need to train to click with the right timing.
  9. Click OK in the new dialog.
  10. Terminal crashes!

Expected behavior

No crash.

Actual behavior

Crash on this line: 941a44a464/src/cascadia/TerminalControl/TermControl.cpp (L563) because even though we check that this is still alive with weakThis, _terminal is null. Also, it seems that there are other places where we do check this but don't check members that could be null now because Close was called. It's scary!

Originally created by @beviu on GitHub (Feb 16, 2020). Originally assigned to: @DHowett-MSFT on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] Windows Terminal version (if applicable): master (672010a1) Any other software? ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. Open the terminal 2. Put your mouse cursor on the <kbd>+</kbd> button to open a new tab 3. Quickly click with the left mouse button and then click with the middle mouse button to open a tab and close it. If you do it right, you should get this error message (which might be a bug in and of itself?): ![image](https://user-images.githubusercontent.com/56923875/74605546-4c7b0280-50c9-11ea-9e06-07c1c54c2304.png) 4. **Don't click <kbd>OK</kbd> yet!** 5. Focus the terminal window, behind that error message. 6. Repeat 3. Nothing will happen because the application is frozen while you click <kbd>OK</kbd> in the dialog. 7. Click <kbd>OK</kbd> in the dialog. 8. Now, the dialog closes and another dialog with the same error message opens. If it didn't open, you need to start again from 2. You'll need to train to click with the right timing. 9. Click <kbd>OK</kbd> in the new dialog. 10. Terminal crashes! # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> No crash. # Actual behavior <!-- What's actually happening? --> Crash on this line: https://github.com/microsoft/terminal/blob/941a44a46491e1a018419eb24c9d92d3b2640e55/src/cascadia/TerminalControl/TermControl.cpp#L563 because even though we check that `this` is still alive with `weakThis`, `_terminal` is null. Also, it seems that there are other places where we do check `this` but don't check members that could be null now because `Close` was called. It's scary!
claunia commented 2026-01-31 00:39:46 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 21, 2020):

Triaged this one into v1.0 - it's stability and reliability, sp p1

@DHowett-MSFT commented on GitHub (Feb 21, 2020): Triaged this one into v1.0 - it's stability and reliability, sp p1
claunia commented 2026-01-31 00:39:46 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 21, 2020):

The "c0000142" error is actually because powershell was started and its parent console object died before it had a chance. That one we just can't help here 😄

@DHowett-MSFT commented on GitHub (Feb 21, 2020): The "c0000142" error is actually because powershell was started and its parent console object died before it had a chance. That one we just can't help here :smile:
claunia commented 2026-01-31 00:39:46 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 6, 2020):

Okay I tried to to this naively and bluescreened my laptop. I'm not touching this, but @DHowett-MSFT has an idea of how to go about this, so I'm going to let him have it

@zadjii-msft commented on GitHub (Mar 6, 2020): Okay I tried to to this naively and bluescreened my laptop. I'm _not_ touching this, but @DHowett-MSFT has an idea of how to go about this, so I'm going to let him have it
claunia commented 2026-01-31 00:39:46 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5051, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5051, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Needs-Tag-Fix Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6475
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?