starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 16:34:42 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

colortool: inconsistent color with iterm2 #65

New Issue
Closed
opened 2026-01-30 21:41:15 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 21:41:15 +00:00
Owner
Copy Link

Originally created by @yatli on GitHub (Feb 6, 2018).

build 16299, using colortool from e0248749eb

Repro:

Expect:

  • same colors

Actual:

  • different colors

Comparison:
image
Note how some of the values differ subtly with the original. Especially for the grey colors. Some are swallowed in the background.

Possibly related to the color space? In iterm2 xml the rgb components are companioned with a color profile (sRGB etc.)

Also, we should parse the foreground & background colors and set them in the console.

A more drastic example:
image

This one should be due to missing background & foreground.

Originally created by @yatli on GitHub (Feb 6, 2018). build 16299, using colortool from https://github.com/Microsoft/console/commit/e0248749eb0874a61975109f7d09bfe8246ee92a Repro: - clone the iTerm2-Color-Schemes repo from https://github.com/mbadolato/iTerm2-Color-Schemes - use colortool to apply a scheme, say `Argonaut` - compare the console colors with the colors in the iTerm2 color schemes repo screenshots Expect: - same colors Actual: - different colors Comparison: ![image](https://user-images.githubusercontent.com/20684720/35841484-26d673b8-0b37-11e8-9da5-52a467a7a068.png) Note how some of the values differ subtly with the original. Especially for the grey colors. Some are swallowed in the background. Possibly related to the color space? In iterm2 xml the rgb components are companioned with a color profile (sRGB etc.) Also, we should parse the foreground & background colors and set them in the console. A more drastic example: ![image](https://user-images.githubusercontent.com/20684720/35841655-17aa22bc-0b38-11e8-844d-6d5be78556a8.png) This one should be due to missing background & foreground.
claunia added the Issue-FeatureProduct-ConhostResolution-Duplicate labels 2026-01-30 21:41:15 +00:00
claunia commented 2026-01-30 21:41:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 12, 2018):

This has been discussed before on #23.

Essentially, the console doesn't have a seperate "Background Color" seperate from the color table - it uses one entry of the color table as it's "background color". So if the itermcolors scheme has a different background color from the black color, then the applied scheme is going to look different. It's as close as we can get to what's in the scheme with what conhost can do.

I absolutely want to fix this, but unfortunately its a pretty massive change to the codebase that'd be hard to get signed off on.

I'm going to close this isse as a dupe of the other, and use the other one for tracking the feature.

@zadjii-msft commented on GitHub (Feb 12, 2018): This has been discussed before on #23. Essentially, the console doesn't have a seperate "Background Color" seperate from the color table - it uses one entry of the color table as it's "background color". So if the itermcolors scheme has a different background color from the black color, then the applied scheme is going to look different. It's as close as we can get to what's in the scheme with what conhost can do. I absolutely want to fix this, but unfortunately its a pretty massive change to the codebase that'd be hard to get signed off on. I'm going to close this isse as a dupe of the other, and use the other one for tracking the feature.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Product-Conhost Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#65
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?