starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Discussion about further improvements for the colored tab #6545

New Issue
Closed
opened 2026-01-31 00:41:20 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:41:20 +00:00
Owner
Copy Link

Originally created by @gbaychev on GitHub (Feb 20, 2020).

@zadjii-msft @DHowett As mentioned in #3789 I'm opening this issue to have a discussion about further improvements and adjustments of the tab's custom color selection. If this was not what you had in mind, please close the issue.

The idea about ability to pick a custom color for a tab is described in #2994. Currently (at least in my opinion) there are two, maybe three things, which need to be discussed:

  • Should the coloring of the split button be removed and exactly which pieces of code need to go away? Or should be this activated by a setting?
  • How to signify the selected tab? Currently a lot of alpha transparency is added to color of the deselected tabs, is this good enough?
  • There was a suggestion that the painting of the non-client is maybe provided as a follow-up PR. Is this really needed, in which from, when (after or before the implementation of the xaml themeing)?
Originally created by @gbaychev on GitHub (Feb 20, 2020). @zadjii-msft @DHowett As mentioned in #3789 I'm opening this issue to have a discussion about further improvements and adjustments of the tab's custom color selection. If this was not what you had in mind, please close the issue. The idea about ability to pick a custom color for a tab is described in #2994. Currently (at least in my opinion) there are two, maybe three things, which need to be discussed: - Should the coloring of the split button be removed and exactly which pieces of code need to go away? Or should be this activated by a setting? - How to signify the selected tab? Currently a lot of alpha transparency is added to color of the deselected tabs, is this good enough? - There was a suggestion that the painting of the non-client is maybe provided as a follow-up PR. Is this really needed, in which from, when (after or before the implementation of the xaml themeing)?
claunia commented 2026-01-31 00:41:21 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 21, 2020):

(I tagged this one for discussion and put in on the backlog. Thanks for filing it!)

@DHowett-MSFT commented on GitHub (Feb 21, 2020): (I tagged this one for discussion and put in on the backlog. Thanks for filing it!)
claunia commented 2026-01-31 00:41:21 +00:00
Author
Owner
Copy Link

@gbaychev commented on GitHub (Feb 23, 2020):

So, about the first two things:

  1. I think that the coloring of the split button should go away in any form. It is awkward and looks bad.
  2. Regarding the signifying of the selected tab - I did a thing
    image

Now the selected tab has a colored bar inside of it (like the orange one). Firefox does something pretty similar with its container tabs. Why within the tab and not above it? Because I need to calculate the color of the selection bar based on the tab's background. But this can collide with the color of the non-client area (even if they are different colors, a low contrast between them can make the indicator bar invisible).

Pros:

  • it is better visible than if slapped above the tab
  • hey, I can make the corner of the tabs round again

Cons:

  • the tab is a little bit fatter and the split button looks a bit rectangular

I think I can bring the indicator bar a little bit closer to the bottom.
Also I'm pretty sure this is the way to go in regards to the indicating the selected bar. What are your thoughts/feedback?

P.S. Currently the code is nowhere checked-in.

@gbaychev commented on GitHub (Feb 23, 2020): So, about the first two things: 1. I think that the coloring of the split button should go away in any form. It is awkward and looks bad. 2. Regarding the signifying of the selected tab - I did a thing ![image](https://user-images.githubusercontent.com/3358056/75117329-aef77400-5670-11ea-84ee-fa30cfcb75ac.png) Now the selected tab has a colored bar inside of it (like the orange one). Firefox does something pretty similar with its container tabs. Why within the tab and not above it? Because I need to calculate the color of the selection bar based on the tab's background. But this can collide with the color of the non-client area (even if they are different colors, a low contrast between them can make the indicator bar invisible). Pros: - it is better visible than if slapped above the tab - hey, I can make the corner of the tabs round again Cons: - the tab is a little bit fatter and the split button looks a bit rectangular I think I can bring the indicator bar a little bit closer to the bottom. Also I'm pretty sure this is the way to go in regards to the indicating the selected bar. What are your thoughts/feedback? P.S. Currently the code is nowhere checked-in.
claunia commented 2026-01-31 00:41:21 +00:00
Author
Owner
Copy Link

@jdhitsolutions commented on GitHub (Jul 29, 2020):

I think this is a related question or issue but I'm looking for a way to set the tab color as part of the profile json file.

@jdhitsolutions commented on GitHub (Jul 29, 2020): I think this is a related question or issue but I'm looking for a way to set the tab color as part of the profile json file.
claunia commented 2026-01-31 00:41:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 30, 2020):

@jdhitsolutions That's actually been discussed in a whole bunch of threads recently (search, #6878,#6707,#7073) - please refer to #1337, #3327, and the spec #5772 for more discussion.

@zadjii-msft commented on GitHub (Jul 30, 2020): @jdhitsolutions That's actually been discussed in a whole bunch of threads recently ([search](https://github.com/microsoft/terminal/issues?q=is%3Aissue+%22set+tab+color+%22+is%3Aclosed+), #6878,#6707,#7073) - please refer to #1337, #3327, and the spec #5772 for more discussion.
claunia commented 2026-01-31 00:41:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 9, 2021):

You know, we've let this discussion fester for a while. In the meantime though, we shipped colored tabs a while ago, and we really haven't had any complaints from people about which tab is selected. Honestly, people seem really happy with it as is (myself included!)

For housekeeping purposes, I'm gonna close this one out. Thanks again for working on this!

@zadjii-msft commented on GitHub (Dec 9, 2021): You know, we've let this discussion fester for a while. In the meantime though, we shipped colored tabs a while ago, and we really haven't had any complaints from people about _which_ tab is selected. Honestly, people seem really happy with it as is (myself included!) For housekeeping purposes, I'm gonna close this one out. Thanks again for working on this!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Question Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6545
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?