starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add setting for displaying all borders on active pane #6551

New Issue
Closed
opened 2026-01-31 00:41:28 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:41:28 +00:00
Owner
Copy Link

Originally created by @deoradh on GitHub (Feb 20, 2020).

Environment

Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.9.433.0

Any other software? No

Steps to reproduce

  1. Open tab
  2. Divide tab into two, either horizontally or vertically. Don't divide further.

Expected behavior

The UI clearly shows which pane has focus.

Actual behavior

The current design (#994) just highlights the internal borders between panes: it doesn't fully encircle the pane or provide other UI cues to the user. The shift in line placement in this case is about one line width, making the difference relatively imperceptible and largely useless at that point.

Straw man suggestion

The existing design relies on having multiple cells to allow for disambiguation. I'd suggest just showing all borders of the pane that has focus, making it clear in all cases.

Originally created by @deoradh on GitHub (Feb 20, 2020). # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version (if applicable): 0.9.433.0 Any other software? No ``` # Steps to reproduce 1. Open tab 2. Divide tab into two, either horizontally or vertically. Don't divide further. # Expected behavior The UI clearly shows which pane has focus. # Actual behavior The current design (#994) just highlights the internal borders between panes: it doesn't fully encircle the pane or provide other UI cues to the user. The shift in line placement in this case is about one line width, making the difference relatively imperceptible and largely useless at that point. # Straw man suggestion The existing design relies on having multiple cells to allow for disambiguation. I'd suggest just showing all borders of the pane that has focus, making it clear in all cases.
claunia commented 2026-01-31 00:41:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 20, 2020):

Questions:

  • Should all borders be visible around all panes always when this setting is enabled?
  • If no, when the borders are added to the active pane, should they:
    • cover content from the pane?
    • change the width/height of the pane content, to make room for the borders around the edges?
@zadjii-msft commented on GitHub (Feb 20, 2020): Questions: * Should all borders be visible around all panes _always_ when this setting is enabled? * If no, when the borders are added to the active pane, should they: - cover content from the pane? - change the width/height of the pane content, to make room for the borders around the edges?
claunia commented 2026-01-31 00:41:30 +00:00
Author
Owner
Copy Link

@deoradh commented on GitHub (Feb 20, 2020):

Should all borders be visible around all panes always when this setting is enabled?

If there are multiple panes, all borders should be visible on the pane that has focus. If there is only a single pane, the border is unnecessary.

If no, when the borders are added to the active pane, should they:
cover content from the pane?

No. Covering content in neighboring panes should be okay, but can be avoided if inter-pane spacing is appropriately sized (if all borders are drawn, that spacing can be shared in ways it cannot be, today). The question of what to do with the edges that correspond to the tab window itself is a slightly tricky one, of course.

change the width/height of the pane content, to make room for the borders around the edges?

No. You risk weird UI behaviors doing so (eg, scroll bars pop into existence for no apparent reason).

@deoradh commented on GitHub (Feb 20, 2020): > Should all borders be visible around all panes always when this setting is enabled? If there are multiple panes, all borders should be visible on the pane that has focus. If there is only a single pane, the border is unnecessary. > If no, when the borders are added to the active pane, should they: > cover content from the pane? No. Covering content in neighboring panes should be okay, but can be avoided if inter-pane spacing is appropriately sized (if all borders are drawn, that spacing can be shared in ways it cannot be, today). The question of what to do with the edges that correspond to the tab window itself is a slightly tricky one, of course. > change the width/height of the pane content, to make room for the borders around the edges? No. You risk weird UI behaviors doing so (eg, scroll bars pop into existence for no apparent reason).
claunia commented 2026-01-31 00:41:30 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 21, 2020):

I'm going to hook this up to #1000 and put it on the backlog, marked help-wanted.

I think there's a good UI we can come to that doesn't require us to add another setting.

Perhaps #3062 would help?

@DHowett-MSFT commented on GitHub (Feb 21, 2020): I'm going to hook this up to #1000 and put it on the backlog, marked help-wanted. I think there's a good UI we can come to that doesn't require us to add another setting. Perhaps #3062 would help?
claunia commented 2026-01-31 00:41:30 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Feb 21, 2020):

Actually, yeah, I'd like to roll this into /dup #3062. Providing better visual differentiation for focused versus unfocused terminals is going to do a lot more to solve this than adding another border option.

@DHowett-MSFT commented on GitHub (Feb 21, 2020): Actually, yeah, I'd like to roll this into /dup #3062. Providing better visual differentiation for focused versus unfocused terminals is going to do a lot more to solve this than adding another border option.
claunia commented 2026-01-31 00:41:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 21, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Feb 21, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Area-UserInterface Issue-Task Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6551
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?