Feature request: Keyboard shortcut to show all keyboard shortcuts #6595

@abhijeetviswam commented on GitHub (Mar 18, 2020):

How about something similar to what's done for vscode?
The shortcut to list all shortcuts will redirect to a URL - https://code.visualstudio.com/shortcuts/keyboard-shortcuts-windows.pdf

We can have a PDF listing all the keyboard shortcuts in doc/user-docs

@abhijeetviswam commented on GitHub (Mar 18, 2020): How about something similar to what's done for vscode? The shortcut to list all shortcuts will redirect to a URL - https://code.visualstudio.com/shortcuts/keyboard-shortcuts-windows.pdf We can have a PDF listing all the keyboard shortcuts in `doc/user-docs`

claunia commented

@thernstig commented on GitHub (Mar 18, 2020):

@abhijeetviswam The downside of that approach is that you will have to be connected to the internet to see them. VS Code has it built into VS Code as well, try pressing ctrl+s ctrl+k. I also feel forcing the user to leave the GUI is a bad UX experience.

@thernstig commented on GitHub (Mar 18, 2020): @abhijeetviswam The downside of that approach is that you will have to be connected to the internet to see them. VS Code has it built into VS Code as well, try pressing <kbd>ctrl+s ctrl+k</kbd>. I also feel forcing the user to leave the GUI is a bad UX experience.

claunia commented

@rafsawicki commented on GitHub (Apr 6, 2020):

I believe that in general, discoverability of features that are only available under keyboard shortcuts could be better. As a personal example, I'm used to working with multiple panes in terminal as in Terminator it's as easy as right click -> "split horizontally / vertically". Trying to do that in Windows Terminal was like:

right click - oops, that's a text paste
click on arrow beside plus button - nothing there
check out options, maybe it's there as a configuration option with a current shortcut - nope
give up and google for it

VS code has a great discoverability story in my opinion, as I can simply press Ctrl + Shift + P or click View -> Command Palette and then command search anything that I don't remember a shortcut for. I'm not sure how feasible is to do something similar in a terminal app.

@rafsawicki commented on GitHub (Apr 6, 2020): I believe that in general, discoverability of features that are only available under keyboard shortcuts could be better. As a personal example, I'm used to working with multiple panes in terminal as in Terminator it's as easy as right click -> "split horizontally / vertically". Trying to do that in Windows Terminal was like: - right click - oops, that's a text paste - click on arrow beside plus button - nothing there - check out options, maybe it's there as a configuration option with a current shortcut - nope - give up and google for it VS code has a great discoverability story in my opinion, as I can simply press Ctrl + Shift + P or click View -> Command Palette and then command search anything that I don't remember a shortcut for. I'm not sure how feasible is to do something similar in a terminal app.

claunia commented

@zadjii-msft commented on GitHub (Apr 6, 2020):

You sound like someone who'd be interested in:

#2046 - Command Palette, and the spec #2193
#3337 - A context menu within the terminal control
The default keybindings for panes:4f8acb4b9f/src/cascadia/TerminalApp/defaults.json (L245-L256)

@zadjii-msft commented on GitHub (Apr 6, 2020): You sound like someone who'd be interested in: * #2046 - Command Palette, and the spec #2193 * #3337 - A context menu within the terminal control * The default keybindings for panes:https://github.com/microsoft/terminal/blob/4f8acb4b9fbd61196d0a5287749a58abe0fbaa28/src/cascadia/TerminalApp/defaults.json#L245-L256

claunia commented

@Chips1234 commented on GitHub (Apr 17, 2020):

Sure, I can try implementing that.

@Chips1234 commented on GitHub (Apr 17, 2020): Sure, I can try implementing that.

claunia commented

@Chips1234 commented on GitHub (Apr 17, 2020):

What should the keyboard shortcut be to open this dialogue?

@Chips1234 commented on GitHub (Apr 17, 2020): What should the keyboard shortcut be to open this dialogue?

claunia commented

@thernstig commented on GitHub (Apr 18, 2020):

I think something with question mark, since in web apps in browser the most common shortcut is the question mark shift+? on my Swedish keyboard at least.

How about ctrl+shift+??

@thernstig commented on GitHub (Apr 18, 2020): I think something with question mark, since in web apps in browser the most common shortcut is the question mark <kbd>shift+?</kbd> on my Swedish keyboard at least. How about <kbd>ctrl+shift+?</kbd>?

claunia commented

@Chips1234 commented on GitHub (Apr 18, 2020):

Yeah, that will be good.

@Chips1234 commented on GitHub (Apr 18, 2020): Yeah, that will be good.

claunia commented

@Chips1234 commented on GitHub (Apr 18, 2020):

Or just shift+?

@Chips1234 commented on GitHub (Apr 18, 2020): Or just shift+?

claunia commented

@thernstig commented on GitHub (Apr 20, 2020):

Or just shift+?

How would you then just do a normal question mark? It is a terminal where you write after all 😆

@thernstig commented on GitHub (Apr 20, 2020): > Or just shift+? How would you then just do a normal question mark? It is a terminal where you write after all 😆

claunia commented

@zadjii-msft commented on GitHub (Apr 20, 2020):

ctrl+shift+? would probably be what I'd lean to (before doing any research on it), though we can always discuss what the default should be once we see a proof-of-concept. Changing the keybinding should be easy ☺️

@zadjii-msft commented on GitHub (Apr 20, 2020): <kbd>ctrl+shift+?</kbd> would probably be what I'd lean to (before doing any research on it), though we can always discuss what the default should be once we see a proof-of-concept. Changing the keybinding should be easy ☺️

claunia commented

@Chips1234 commented on GitHub (Apr 20, 2020):

Oh yeah, good point.

@Chips1234 commented on GitHub (Apr 20, 2020): Oh yeah, good point.

claunia commented

@Chips1234 commented on GitHub (May 10, 2020):

Is there any way to get the keybinding data entered in the settings.JSON file and display it over in a XAML file? I want it to change based on the user's input. Thanks in advance.

@Chips1234 commented on GitHub (May 10, 2020): Is there any way to get the keybinding data entered in the `settings.JSON` file and display it over in a XAML file? I want it to change based on the user's input. Thanks in advance.

claunia commented

@zadjii-msft commented on GitHub (May 11, 2020):

If there was a trivial way to do that, then this would probably already be done 😉

We do something similar in TerminalPage::_CreateNewTabFlyout, though I'd imagine for this dialog, we'd want something more efficient than manually creating every possible shortcut action to see i there's a key bound to it. We'd probably want AppKeyBindings to expose some sort of public way to query all the key->action mappings.

@zadjii-msft commented on GitHub (May 11, 2020): If there was a trivial way to do that, then this would probably already be done 😉 We do something similar in [TerminalPage::_CreateNewTabFlyout](https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalApp/TerminalPage.cpp#L283), though I'd imagine for this dialog, we'd want something more efficient than manually creating every possible shortcut action to see i there's a key bound to it. We'd probably want `AppKeyBindings` to expose some sort of public way to query all the key->action mappings.

claunia commented

@Chips1234 commented on GitHub (May 11, 2020):

Actually, I’m almost done with putting in every shortcut, I was just about to make a pull request.

@Chips1234 commented on GitHub (May 11, 2020): Actually, I’m almost done with putting in every shortcut, I was just about to make a pull request.

claunia commented

@MrM40 commented on GitHub (Feb 12, 2022):

Looking up shortcuts in the defaults.json directly is searchable (Ctrl+F) and that is very vaulable.

@MrM40 commented on GitHub (Feb 12, 2022): Looking up shortcuts in the [defaults.json](https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/defaults.json ) directly is searchable (Ctrl+F) and that is very vaulable.

claunia commented