Incorrect rendering of a TUI #6628

Closed
opened 2026-01-31 00:43:25 +00:00 by claunia · 8 comments
Owner

Originally created by @yossizahn on GitHub (Feb 26, 2020).

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.657]
Windows Terminal version (if applicable): 0.9.433.0

Any other software? WSL (version 1) + python

Steps to reproduce

Install ranger terminal file manager in WSL

pip install ranger-fm

run ranger:

ranger

Set it to show borders by pressing : (colon) followed by set draw_borders=True followed by the Enter key.

Expected behavior

It should display similar to this:
image

Actual behavior

The border sometimes disappears and the highlighted area overshoots the border
image

NOTE: It's very likely that this is a known bug, however I don't know enough about terminal sequences to understand the underlying cause of this...

Originally created by @yossizahn on GitHub (Feb 26, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18363.657] Windows Terminal version (if applicable): 0.9.433.0 Any other software? WSL (version 1) + python ``` # Steps to reproduce Install [ranger terminal file manager](https://github.com/ranger/ranger) in WSL ``` pip install ranger-fm ``` run ranger: ``` ranger ``` Set it to show borders by pressing `:` (colon) followed by `set draw_borders=True` followed by the Enter key. # Expected behavior It should display similar to this: ![image](https://user-images.githubusercontent.com/19174667/75352883-21f02d00-58b3-11ea-9347-28c1fded60e4.png) # Actual behavior The border sometimes disappears and the highlighted area overshoots the border ![image](https://user-images.githubusercontent.com/19174667/75352976-48ae6380-58b3-11ea-9970-13afa98af406.png) NOTE: It's very likely that this is a known bug, however I don't know enough about terminal sequences to understand the underlying cause of this...
Author
Owner

@oising commented on GitHub (Feb 26, 2020):

If you extend or reduce the horizontal width of the terminal itself by a few pixels, does it fix itself (you may need to force ranger to re-render itself) ?

@oising commented on GitHub (Feb 26, 2020): If you extend or reduce the horizontal width of the terminal itself by a few pixels, does it fix itself (you may need to force ranger to re-render itself) ?
Author
Owner

@yossizahn commented on GitHub (Feb 26, 2020):

@oising yes that fixes it temporarily, but the problem will reappear after interacting with the program a bit.

@yossizahn commented on GitHub (Feb 26, 2020): @oising yes that fixes it temporarily, but the problem will reappear after interacting with the program a bit.
Author
Owner

@DHowett-MSFT commented on GitHub (Feb 28, 2020):

Looks like an issue in conpty (of all things):

image

(happens in putty-wincon)

@DHowett-MSFT commented on GitHub (Feb 28, 2020): Looks like an issue in conpty (of all things): ![image](https://user-images.githubusercontent.com/14316954/75506747-d3ff2600-5993-11ea-8b3f-bc32176855fe.png) (happens in putty-wincon)
Author
Owner

@zadjii-msft commented on GitHub (Feb 28, 2020):

@DHowett-MSFT is that a master build of conpty? Just important to know for sure, since the last couple conpty PRs I had were touching a similar section of code

@zadjii-msft commented on GitHub (Feb 28, 2020): @DHowett-MSFT is that a `master` build of conpty? Just important to know for sure, since the last couple conpty PRs I had were touching a similar section of code
Author
Owner

@DHowett-MSFT commented on GitHub (Feb 28, 2020):

Yes, this repros with master. ☹️

@DHowett-MSFT commented on GitHub (Feb 28, 2020): Yes, this repros with master. ☹️
Author
Owner

@DHowett-MSFT commented on GitHub (Mar 18, 2020):

The strangest thing about this is that sometimes it does draw the border. When you flick between two directories, the righthand side gets and loses a border seemingly at random.

@DHowett-MSFT commented on GitHub (Mar 18, 2020): The strangest thing about this is that sometimes it _does_ draw the border. When you flick between two directories, the righthand side gets and loses a border seemingly at random.
Author
Owner

@DHowett-MSFT commented on GitHub (Mar 18, 2020):

We decide to use ED instead of ECH when we're overwriting the next-to-last cell in the row with spaces longer than an ECH/ED sequence.

@DHowett-MSFT commented on GitHub (Mar 18, 2020): We decide to use `ED` instead of `ECH` when we're overwriting the next-to-last cell in the row with spaces longer than an ECH/ED sequence.
Author
Owner

@ghost commented on GitHub (Mar 20, 2020):

:tada:This issue was addressed in #4994, which has now been successfully released as Windows Terminal Preview v0.10.781.0.🎉

Handy links:

@ghost commented on GitHub (Mar 20, 2020): :tada:This issue was addressed in #4994, which has now been successfully released as `Windows Terminal Preview v0.10.781.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.10.781.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6628