starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Support fullscreening with Win+Shift+Enter #6673

New Issue
Open
opened 2026-01-31 00:44:27 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 00:44:27 +00:00
Owner
Copy Link

Originally created by @xmha97 on GitHub (Mar 1, 2020).

Hello, I know this app will full-screen with Alt+Enter and F11
Please add a new keyboard shortcut for full-screen: Win+Shift+Enter
Why?! Because all universal apps became full-screen with Win+Shift+Enter
Thanks.

Originally created by @xmha97 on GitHub (Mar 1, 2020). Hello, I know this app will full-screen with `Alt`+`Enter` and `F11` Please add a new keyboard shortcut for full-screen: `Win`+`Shift`+`Enter` Why?! Because all universal apps became full-screen with `Win`+`Shift`+`Enter` Thanks.
claunia added the Issue-TaskProduct-TerminalArea-UserInterface labels 2026-01-31 00:44:27 +00:00
claunia commented 2026-01-31 00:44:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 2, 2020):

I suppose if other UWP apps use this keybinding, then we could too. The system already set a precedent that this key chord is used for that, so we could use it too, I don't feel bad about hijacking it in this case.

@zadjii-msft commented on GitHub (Mar 2, 2020): I suppose if other UWP apps use this keybinding, then we could too. The system already set a precedent that this key chord is used for that, so we could use it too, I don't feel bad about hijacking it in this case.
claunia commented 2026-01-31 00:44:28 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 6, 2020):

Yeah, I don't see why not.

@DHowett-MSFT commented on GitHub (Mar 6, 2020): Yeah, I don't see why not.
claunia commented 2026-01-31 00:44:28 +00:00
Author
Owner
Copy Link

@abhijeetviswam commented on GitHub (Mar 14, 2020):

I was trying to work this out, however I found that currently there is no support for windows key modifier. Also based on comments in #4329, there's no plan to implement it.

I'm wondering how we can bring in this feature if the modifier cannot be added. Does the terminal support any win key based shortcuts right now?

@abhijeetviswam commented on GitHub (Mar 14, 2020): I was trying to work this out, however I found that currently there is no support for windows key modifier. Also based on comments in #4329, there's no plan to implement it. I'm wondering how we can bring in this feature if the modifier cannot be added. Does the terminal support any win key based shortcuts right now?
claunia commented 2026-01-31 00:44:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 16, 2020):

Since Win+Shift+Enter is a system keybinding that's usually bound to fullscreen UWP applications, we can special-case that keybinding to fullscreen the Terminal, so it behaves like other apps on the system. It would not be a general-purpose "users can bind the Win key", it would be a one-off special case.

@zadjii-msft commented on GitHub (Mar 16, 2020): Since Win+Shift+Enter is a _system_ keybinding that's usually bound to fullscreen UWP applications, we can special-case that keybinding to fullscreen the Terminal, so it behaves like other apps on the system. It would not be a general-purpose "users can bind the <kbd>Win</kbd> key", it would be a one-off special case.
claunia commented 2026-01-31 00:44:29 +00:00
Author
Owner
Copy Link

@neville-nazerane commented on GitHub (May 20, 2020):

Powershell and command prompt have fullscreen on alt + shift + enter. How about staying consistent with them?

@neville-nazerane commented on GitHub (May 20, 2020): Powershell and command prompt have fullscreen on alt + shift + enter. How about staying consistent with them?
claunia commented 2026-01-31 00:44:29 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 20, 2020):

Uh, powershell and command prompt have fullscreen on alt+enter. Terminal does too. It works today.

@DHowett commented on GitHub (May 20, 2020): Uh, powershell and command prompt have fullscreen on _alt+enter_. Terminal does too. It works today.
claunia commented 2026-01-31 00:44:29 +00:00
Author
Owner
Copy Link

@neville-nazerane commented on GitHub (May 20, 2020):

By habit from visual studio I always only tried alt + shift + enter. Never realized just shift + enter worked. Makes sense now, Thanks!

So basically, in that case, there is kind of a bug where holding an additional key doesn't work in the terminal but does in command prompt and powershell.

@neville-nazerane commented on GitHub (May 20, 2020): By habit from visual studio I always only tried alt + shift + enter. Never realized just shift + enter worked. Makes sense now, Thanks! So basically, in that case, there is kind of a bug where holding an additional key doesn't work in the terminal but does in command prompt and powershell.
claunia commented 2026-01-31 00:44:29 +00:00
Author
Owner
Copy Link

@hessedoneen commented on GitHub (Apr 7, 2021):

Hello! Could I give this a shot?

@hessedoneen commented on GitHub (Apr 7, 2021): Hello! Could I give this a shot?
claunia commented 2026-01-31 00:44:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 7, 2021):

@hessedoneen Sure, go for it!

With this one, I probably would skip adding this as a whole proper keybinding. The TerminalApp layer, where most other keybindings are handled, doesn't know anything about the win key. We might need to handle this up in IslandWindow, and cause that to trigger entering fullscreen mode.

@zadjii-msft commented on GitHub (Apr 7, 2021): @hessedoneen Sure, go for it! With this one, I probably would skip adding this as a whole proper keybinding. The `TerminalApp` layer, where most other keybindings are handled, doesn't know anything about the <kbd>win</kbd> key. We might need to handle this up in `IslandWindow`, and cause that to trigger entering fullscreen mode.
claunia commented 2026-01-31 00:44:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 21, 2021):

Oh uh, this might be harder than I thought.

I thought it would be as easy as slapping

        { "command": "toggleFullscreen", "keys": "win+shift+enter" },

into defaults.json.

I'm not sure that we ever get the Win+Shift+Enter keystroke to our wndproc. That would certainly make this harder. We might need to follow-up internally to see where that keystroke is getting eaten by the OS, and see if we can let it still get passed to apps.

@zadjii-msft commented on GitHub (May 21, 2021): Oh uh, this might be harder than I thought. I thought it would be as easy as slapping ```json { "command": "toggleFullscreen", "keys": "win+shift+enter" }, ``` into `defaults.json`. I'm not sure that we ever get the <kbd>Win+Shift+Enter</kbd> keystroke to our wndproc. That would certainly make this harder. We might need to follow-up internally to see where that keystroke is getting eaten by the OS, and see if we can let it still get passed to apps.
claunia commented 2026-01-31 00:44:30 +00:00
Author
Owner
Copy Link

@DragNovus commented on GitHub (Feb 9, 2023):

Hello, I know this app will full-screen with Alt+Enter and F11 Please add a new keyboard shortcut for full-screen: Win+Shift+Enter Why?! Because all universal apps became full-screen with Win+Shift+Enter Thanks.

Win+Shift+Enter is already in use
https://defkey.com/what-means/win-shift-enter

@DragNovus commented on GitHub (Feb 9, 2023): > Hello, I know this app will full-screen with `Alt`+`Enter` and `F11` Please add a new keyboard shortcut for full-screen: `Win`+`Shift`+`Enter` Why?! Because all universal apps became full-screen with `Win`+`Shift`+`Enter` Thanks. `Win`+`Shift`+`Enter` is already in use https://defkey.com/what-means/win-shift-enter
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6673
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?