Terminal doesn&#39;t copy on Enter (like conhost does) #6783

@j4james commented on GitHub (Mar 8, 2020):

Using the Enter key to copy was brought up in issue #715.

@j4james commented on GitHub (Mar 8, 2020): Using the `Enter` key to copy was brought up in issue #715.

claunia commented

@zadjii-msft commented on GitHub (Mar 9, 2020):

Thanks for the suggestion! You're right that this is something that the Terminal doesn't do currently that conhost (the vintage console) does. You could actually probably get the Terminal to behave the same as conhost by adding the following to your keybindings:

{ "command": "copy", "keys": ["enter"] },

This will make enter work to copy the selection only when there's a selection.

There's a good chance that we're going to close this as a duplicate of #3058 - we might decide to ad this by default in the near future.

@zadjii-msft commented on GitHub (Mar 9, 2020): Thanks for the suggestion! You're right that this is something that the Terminal doesn't do currently that conhost (the vintage console) does. You could actually probably get the Terminal to behave the same as conhost by adding the following to your keybindings: ```json { "command": "copy", "keys": ["enter"] }, ``` This will make <kbd>enter</kbd> work to copy the selection _only when there's a selection_. There's a good chance that we're going to close this as a duplicate of #3058 - we might decide to ad this by default in the near future.

claunia commented

@ghost commented on GitHub (Mar 9, 2020):

Yes, you are right. But what about using 'right click' to paste the copied item? How will that be handled?

@ghost commented on GitHub (Mar 9, 2020): Yes, you are right. But what about using 'right click' to paste the copied item? How will that be handled?

claunia commented

@ghost commented on GitHub (Mar 9, 2020):

We might also need to implement the same context menu that we get on right-clicking the title bar of conhost.exe so that Windows Terminal behaves in a similar manner. That menu includes options like 'Mark', 'Copy', 'Paste' etc. The ability to mark text and copy it by pressing 'Enter' is what I wanted to say.

@ghost commented on GitHub (Mar 9, 2020): We might also need to implement the same context menu that we get on right-clicking the title bar of conhost.exe so that Windows Terminal behaves in a similar manner. That menu includes options like 'Mark', 'Copy', 'Paste' etc. The ability to mark text and copy it by pressing 'Enter' is what I wanted to say.

claunia commented

@zadjii-msft commented on GitHub (Mar 9, 2020):

Right click to paste already works in the Terminal 😉

And "Mark Mode" is something that's already tracked in #715/#2840/#3758

@zadjii-msft commented on GitHub (Mar 9, 2020): Right click to paste already works in the Terminal 😉 And "Mark Mode" is something that's already tracked in #715/#2840/#3758

claunia commented

@ghost commented on GitHub (Mar 9, 2020):

@zadjii-msft Thank you for making me aware. But my second last comment remains unanswered. Both of these features have to be implemented at the same time.

@ghost commented on GitHub (Mar 9, 2020): @zadjii-msft Thank you for making me aware. But my second last comment remains unanswered. Both of these features have to be implemented at the same time.

claunia commented

@zadjii-msft commented on GitHub (Mar 9, 2020):

I'm certain there's a dupe for implementing this menu in the Terminal somewhere on this repo, but I'm having a really hard time finding it:

@zadjii-msft commented on GitHub (Mar 9, 2020): I'm _certain_ there's a dupe for implementing this menu in the Terminal _somewhere_ on this repo, but I'm having a really hard time finding it: ![image](https://user-images.githubusercontent.com/18356694/76252730-518a2800-6217-11ea-9d81-5ffd0d469dd5.png)

claunia commented

@ghost commented on GitHub (Mar 10, 2020):

This may help you in that case. But I think you misunderstood my message. I was referring to the following comment:

Yes, you are right. But what about using 'right click' to paste the copied item? How will that be handled?

@ghost commented on GitHub (Mar 10, 2020): [This](https://github.com/microsoft/terminal/search?q=Mark+Copy+Paste&unscoped_q=Mark+Copy+Paste) may help you in that case. But I think you misunderstood my message. I was referring to the following comment: ```` Yes, you are right. But what about using 'right click' to paste the copied item? How will that be handled? ````

claunia commented

@zadjii-msft commented on GitHub (Mar 10, 2020):

Yes, you are right. But what about using 'right click' to paste the copied item? How will that be handled?

I'm pretty sure I already answered that with

Right click to paste already works in the Terminal 😉

It's handled right here:
bf48ce5b51/src/cascadia/TerminalControl/TermControl.cpp (L897-L908)

Does right-click to paste not work for you currently?

@zadjii-msft commented on GitHub (Mar 10, 2020): > Yes, you are right. But what about using 'right click' to paste the copied item? How will that be handled? I'm pretty sure I already answered that with > Right click to paste already works in the Terminal 😉 It's handled right here: https://github.com/microsoft/terminal/blob/bf48ce5b51edd1822badc3310d3ac605b5ca9129/src/cascadia/TerminalControl/TermControl.cpp#L897-L908 Does right-click to paste _not_ work for you currently?

claunia commented

@ghost commented on GitHub (Mar 10, 2020):

It is working for me. But it didn't work in the above case. So I just wanted to enquire if any change in the implementation of the feature is required. But since you have assured me that this key-binding (pertaining to the enter key) will be present by default in the future, I have no further queries.

@ghost commented on GitHub (Mar 10, 2020): It is working for me. But it didn't work in the above case. So I just wanted to enquire if any change in the implementation of the feature is required. But since you have assured me that this key-binding (pertaining to the enter key) will be present by default in the future, I have no further queries.

claunia commented

@ghost commented on GitHub (Mar 10, 2020):

Going a bit off track: Did you get that piece of code you were looking for?

If you feel everthing is done, you may close this issue now.

@ghost commented on GitHub (Mar 10, 2020): Going a bit off track: Did you get that piece of code you were looking for? If you feel everthing is done, you may close this issue now.

claunia commented

@DHowett-MSFT commented on GitHub (Mar 24, 2020):

It looks like the questions here have been answered. Right now, you can bind enter to copy, but we're not looking at doing it by default. We are collecting information on how popular certain keybindings are so as to inform our decisions in this space.

Thanks!

@DHowett-MSFT commented on GitHub (Mar 24, 2020): It looks like the questions here have been answered. Right now, you can bind `enter` to `copy`, but we're not looking at doing it by default. We _are_ collecting information on how popular certain keybindings are so as to inform our decisions in this space. Thanks!

claunia commented