starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Light theme is not supported well? #6829

New Issue
Closed
opened 2026-01-31 00:48:14 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 00:48:14 +00:00
Owner
Copy Link

Originally created by @learning on GitHub (Mar 11, 2020).

Environment

Windows build number: 10.0.18363.657
Windows Terminal version (if applicable): 0.9.433.0

Any other software?
1. Debian Linux (WSL)
2. fish shell

Steps to reproduce

Use ColorTool convert this Github style iTerm2 color theme, and add it to Windows Terminal

My color scheme in Windows Terminal:

{
    "name": "github",
    "black":"#3e3e3e",
    "blue":"#003e8a",
    "green":"#07962a",
    "cyan":"#89d1ec",
    "red":"#970b16",
    "purple":"#e94691",
    "yellow":"#f8eec7",
    "white":"#ffffff",
    "brightBlack":"#666666",
    "brightBlue":"#2e6cba",
    "brightGreen":"#87d5a2",
    "brightCyan":"#1cfafe",
    "brightRed":"#de0000",
    "brightPurple":"#ffa29f",
    "brightYellow":"#f1d007",
    "brightWhite":"#ffffff",
    "foreground":"#3e3e3e",
    "background":"#ffffff",
    "selectionBackground": "#ffa29f"
}

Expected behavior

Just like iTerm2 in macOS

macos

Actual behavior

Some text is in white, the same color with background
windows

Originally created by @learning on GitHub (Mar 11, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.18363.657 Windows Terminal version (if applicable): 0.9.433.0 Any other software? 1. Debian Linux (WSL) 2. fish shell ``` # Steps to reproduce Use ColorTool convert this [Github style iTerm2 color theme](https://github.com/mbadolato/iTerm2-Color-Schemes/blob/master/schemes/Github.itermcolors), and add it to Windows Terminal My color scheme in Windows Terminal: ``` { "name": "github", "black":"#3e3e3e", "blue":"#003e8a", "green":"#07962a", "cyan":"#89d1ec", "red":"#970b16", "purple":"#e94691", "yellow":"#f8eec7", "white":"#ffffff", "brightBlack":"#666666", "brightBlue":"#2e6cba", "brightGreen":"#87d5a2", "brightCyan":"#1cfafe", "brightRed":"#de0000", "brightPurple":"#ffa29f", "brightYellow":"#f1d007", "brightWhite":"#ffffff", "foreground":"#3e3e3e", "background":"#ffffff", "selectionBackground": "#ffa29f" } ``` # Expected behavior Just like iTerm2 in macOS <img width="962" alt="macos" src="https://user-images.githubusercontent.com/354626/76388975-4fee6a80-63a5-11ea-87fb-18f8a7be6250.png"> # Actual behavior Some text is in white, the same color with background ![windows](https://user-images.githubusercontent.com/354626/76389030-5c72c300-63a5-11ea-902a-084e25740ae9.png)
claunia added the Resolution-DuplicateProduct-Terminal labels 2026-01-31 00:48:14 +00:00
claunia commented 2026-01-31 00:48:15 +00:00
Author
Owner
Copy Link

@learning commented on GitHub (Mar 11, 2020):

Not only the Node.js+webpack, it goes crazy when I use fish shell.

wt

@learning commented on GitHub (Mar 11, 2020): Not only the Node.js+webpack, it goes crazy when I use fish shell. ![wt](https://user-images.githubusercontent.com/354626/76389990-85945300-63a7-11ea-8b27-376837a0f2f5.gif)
claunia commented 2026-01-31 00:48:15 +00:00
Author
Owner
Copy Link

@hanubeki commented on GitHub (Mar 11, 2020):

Could be #293 and/or #2661

@hanubeki commented on GitHub (Mar 11, 2020): Could be #293 and/or #2661
claunia commented 2026-01-31 00:48:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 11, 2020):

I'm just reposting the theme here so you can preview the colors here

Color sheme

"name": "github",
"black": #3e3e3e,
"blue": #003e8a,
"green": #07962a,
"cyan": #89d1ec,
"red": #970b16,
"purple": #e94691,
"yellow": #f8eec7,
"white": #ffffff,
"brightBlack": #666666,
"brightBlue": #2e6cba,
"brightGreen": #87d5a2,
"brightCyan": #1cfafe,
"brightRed": #de0000,
"brightPurple": #ffa29f,
"brightYellow": #f1d007,
"brightWhite": #ffffff,
"foreground": #3e3e3e,
"background": #ffffff,
"selectionBackground": #ffa29`

I'd bet that this was #293, but I'm not seeing this orange color
image

anywhere in that scheme. Maybe you could edit the foreground, white, or brightWhite colors, to see if text is getting printed in any of those colors at all?

@zadjii-msft commented on GitHub (Mar 11, 2020): I'm just reposting the theme here so you can preview the colors here <details> <summary>Color sheme</summary> "name": ` "github",` "black": `#3e3e3e`, "blue": `#003e8a`, "green": `#07962a`, "cyan": `#89d1ec`, "red": `#970b16`, "purple": `#e94691`, "yellow": `#f8eec7`, "white": `#ffffff`, "brightBlack": `#666666`, "brightBlue": `#2e6cba`, "brightGreen": `#87d5a2`, "brightCyan": `#1cfafe`, "brightRed": `#de0000`, "brightPurple": `#ffa29f`, "brightYellow": `#f1d007`, "brightWhite": `#ffffff`, "foreground": `#3e3e3e`, "background": `#ffffff`, "selectionBackground": ` `#ffa29` </details> I'd bet that this was #293, but I'm not seeing this orange color ![image](https://user-images.githubusercontent.com/18356694/76419657-b7d58e80-636e-11ea-8b14-33e5fef9feaf.png) anywhere in that scheme. Maybe you could edit the foreground, white, or brightWhite colors, to see if text is getting printed in any of those colors at all?
claunia commented 2026-01-31 00:48:16 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 11, 2020):

But given that you do have working black text, I believe this is because the application is explicitly requesting "white". It's also correct that you have not specified that orange color in this color scheme. Perhaps that's what you should put in place of White?

@DHowett-MSFT commented on GitHub (Mar 11, 2020): But given that you do have working black text, I believe this is because the application is _explicitly requesting_ "white". It's also correct that you have not specified that orange color in this color scheme. Perhaps that's what you should put in place of White?
claunia commented 2026-01-31 00:48:16 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 11, 2020):

Oh, @zadjii-msft, this is actually because we don't have "bold foreground" (color 19)... eeeeee

@DHowett-MSFT commented on GitHub (Mar 11, 2020): Oh, @zadjii-msft, this is actually because we don't have "bold foreground" (color 19)... eeeeee
claunia commented 2026-01-31 00:48:16 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 24, 2020):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Mar 24, 2020): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 00:48:17 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Mar 24, 2020):

Oh, @zadjii-msft, this is actually because we don't have "bold foreground" (color 19)... eeeeee

Note that there is quite a lot of variation in the way different terminal emulators deal with the concept of a bold foreground color. Xterm has some OSC sequences for controlling attribute colors (see OSC 5/6, etc) that are partially supported by some other terminals, but I think iTerm2 actually uses something completely different.

There are also standard DEC sequences for controlling attribute colors (e.g. DECATC), although they serve a somewhat different purpose. However, if we are going to support something like this, I think it would be nice if we could at least consider how it might fit in with the standard behavior.

@j4james commented on GitHub (Mar 24, 2020): > Oh, @zadjii-msft, this is actually because we don't have "bold foreground" (color 19)... eeeeee Note that there is quite a lot of variation in the way different terminal emulators deal with the concept of a bold foreground color. Xterm has some OSC sequences for controlling attribute colors (see OSC 5/6, etc) that are partially supported by some other terminals, but I think iTerm2 actually uses something completely different. There are also standard DEC sequences for controlling attribute colors (e.g. `DECATC`), although they serve a somewhat different purpose. However, if we are going to support something like this, I think it would be nice if we could at least consider how it might fit in with the standard behavior.
claunia commented 2026-01-31 00:48:17 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 28, 2020):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Mar 28, 2020): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 00:48:17 +00:00
Author
Owner
Copy Link

@learning commented on GitHub (Mar 31, 2020):

I'm just reposting the theme here so you can preview the colors here
Color sheme

I'd bet that this was #293, but I'm not seeing this orange color
image

anywhere in that scheme. Maybe you could edit the foreground, white, or brightWhite colors, to see if text is getting printed in any of those colors at all?

Yes, I have tried to adjust foreground color for the fish and webpack, but it turns unreadable elsewhere, like ls, vim or git, the daily tools.

@learning commented on GitHub (Mar 31, 2020): > > > I'm just reposting the theme here so you can preview the colors here > Color sheme > > I'd bet that this was #293, but I'm not seeing this orange color > ![image](https://user-images.githubusercontent.com/18356694/76419657-b7d58e80-636e-11ea-8b14-33e5fef9feaf.png) > > anywhere in that scheme. Maybe you could edit the foreground, white, or brightWhite colors, to see if text is getting printed in any of those colors at all? Yes, I have tried to adjust foreground color for the **fish** and **webpack**, but it turns unreadable elsewhere, like **ls**, **vim** or **git**, the daily tools.
claunia commented 2026-01-31 00:48:18 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 1, 2020):

Thanks everyone for your input here. Now that we know the root cause, I'm going to refer to the new issue filed to track it. /dup #5682.

@DHowett-MSFT commented on GitHub (May 1, 2020): Thanks everyone for your input here. Now that we know the root cause, I'm going to refer to the new issue filed to track it. /dup #5682.
claunia commented 2026-01-31 00:48:18 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 1, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (May 1, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6829
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?