starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash in Windows Terminal TerminalControl!TextBuffer::Reflow #6860

New Issue
Closed
opened 2026-01-31 00:49:08 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 00:49:08 +00:00
Owner
Copy Link

Originally created by @Treit on GitHub (Mar 13, 2020).

Originally assigned to: @DHowett on GitHub.

While running a stress test on Windows Terminal version 0.10.721.0, I was able to cause a crash in TerminalControl!TextBuffer::Reflow.

I was running https://github.com/Treit/TerminalStress, the application I wrote some time back to reproduce a different bug (that was since fixed.)

I was running something like 5 instances in parallel in different panes on the same tab, then rapidly pressing Alt+Enter to switch from full screen to normal and back.

WindowsTerminal11.txt

I have attached some additional output from the debugger that might be helpful.

Originally created by @Treit on GitHub (Mar 13, 2020). Originally assigned to: @DHowett on GitHub. While running a stress test on Windows Terminal version 0.10.721.0, I was able to cause a crash in TerminalControl!TextBuffer::Reflow. I was running https://github.com/Treit/TerminalStress, the application I wrote some time back to reproduce a different bug (that was since fixed.) I was running something like 5 instances in parallel in different panes on the same tab, then rapidly pressing Alt+Enter to switch from full screen to normal and back. [WindowsTerminal11.txt](https://github.com/microsoft/terminal/files/4331632/WindowsTerminal11.txt) I have attached some additional output from the debugger that might be helpful.
claunia commented 2026-01-31 00:49:09 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 18, 2020):

Finger-in-the-air guess is P3: if this only reproduces when you're murdering your terminal by resizing it multiple times a second while printing megabytes of output, I'm going to say it won't strike too many people too often.

It's still worth fixing.

@DHowett-MSFT commented on GitHub (Mar 18, 2020): Finger-in-the-air guess is P3: if this only reproduces when you're murdering your terminal by resizing it multiple times a second while printing megabytes of output, I'm going to say it won't strike too many people too often. It's still worth fixing.
claunia commented 2026-01-31 00:49:09 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 4, 2020):

I can't repro this on v0.11.1212, even resizing like mad with five open panes printing our 6MB test file simultaneously.

I'm gonna call this one no-repro. @Treit please let me know if you can still repro!

@DHowett-MSFT commented on GitHub (May 4, 2020): I can't repro this on v0.11.1212, even resizing like mad with five open panes printing our 6MB test file simultaneously. I'm gonna call this one no-repro. @Treit please let me know if you can still repro!
claunia commented 2026-01-31 00:49:09 +00:00
Author
Owner
Copy Link

@Treit commented on GitHub (May 4, 2020):

I can't repro this on v0.11.1212, even resizing like mad with five open panes printing our 6MB test file simultaneously.

I'm gonna call this one no-repro. @Treit please let me know if you can still repro!

@DHowett-MSFT Yes I can still reproduce it on 0.11.1212.0

@Treit commented on GitHub (May 4, 2020): > I can't repro this on v0.11.1212, even resizing like mad with five open panes printing our 6MB test file simultaneously. > > I'm gonna call this one no-repro. @Treit please let me know if you can still repro! @DHowett-MSFT Yes I can still reproduce it on 0.11.1212.0
claunia commented 2026-01-31 00:49:09 +00:00
Author
Owner
Copy Link

@Treit commented on GitHub (May 5, 2020):

@DHowett-MSFT here is a brief video I just made demonstrating how I reproduced the issue on 0.11.1212.0:
https://1drv.ms/v/s!Alav93a0o3vchOwF91dG-jJ5He1g0w?e=2Lm59k

@Treit commented on GitHub (May 5, 2020): @DHowett-MSFT here is a brief video I just made demonstrating how I reproduced the issue on 0.11.1212.0: https://1drv.ms/v/s!Alav93a0o3vchOwF91dG-jJ5He1g0w?e=2Lm59k
claunia commented 2026-01-31 00:49:10 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 5, 2020):

Perfect. Thank you.

@DHowett-MSFT commented on GitHub (May 5, 2020): Perfect. Thank you.
claunia commented 2026-01-31 00:49:10 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 5, 2020):

The problem is, as always, double-width characters. Somehow, the source buffer (during the reflow operation) is getting a hanging DBCS Trailing character that we dutifully try to reflect into the new buffer.

@DHowett-MSFT commented on GitHub (May 5, 2020): The problem is, as always, double-width characters. Somehow, the source buffer (during the reflow operation) is getting a hanging DBCS Trailing character that we dutifully try to reflect into the new buffer.
claunia commented 2026-01-31 00:49:10 +00:00
Author
Owner
Copy Link

@kasper93 commented on GitHub (May 16, 2020):

Would you share some of the glyphs that are in your powerlevel10k theme?

In fact it is powerleve9k, default setup nothing fancy.

I'll mark this as a /dup of #4907 in the meantime -- same call stack, same symptoms, same repro (go wild on resizing with garb in the buffer)

@DHowett-MSFT Since the other issue has been closed I replying here.

For me the problems started with 7ae34336da probably because ✔ has been made wide.

To summarize my problems:

  1. tmux drawing is broken. I needed to select pane to redraw vertical separator. Tick mark draw over separator. Also when resizing it glitches visually. https://streamable.com/xwrs5z
  2. WT crashes https://streamable.com/xwrs5z It is very easy to reproduce in tmux, I did reproduce it also without, but it is harder. (watch after 27s, before I tried not to crash it, also I cut video before window closed, but it crashed in the end, you can see it is not responding anymore)
  3. Changing this tick mark to wide (or smth else) made it mess up really bad when resizing. After 7ae34336da: https://streamable.com/2wanng and before 7ae34336da: https://streamable.com/rd2a8v

I initially though that crashes and other issues are related, but while they are introduced by the same commit for me, it looks like they are separate problems. We might reopen my issue for drawing problems and discuss crash in this one.

@kasper93 commented on GitHub (May 16, 2020): > Would you share some of the glyphs that are in your powerlevel10k theme? In fact it is powerleve9k, default setup nothing fancy. > I'll mark this as a /dup of #4907 in the meantime -- same call stack, same symptoms, same repro (go wild on resizing with garb in the buffer) @DHowett-MSFT Since the other issue has been closed I replying here. For me the problems started with https://github.com/microsoft/terminal/commit/7ae34336da0be8428738df5e13dfc4c5f1df6f75 probably because ✔ has been made wide. To summarize my problems: 1. tmux drawing is broken. I needed to select pane to redraw vertical separator. Tick mark draw over separator. Also when resizing it glitches visually. https://streamable.com/xwrs5z 2. WT crashes https://streamable.com/xwrs5z It is very easy to reproduce in tmux, I did reproduce it also without, but it is harder. (watch after 27s, before I tried not to crash it, also I cut video before window closed, but it crashed in the end, you can see it is not responding anymore) 3. Changing this tick mark to wide (or smth else) made it mess up really bad when resizing. After 7ae34336da0be8428738df5e13dfc4c5f1df6f75: https://streamable.com/2wanng and before 7ae34336da0be8428738df5e13dfc4c5f1df6f75: https://streamable.com/rd2a8v I initially though that crashes and other issues are related, but while they are introduced by the same commit for me, it looks like they are separate problems. We might reopen my issue for drawing problems and discuss crash in this one.
claunia commented 2026-01-31 00:49:10 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 21, 2020):

So @kasper93, we fixed the width of ✔ at least! This bug'll remain to track the resizing issue 😄

@DHowett commented on GitHub (May 21, 2020): So @kasper93, we fixed the width of ✔ at least! This bug'll remain to track the resizing issue :smile:
claunia commented 2026-01-31 00:49:11 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 7, 2021):

Fixing as part of MSFT-17364373, which is a conhost crash that hits moderately often (~500 hits in the past 14 days!)

@DHowett commented on GitHub (Apr 7, 2021): Fixing as part of MSFT-17364373, which is a conhost crash that hits moderately often (~500 hits in the past 14 days!)
claunia commented 2026-01-31 00:49:11 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

🎉Windows Terminal v1.7.1033.0 has been released which incorporates this pull request.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:`Windows Terminal v1.7.1033.0` has been released which incorporates this pull request.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.1033.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 00:49:11 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2021):

🎉Windows Terminal Preview v1.8.1032.0 has been released which incorporates this pull request.🎉

Handy links:

@ghost commented on GitHub (Apr 14, 2021): :tada:`Windows Terminal Preview v1.8.1032.0` has been released which incorporates this pull request.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1032.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6860
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?