Exiting a console doesn't close the tab or window #687

Closed
opened 2026-01-30 21:59:33 +00:00 by claunia · 7 comments
Owner

Originally created by @ObsidianMinor on GitHub (May 7, 2019).

  • Windows build number: 10.0.18362.30

  • What's happening: Exiting a console via an exit command doesn't close the tab or window. Instead the tab or window just hangs until you manually close it.
    image

  • What should be happening: The tab or window should close upon exit

Originally created by @ObsidianMinor on GitHub (May 7, 2019). * Windows build number: 10.0.18362.30 * What's happening: Exiting a console via an `exit` command doesn't close the tab or window. Instead the tab or window just hangs until you manually close it. ![image](https://user-images.githubusercontent.com/10121870/57272089-c02ab200-7057-11e9-99dd-14eaddb2d4fa.png) * What should be happening: The tab or window should close upon exit
claunia added the Issue-FeatureHelp Wanted labels 2026-01-30 21:59:34 +00:00
Author
Owner

@JBanks commented on GitHub (May 7, 2019):

For tabs, make sure that you have "closeOnExit": true, as a setting in the particular profile.
This only works if you have more than one tab open.

@JBanks commented on GitHub (May 7, 2019): For tabs, make sure that you have `"closeOnExit": true,` as a setting in the particular profile. This only works if you have more than one tab open.
Author
Owner

@Flipp3rrr commented on GitHub (May 8, 2019):

In my opinion "closeOnExit": true should be turned on by default. This behaviour is a little bit weird.

@Flipp3rrr commented on GitHub (May 8, 2019): In my opinion `"closeOnExit": true` should be turned on by default. This behaviour is a little bit weird.
Author
Owner

@bef178 commented on GitHub (May 8, 2019):

And ctrl-w closes the tab currently

@bef178 commented on GitHub (May 8, 2019): And ctrl-w closes the tab currently
Author
Owner

@isaacrlevin commented on GitHub (May 8, 2019):

To compound on this, I would expect if I exit with only one tab, Terminal should close as well.

@isaacrlevin commented on GitHub (May 8, 2019): To compound on this, I would expect if I exit with only one tab, Terminal should close as well.
Author
Owner

@zadjii-msft commented on GitHub (May 8, 2019):

Yea, closeOnExit should probably default to true. This would be a fairly good starter issue if someone wanted to make a PR :)

Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).

@zadjii-msft commented on GitHub (May 8, 2019): Yea, closeOnExit should probably default to true. *This would be a fairly good starter issue if someone wanted to make a PR :)* Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).
Author
Owner

@JBanks commented on GitHub (May 9, 2019):

Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow).

@zadjii-msft, should we open a separate issue for this, or re-open this one until the second piece is resolved?

@JBanks commented on GitHub (May 9, 2019): > Closing the terminal when the last tab is closed is also something we should be doing, but that might be a bit trickier of a PR. I think we're manually suppressing the close action on the last tab currently, but that could be replaced with just closing the app (somehow). @zadjii-msft, should we open a separate issue for this, or re-open this one until the second piece is resolved?
Author
Owner

@zadjii-msft commented on GitHub (May 9, 2019):

A second issue is probably best. Filed #627 to track it :)

@zadjii-msft commented on GitHub (May 9, 2019): A second issue is probably best. Filed #627 to track it :)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#687