[v0.10] When two characters are ligatured, the first one becomes invisible #6941

@onekopaka commented on GitHub (Mar 18, 2020):

I am also having this issue, using 10pt Fira Code, no matter the zoom level, I just built from commit c0d704e734

Here you can see the //, :: and www ligatures drawing incorrectly:

@onekopaka commented on GitHub (Mar 18, 2020): I am also having this issue, using 10pt Fira Code, no matter the zoom level, I just built from commit c0d704e734c54381af59dc0413b7aa19326a84ed Here you can see the //, :: and www ligatures drawing incorrectly: ![Screenshot of my terminal, showing the www, :: and // ligatures drawing incorrectly](https://ss.theoks.net/WindowsTerminal_2020-03-18_02-47-59.png)

claunia commented

@DHowett-MSFT commented on GitHub (Mar 18, 2020):

We thought we'd fixed this with #4806, but perhaps we didn't.

@DHowett-MSFT commented on GitHub (Mar 18, 2020): We thought we'd fixed this with #4806, but perhaps we didn't.

claunia commented

@allenatdecisiv commented on GitHub (Mar 20, 2020):

Same here:

"fontFace" : "Fira Code Retina",
"fontSize" : 12,
Windows Terminal (Preview)
Version: 0.10.761.0
Microsoft Windows [Version 10.0.18363.720]

@allenatdecisiv commented on GitHub (Mar 20, 2020): Same here: ![terminal-preview](https://user-images.githubusercontent.com/1952547/77141979-15479a80-6a55-11ea-9c92-fe8df08ac9bf.gif) ` "fontFace" : "Fira Code Retina",` ` "fontSize" : 12,` `Windows Terminal (Preview)` `Version: 0.10.761.0` `Microsoft Windows [Version 10.0.18363.720]`

claunia commented

@daviox commented on GitHub (Mar 20, 2020):

Same here:

Versions

Windows Terminal (Preview)
Version: 0.10.761.0

Microsoft Windows [Version 10.0.18363.719]

Config

      "fontFace": "Fira Code",
      "fontSize": 9,
      "scrollbarState": "hidden",
      "padding": "5",

@daviox commented on GitHub (Mar 20, 2020): Same here: ![Ligatures issue](https://user-images.githubusercontent.com/25099832/77161606-646bea80-6aaa-11ea-9856-5bd6999d14a6.png) ### Versions > Windows Terminal (Preview) > Version: 0.10.761.0 > Microsoft Windows [Version 10.0.18363.719] ### Config ```jsonc "fontFace": "Fira Code", "fontSize": 9, "scrollbarState": "hidden", "padding": "5", ```

claunia commented

@fabienheureux commented on GitHub (Mar 24, 2020):

do you have an ETA for this issue @DHowett-MSFT ?
Thanks 👍

@fabienheureux commented on GitHub (Mar 24, 2020): do you have an ETA for this issue @DHowett-MSFT ? Thanks 👍

claunia commented

@DHowett-MSFT commented on GitHub (Mar 26, 2020):

Unfortunately, I do not. Sorry.

@DHowett-MSFT commented on GitHub (Mar 26, 2020): Unfortunately, I do not. Sorry.

claunia commented

@fabienheureux commented on GitHub (Mar 26, 2020):

By the way, I tried switching my font to Cascadia instead of Fira Code and this issue does not occur with Cascadia.

@fabienheureux commented on GitHub (Mar 26, 2020): By the way, I tried switching my font to Cascadia instead of Fira Code and this issue does not occur with Cascadia.

claunia commented

@skyline75489 commented on GitHub (Mar 27, 2020):

I'm using WT Version 0.10.781.0 and I can not seem to reproduce it. I'm also a Fira Code lover myself.

@skyline75489 commented on GitHub (Mar 27, 2020): I'm using WT Version 0.10.781.0 and I can not seem to reproduce it. I'm also a Fira Code lover myself.

claunia commented

@FallenGameR commented on GitHub (Mar 27, 2020):

I'm on WT 0.10.781.0 and do reproduce this bug with Fira Code.

@FallenGameR commented on GitHub (Mar 27, 2020): I'm on WT 0.10.781.0 and do reproduce this bug with Fira Code.

claunia commented

@zadjii-msft commented on GitHub (Mar 27, 2020):

I'd bet this might have to do with not only the font face, but also the font size and display resolution. @FallenGameR (or anyone else reproing this), could you also make sure to share your fontSize and display resolution? Thanks!

@zadjii-msft commented on GitHub (Mar 27, 2020): I'd bet this might have to do with not only the font face, but also the font size and display resolution. @FallenGameR (or anyone else reproing this), could you also make sure to share your `fontSize` and display resolution? Thanks!

claunia commented

@fabienheureux commented on GitHub (Mar 27, 2020):

@zadjii-msft here are the settings that causes this issue:

"fontFace" : "Fira Code",
"fontSize" : 10,

Resolution: 1920 x 1080
By the way, I tested with various fontSize values, and the issue is always the same

@fabienheureux commented on GitHub (Mar 27, 2020): @zadjii-msft here are the settings that causes this issue: ``` "fontFace" : "Fira Code", "fontSize" : 10, ``` Resolution: 1920 x 1080 By the way, I tested with various fontSize values, and the issue is always the same

claunia commented

@anttirt commented on GitHub (Mar 27, 2020):

Reproduced with Windows Terminal 0.10.781.0, Fira Code 1.206, display resolution 1920x1200, every font size from 6 to 14.

Updating to Fira Code 2.000 fixed the issue and all ligatures show up correctly at all settings I'm able to test.

@anttirt commented on GitHub (Mar 27, 2020): Reproduced with Windows Terminal 0.10.781.0, Fira Code 1.206, display resolution 1920x1200, every font size from 6 to 14. Updating to Fira Code 2.000 fixed the issue and all ligatures show up correctly at all settings I'm able to test.

claunia commented

@skyline75489 commented on GitHub (Mar 27, 2020):

Ah. That's probably it. I'm at 2560 x 1600. I can't find a way to reproduce it.

@skyline75489 commented on GitHub (Mar 27, 2020): Ah. That's probably it. I'm at 2560 x 1600. I can't find a way to reproduce it.

claunia commented

@fabienheureux commented on GitHub (Mar 27, 2020):

Reproduced with Windows Terminal 0.10.781.0, Fira Code 1.206, display resolution 1920x1200, every font size from 6 to 14.

Updating to Fira Code 2.000 fixed the issue and all ligatures show up correctly at all settings I'm able to test.

The update to Fira Code 2.000 fixed the issue as well on my side

@fabienheureux commented on GitHub (Mar 27, 2020): > > > Reproduced with Windows Terminal 0.10.781.0, Fira Code 1.206, display resolution 1920x1200, every font size from 6 to 14. > > Updating to Fira Code 2.000 fixed the issue and all ligatures show up correctly at all settings I'm able to test. The update to Fira Code 2.000 fixed the issue as well on my side

claunia commented

@griimick commented on GitHub (Mar 27, 2020):

Same. Updating to Fira Code v.2 fixed the issues on my side.

@griimick commented on GitHub (Mar 27, 2020): Same. Updating to Fira Code v.2 fixed the issues on my side.

claunia commented

@neillrobson commented on GitHub (Mar 27, 2020):

Updating to v2 fixed the issue for me as well. Just FYI: make sure that when you are updating (or checking your font version numbers), you are looking at all of the font faces in the settings page. I am embarrassed to say that, somehow, I had installed v2.0 of Light and Bold, while keeping version 1.2 around for Regular, Medium, and Retina. No idea how that happened. Just to be safe, I uninstalled the Chocolatey package that I had been using to automatically update the font face.

@neillrobson commented on GitHub (Mar 27, 2020): Updating to v2 fixed the issue for me as well. Just FYI: make sure that when you are updating (or checking your font version numbers), you are looking at _all_ of the font faces in the settings page. I am embarrassed to say that, somehow, I had installed v2.0 of Light and Bold, while keeping version 1.2 around for Regular, Medium, and Retina. No idea how that happened. Just to be safe, I uninstalled the Chocolatey package that I had been using to automatically update the font face.

claunia commented

@allenatdecisiv commented on GitHub (Mar 27, 2020):

Updating to Fira Code 2 fixed the issue for me as well. I did have to manually remove all Fira Code fonts, then install the new ones. Overwriting didn't fix it.

        {
            "acrylicOpacity" : 0.85,
            "closeOnExit" : true,
            "colorScheme" : "Campbell",
            "commandline" : "cmd.exe",
            "cursorColor" : "#FFFFFF",
            "cursorShape" : "filledBox",
            "fontFace" : "Fira Code Retina",
            "fontSize" : 12,
            "guid" : "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
            "historySize" : 9001,
            "icon" : "ms-appx:///ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.png",
            "name" : "Command Prompt",
            "padding" : "0, 0, 0, 0",
            "snapOnInput" : true,
            "startingDirectory" : "%USERPROFILE%",
            "useAcrylic" : true
        },

@allenatdecisiv commented on GitHub (Mar 27, 2020): Updating to Fira Code 2 fixed the issue for me as well. I did have to manually remove all Fira Code fonts, then install the new ones. Overwriting didn't fix it. ![fira-code-2-works](https://user-images.githubusercontent.com/1952547/77785794-0e132480-7033-11ea-88e8-2934a423e9be.gif) ``` { "acrylicOpacity" : 0.85, "closeOnExit" : true, "colorScheme" : "Campbell", "commandline" : "cmd.exe", "cursorColor" : "#FFFFFF", "cursorShape" : "filledBox", "fontFace" : "Fira Code Retina", "fontSize" : 12, "guid" : "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "historySize" : 9001, "icon" : "ms-appx:///ProfileIcons/{0caa0dad-35be-5f56-a8ff-afceeeaa6101}.png", "name" : "Command Prompt", "padding" : "0, 0, 0, 0", "snapOnInput" : true, "startingDirectory" : "%USERPROFILE%", "useAcrylic" : true }, ```

claunia commented

@FallenGameR commented on GitHub (Mar 27, 2020):

Yep. Updating Fira Code to v2 fixed it. On one machine fonts were able to update the old version of themselves. On another machine v2 said that it was successfully installed, but v1.2 still remained and was picked up by default. Had to reboot and manually delete v1.2.

I'd bet this might have to do with not only the font face, but also the font size and display resolution. @FallenGameR (or anyone else reproing this), could you also make sure to share your fontSize and display resolution? Thanks!

2560x1600 - machine A
3240x2160 - machine B, 200% font scale
"fontSize": 14 - on both machines

@FallenGameR commented on GitHub (Mar 27, 2020): Yep. Updating Fira Code to v2 fixed it. On one machine fonts were able to update the old version of themselves. On another machine v2 said that it was successfully installed, but v1.2 still remained and was picked up by default. Had to reboot and manually delete v1.2. > I'd bet this might have to do with not only the font face, but also the font size and display resolution. @FallenGameR (or anyone else reproing this), could you also make sure to share your fontSize and display resolution? Thanks! 2560x1600 - machine A 3240x2160 - machine B, 200% font scale "fontSize": 14 - on both machines

claunia commented

@daviox commented on GitHub (Mar 28, 2020):

Updating FiraCode to v2 solved the issue. Thanks!

@daviox commented on GitHub (Mar 28, 2020): Updating FiraCode to v2 solved the issue. Thanks! ![No issues here](https://user-images.githubusercontent.com/25099832/77826943-1478cd80-7113-11ea-8311-3a95a8ca765f.gif)

claunia commented

@privacyguy123 commented on GitHub (Mar 30, 2020):

Updating the font fixed this yeah - doesn't seem to be a Terminal bug then?

@privacyguy123 commented on GitHub (Mar 30, 2020): Updating the font fixed this yeah - doesn't seem to be a Terminal bug then?

claunia commented

@DHowett-MSFT commented on GitHub (Mar 30, 2020):

It's still a Terminal bug, unfortunately. Thanks 😄

@DHowett-MSFT commented on GitHub (Mar 30, 2020): It's still a Terminal bug, unfortunately. Thanks :smile:

claunia commented

@fabienheureux commented on GitHub (Mar 31, 2020):

It's still a Terminal bug, unfortunately. Thanks 😄

If It can be of any help...this worked before #4806

@fabienheureux commented on GitHub (Mar 31, 2020): > It's still a Terminal bug, unfortunately. Thanks 😄 If It can be of any help...this worked before #4806

claunia commented

@DHowett-MSFT commented on GitHub (Mar 31, 2020):

Thanks! 4806 describes the same bug as this, so it definitely worked before 4806 ;)

@DHowett-MSFT commented on GitHub (Mar 31, 2020): Thanks! 4806 describes the same bug as this, so it definitely worked before 4806 ;)

claunia commented

@vincentkam commented on GitHub (Apr 2, 2020):

I thought I'd share my experience with this bug: I had an older version of the Firacode fonts hanging out in %APPDATA%\Local\Microsoft\Windows\Fonts that was being preferentially loaded instead of the 2.0 fonts I had installed into C:\Windows\Fonts. I was unable to delete the fonts in %APPDATA%\Local\Microsoft\Windows\Fonts despite using elevated command prompts, trying to close all handles to the fonts using Process Explorer (trying to do so resulted in invalid handle messages), and many other methods. The only thing that worked for me was using IObit Unlocker. After removing those font files, Terminal correctly picked up the newer FiraCode font and seems to be working normally now.

Windows 10 Version 1909 (OS Build 1836.752)
Terminal version: 0.10.781.0

@vincentkam commented on GitHub (Apr 2, 2020): I thought I'd share my experience with this bug: I had an older version of the Firacode fonts hanging out in `%APPDATA%\Local\Microsoft\Windows\Fonts` that was being preferentially loaded instead of the 2.0 fonts I had installed into `C:\Windows\Fonts`. I was unable to delete the fonts in `%APPDATA%\Local\Microsoft\Windows\Fonts` despite using elevated command prompts, trying to close all handles to the fonts using Process Explorer (trying to do so resulted in invalid handle messages), and many other methods. The only thing that worked for me was using IObit Unlocker. After removing those font files, Terminal correctly picked up the newer FiraCode font and seems to be working normally now. Windows 10 Version 1909 (OS Build 1836.752) Terminal version: 0.10.781.0

claunia commented

@privacyguy123 commented on GitHub (Apr 12, 2020):

Any ETA on this?

@privacyguy123 commented on GitHub (Apr 12, 2020): Any ETA on this?

claunia commented

@zadjii-msft commented on GitHub (Apr 13, 2020):

@privacyguy123 Unfortunately not at this time. I tried reproing this Friday, but I couldn't get this to happen on my machine at all with Fira Code 1.2. Hopefully someone else on the team will have a better chance at reproing this.

If we can't get a repro locally, we could try psychic debugging by looking at the changelog of what Fira Code changed on their side between 1.2 and 2.0. Maybe that would point us in the right direction of something we've done wrong.

It's also just possible that some of the rendering changes that are baking for 0.11 (#778/#5185) might just fix this, which might explain why I couldn't get a repro.

@zadjii-msft commented on GitHub (Apr 13, 2020): @privacyguy123 Unfortunately not at this time. I tried reproing this Friday, but I couldn't get this to happen on my machine at all with Fira Code 1.2. Hopefully someone else on the team will have a better chance at reproing this. If we can't get a repro locally, we could try psychic debugging by looking at the changelog of what Fira Code changed on their side between 1.2 and 2.0. Maybe that would point us in the right direction of something we've done wrong. It's also just possible that some of the rendering changes that are baking for 0.11 (#778/#5185) might just fix this, which might explain why I couldn't get a repro.

claunia commented

@jsoref commented on GitHub (Apr 13, 2020):

@zadjii-msft / @DHowett-MSFT : the bot can't complain about issue titles, but can you please fix invisible? 😉

@jsoref commented on GitHub (Apr 13, 2020): @zadjii-msft / @DHowett-MSFT : the bot can't complain about issue titles, but can you please fix `invisible`? 😉

claunia commented

@DHowett-MSFT commented on GitHub (Apr 13, 2020):

@jsoref done

@DHowett-MSFT commented on GitHub (Apr 13, 2020): @jsoref done

claunia commented

@DHowett-MSFT commented on GitHub (Apr 13, 2020):

:trollface:

@DHowett-MSFT commented on GitHub (Apr 13, 2020): :trollface:

claunia commented

@jsoref commented on GitHub (Apr 13, 2020):

Technically, I suppose, I should say "it doesn't". It probably could.

@jsoref commented on GitHub (Apr 13, 2020): Technically, I suppose, I should say "it doesn't". It probably _could_.

claunia commented

@privacyguy123 commented on GitHub (Apr 29, 2020):

Come on boys - new release and this was overlooked? It worked fine in earlier versions ...

Here is the f00king exact font it's happening with on my machine ;)
https://github.com/ryanoasis/nerd-fonts/blob/master/patched-fonts/FiraCode/Medium/complete/Fura%20Code%20Medium%20Nerd%20Font%20Complete%20Windows%20Compatible.ttf

@privacyguy123 commented on GitHub (Apr 29, 2020): Come on boys - new release and this was overlooked? It worked fine in earlier versions ... Here is the f00king exact font it's happening with on my machine ;) https://github.com/ryanoasis/nerd-fonts/blob/master/patched-fonts/FiraCode/Medium/complete/Fura%20Code%20Medium%20Nerd%20Font%20Complete%20Windows%20Compatible.ttf

claunia commented

@zadjii-msft commented on GitHub (Apr 29, 2020):

This is a purely graphical bug (the characters are still in the buffer, just not rendered for some reason)
With a trivial workaround (Upgrade the font, or pick any other font)
And the team doesn't have a local repro for this with the FiraCode v1.2 that other users are reporting an error with
- EDIT: I just installed the font you linked, and that does repro the bug for me, so that's helpful, thanks!

So no, this hasn't really bubbled up in our own priority list. Also, at least I was hoping that #5345 would just magically fix this (as there was quite a bit of renderer changes in that PR).

EDIT:

Even with the repro, I'm pretty sure this isn't going to make the 1.0 cut for the aforementioned reasons. If someone in the community were generous enough to contribute a fix, we'd probably take that though!

@zadjii-msft commented on GitHub (Apr 29, 2020): * This is a purely graphical bug (the characters are still in the buffer, just not rendered for some reason) * With a trivial workaround (Upgrade the font, or pick _any other font_) * And the team doesn't have a local repro for this with the FiraCode v1.2 that other users are reporting an error with - EDIT: I just installed the font you linked, and that _does_ repro the bug for me, so that's helpful, thanks! So no, this hasn't really bubbled up in our own priority list. Also, at least I was hoping that #5345 would just magically fix this (as there was quite a bit of renderer changes in that PR). EDIT: Even with the repro, I'm pretty sure this isn't going to make the 1.0 cut for the aforementioned reasons. If someone in the community were generous enough to contribute a fix, we'd probably take that though!

claunia commented

@privacyguy123 commented on GitHub (Apr 29, 2020):

EDIT: Bug fixed by repatching my own Fira Code 1.2 with https://github.com/ryanoasis/nerd-fonts font-patcher script fixes this bug, perhaps the one they have uploaded is broken? 🤪

@privacyguy123 commented on GitHub (Apr 29, 2020): EDIT: Bug fixed by repatching my own Fira Code 1.2 with https://github.com/ryanoasis/nerd-fonts font-patcher script fixes this bug, perhaps the one they have uploaded is broken? 🤪

claunia commented

@audreyality commented on GitHub (Jun 8, 2020):

This bug occurred on my machine with FiraCode 4.0. The problem was resolved when I unblocked the FiraCode ttf files before installing them and restarted my terminal.

@audreyality commented on GitHub (Jun 8, 2020): This bug occurred on my machine with FiraCode 4.0. The problem was resolved when I **unblocked the FiraCode ttf files** before installing them and restarted my terminal.

claunia commented

@zadjii-msft commented on GitHub (Sep 12, 2022):

I'm curious if this just went away in 1.16. The Atlas engine might have just fixed this.

@zadjii-msft commented on GitHub (Sep 12, 2022): I'm curious if this just went away in 1.16. The Atlas engine might have just fixed this.

claunia commented

@zadjii-msft commented on GitHub (Sep 18, 2023):

Anyone still seeing this on Terminal 1.18/? There's been a whole pile of massive renderer rewrites in the last year.

@zadjii-msft commented on GitHub (Sep 18, 2023): Anyone still seeing this on Terminal 1.18/? There's been a whole pile of massive renderer rewrites in the last year.

claunia commented