White border when Terminal is dark while Windows is in Light theme #6951

Closed
opened 2026-01-31 00:51:23 +00:00 by claunia · 3 comments
Owner

Originally created by @hylowaker on GitHub (Mar 18, 2020).

Environment

Windows build number: Microsoft Windows [Version 10.0.19582.1001]
Windows Terminal version (if applicable): 0.10.761.0

Steps to reproduce

  1. Set Windows theme to Light.
  2. In profiles.json, set "requestedTheme": "dark" and "showTabsInTitlebar": true
  3. Focus on the window.

Expected behavior

No white borders, regardless of Windows theme color. (Like as VSCode)

Actual behavior

image

Though https://github.com/microsoft/terminal/pull/4817 fixes the white border issue for Dark mode in Windows, the border still presents with the combination of dark theme for Terminal settings and light theme for Windows.

Originally created by @hylowaker on GitHub (Mar 18, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Microsoft Windows [Version 10.0.19582.1001] Windows Terminal version (if applicable): 0.10.761.0 ``` # Steps to reproduce 1. Set Windows theme to Light. 1. In `profiles.json`, set `"requestedTheme": "dark"` and `"showTabsInTitlebar": true` 1. Focus on the window. # Expected behavior No white borders, regardless of Windows theme color. (Like as VSCode) # Actual behavior ![image](https://user-images.githubusercontent.com/10094075/76942951-e8ef2980-6941-11ea-9878-de93feaed95f.png) Though https://github.com/microsoft/terminal/pull/4817 fixes the white border issue for Dark mode in Windows, the border still presents with the combination of dark theme for Terminal settings and light theme for Windows.
Author
Owner

@DHowett-MSFT commented on GitHub (Mar 19, 2020):

So, we're doing our level best with the system API here. I'm going to keep this one around tracking our switch to the final API when it's out.

@DHowett-MSFT commented on GitHub (Mar 19, 2020): So, we're doing our level best with the system API here. I'm going to keep this one around tracking our switch to the final API when it's out.
Author
Owner

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5105, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5105, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Author
Owner

@michalhudecek commented on GitHub (Jun 21, 2020):

This has not been fixed. There should be no white border regardless the theme as mentioned in Expected behavior in this issue

image

@michalhudecek commented on GitHub (Jun 21, 2020): This has not been fixed. There should be no white border regardless the theme as mentioned in Expected behavior in this issue ![image](https://user-images.githubusercontent.com/1215304/85220414-8cb9fc80-b3ab-11ea-9b57-77c882426bd0.png)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6951