starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Megathread] Panes Titlebar Follow-ups #6972

New Issue
Open
opened 2026-01-31 00:51:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 00:51:56 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Mar 18, 2020).

[Panes megathread #1000] [Original PR: #7371] [Original Issue: #4717]

Tasks

  • Add a context menu entry for "close pane"
  • Add a context menu entry for "zoom pane"
  • Add optional "maximize/close" control
    • Like the MinMaxCloseControl, but without minimize, and with "maximize" being "zoom pane"
    • Should that option be in the theme? (#3327) I'm thinking YES
  • Allow moving panes to other tabs #7075

Open Discussion

Currently, setting the tab's background color with the color picker does not update the pane titlebar color.

I think that's fine. Currently, the order of precedence is [tab runtime color, control title color, theme color (unimplemented), default color]. So I could imagine this going two ways:

  • convert the "tab runtime color" to be a "pane runtime color". Then, using the color picker on the tab would set the active pane's runtime color. This comes with the detrimental side effect that you'd have to re-color each pane in a tab manually.
  • add an additional "pane runtime color", and have the tab's color be composed from [tab runtime color, pane color (which is itself [pane runtime color, control title color, theme pane title color]), theme color, default]. This would allow panes to have their color changed at runtime with a color picker, and also have the tab have a manual color override.

I'm of course just hypothesizing here in the comments - I don't think any of this is something that needs to get done in this PR. We can always loop back on the issue in a follow-up.

  • Should the titlebar for a pane not appear until there are multiple panes? Kinda seems like there are three states: paneTitlebarVisibility: [never, multiplePanes, always]
Originally created by @zadjii-msft on GitHub (Mar 18, 2020). ##### [Panes megathread #1000] [Original PR: #7371] [Original Issue: #4717] ### Tasks * [ ] Add a context menu entry for "close pane" * [ ] Add a context menu entry for "zoom pane" * [ ] Add optional "maximize/close" control - Like the MinMaxCloseControl, but without minimize, and with "maximize" being "zoom pane" - Should that option be in the theme? (#3327) _I'm thinking YES_ * [ ] Allow moving panes to other tabs #7075 ### Open Discussion * [ ] How should pane title color work with `tabColor`? https://github.com/microsoft/terminal/pull/7371#issuecomment-679223330 > > Currently, setting the tab's background color with the color picker does not update the pane titlebar color. > > I think that's fine. Currently, the order of precedence is [tab runtime color, control title color, theme color (unimplemented), default color]. So I could imagine this going two ways: > * convert the "tab runtime color" to be a "pane runtime color". Then, using the color picker on the tab would set the active _pane_'s runtime color. This comes with the detrimental side effect that you'd have to re-color each pane in a tab manually. > * add an additional "pane runtime color", and have the tab's color be composed from [tab runtime color, pane color (which is itself [pane runtime color, control title color, theme pane title color]), theme color, default]. This would allow panes to have their color changed at runtime with a color picker, and also have the tab have a manual color override. > > > I'm of course just hypothesizing here in the comments - I don't think any of this is something that _needs_ to get done in _this_ PR. We can always loop back on the issue in a follow-up. * [ ] Should the titlebar for a pane not appear until there are multiple panes? Kinda seems like there are three states: `paneTitlebarVisibility: [never, multiplePanes, always]`
claunia added the Product-TerminalArea-UserInterfaceIssue-Scenario labels 2026-01-31 00:51:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Scenario Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#6972
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?