Scenario: Add support for hyperlinks #6974

@zadjii-msft commented on GitHub (Aug 21, 2020):

Hey so hover tooltip might be hard - we can't embed a webview, so doing something like

Might be especially hard. But we could start with a TeachingTip sytle one for now

Unless we could somehow pre-render a web page to an image and display that in the tooltip. Or use something like the "social" image from github (though I haven't the damndest clue how that works.)

Maybe we should just start with

Open [web page | file]: 
{url}

in the tooltip

@zadjii-msft commented on GitHub (Aug 21, 2020): Hey so hover tooltip might be hard - we can't embed a webview, so doing something like ![image](https://user-images.githubusercontent.com/18356694/90826230-ba65e800-e2ff-11ea-9126-446162797dc0.png) Might be _especially_ hard. But we could start with a `TeachingTip` sytle one for now ![image](https://user-images.githubusercontent.com/18356694/90826280-cb165e00-e2ff-11ea-88f6-5123d7dfb283.png) Unless we could somehow pre-render a web page to an image and display that in the tooltip. Or use something like the "social" image from github (though I haven't the damndest clue how that works.) Maybe we should just start with ``` Open [web page | file]: {url} ``` in the tooltip

claunia commented

@DHowett commented on GitHub (Aug 21, 2020):

Yeah i definitely think tooltip and “the link preview from the video” are different workitems that we should tackle separately :)

@DHowett commented on GitHub (Aug 21, 2020): Yeah i definitely think _tooltip_ and “the link preview from the video” are different workitems that we should tackle separately :)

claunia commented

@j4james commented on GitHub (Aug 23, 2020):

If you have to have a "link preview", I'd recommend something really basic based on the page meta data (like the meta title and description, and maybe a favicon and/or og:image). But as cool as this might seem, I don't think it's practical for a hover effect given the delay needed to download and render these things (unless you're pre-rendering the previews, which sounds like a really bad idea).

Which brings me to the main problem. Even if you're only connecting to the site on hover, that still seems inadvisable. When I'm using a terminal I really wouldn't expect it to be making internet connections without my consent. So this feature would definitely have to be optional, and arguably I think should be off by default.

I'm possibly a little biased here, because my internet connection is metered to a certain extent. But even if that weren't the case, would most people be comfortable with their terminal downloading unknown webpages in the background?

@j4james commented on GitHub (Aug 23, 2020): If you have to have a "link preview", I'd recommend something really basic based on the page meta data (like the meta title and description, and maybe a favicon and/or og:image). But as cool as this might seem, I don't think it's practical for a hover effect given the delay needed to download and render these things (unless you're pre-rendering the previews, which sounds like a really bad idea). Which brings me to the main problem. Even if you're only connecting to the site on hover, that still seems inadvisable. When I'm using a terminal I really wouldn't expect it to be making internet connections without my consent. So this feature would definitely have to be optional, and arguably I think should be off by default. I'm possibly a little biased here, because my internet connection is metered to a certain extent. But even if that weren't the case, would most people be comfortable with their terminal downloading unknown webpages in the background?

claunia commented

@DHowett commented on GitHub (Aug 23, 2020):

Yeah, I definitely don't think that "fetch any link I hover over" is something we should ship in core or opt-in by default. It makes for a really compelling video because it shows how modern and flashy we are, but it's too much of a disclosure and safety risk to put right into our project.

@DHowett commented on GitHub (Aug 23, 2020): Yeah, I definitely don't think that "fetch any link I hover over" is something we should ship in core or opt-in by default. It makes for a really compelling video because it shows how modern and flashy we are, but it's too much of a disclosure and safety risk to put right into our project.

claunia commented

@jzabroski commented on GitHub (Sep 3, 2020):

Allow mailto: URIs

Would this be RFC conforming 😒 mailto: URL, or 😍 mailto: URL that allows multiple email addresses?

@jzabroski commented on GitHub (Sep 3, 2020): > * Allow `mailto:` URIs Would this be RFC conforming 😒 `mailto:` URL, or 😍 `mailto:` URL that allows multiple email addresses?

claunia commented

@DHowett commented on GitHub (Sep 3, 2020):

Generally, "whatever type of thing is supported by the registered protocol handler" ;P

@DHowett commented on GitHub (Sep 3, 2020): Generally, "whatever type of thing is supported by the registered protocol handler" ;P

claunia commented

@jantari commented on GitHub (Sep 3, 2020):

I don't know whether this has been considered already, but when doing a rich-text copy of the terminal buffer the hyperlinks should probably be preserved on paste

@jantari commented on GitHub (Sep 3, 2020): I don't know whether this has been considered already, but when doing a rich-text copy of the terminal buffer the hyperlinks should probably be preserved on paste

claunia commented

@DHowett commented on GitHub (Sep 3, 2020):

Thanks @jantari! Just added that to the main scenario body.

@DHowett commented on GitHub (Sep 3, 2020): Thanks @jantari! Just added that to the main scenario body.

claunia commented

@giggio commented on GitHub (Sep 3, 2020):

I just built the latest commit, but it can't parse an url, you have to use the escape sequences. Is this use case planned:

echo 'Hello from Windows Terminal: https://github.com/microsoft/terminal/'

And then click on the link and it opens?

@giggio commented on GitHub (Sep 3, 2020): I just built the latest commit, but it can't parse an url, you have to use the escape sequences. Is this use case planned: ````bash echo 'Hello from Windows Terminal: https://github.com/microsoft/terminal/' ```` And then click on the link and it opens?

claunia commented

@DHowett commented on GitHub (Sep 3, 2020):

@giggio er..

@DHowett commented on GitHub (Sep 3, 2020): @giggio er.. ![image](https://user-images.githubusercontent.com/189190/92176831-206c6800-edf4-11ea-8e37-b9f878932035.png) ![image](https://user-images.githubusercontent.com/189190/92176845-28c4a300-edf4-11ea-9c94-85ce9c0b5228.png) ![image](https://user-images.githubusercontent.com/189190/92176852-2e21ed80-edf4-11ea-94c0-3c14fd389a9c.png)

claunia commented

@DHowett commented on GitHub (Sep 3, 2020):

I don't just say these things for fun 😉 (edit: this was intended to be read as "funny", not "wow Dustin's a jerk" (but I get it!))

@DHowett commented on GitHub (Sep 3, 2020): I don't just say these things for fun 😉 (edit: this was intended to be read as "funny", not "wow Dustin's a jerk" (but I get it!))

claunia commented

@giggio commented on GitHub (Sep 3, 2020):

I had seen that comment, I was just not sure that this is what it meant, thanks for the clarification, Dustin!
And good thing you explained, so I could see it as funny. ;)

So, if I understand correctly, we don't have yet an issue tracking this item (auto-detection) specifically?

@giggio commented on GitHub (Sep 3, 2020): I had seen that comment, I was just not sure that this is what it meant, thanks for the clarification, Dustin! And good thing you explained, so I could see it as funny. ;) So, if I understand correctly, we don't have yet an issue tracking this item (auto-detection) specifically?

claunia commented

@DHowett commented on GitHub (Sep 3, 2020):

@giggio There's a lot of discussion about how to do autodetection in the comments on https://github.com/microsoft/terminal/issues/574 😄 so we're somewhat treating that issue as canonical.

@DHowett commented on GitHub (Sep 3, 2020): @giggio There's a lot of discussion about how to do autodetection in the comments on https://github.com/microsoft/terminal/issues/574 :smile: so we're somewhat treating that issue as canonical.

claunia commented

@simonratner commented on GitHub (Nov 11, 2020):

Question about url detection in 1.5.3142.

Works great in the terminal, but not inside vi. Is the app doing something special to disable this, or a different mode that url detection does not work with? I was really hoping to be able to Ctrl-Click all those documentation links in code comments.

@simonratner commented on GitHub (Nov 11, 2020): Question about url detection in 1.5.3142. Works great in the terminal, but not inside vi. Is the app doing something special to disable this, or a different mode that url detection does not work with? I was really hoping to be able to Ctrl-Click all those documentation links in code comments. ![image](https://user-images.githubusercontent.com/667283/98875547-4a17c000-2431-11eb-8b36-9bde906f6388.png) ![image](https://user-images.githubusercontent.com/667283/98875848-e346d680-2431-11eb-9e57-a39db5feea43.png)

claunia commented

@DHowett commented on GitHub (Nov 11, 2020):

So, Vim (if that's your vi implementation of choice) enables "mouse mode" -- it lets you select text and navigate the document with your mouse. You can either turn off mouse mode (:set mouse=) or temporarily suppress it by holding down Shift.

(This is also the reason that you cannot select text using the terminal when Vim is running.)

@DHowett commented on GitHub (Nov 11, 2020): So, Vim (if that's your vi implementation of choice) enables "mouse mode" -- it lets you select text and navigate the document with your mouse. You can either turn off mouse mode (`:set mouse=`) or temporarily suppress it by holding down Shift. (This is also the reason that you cannot select text _using the terminal_ when Vim is running.)

claunia commented

@jantari commented on GitHub (Nov 12, 2020):

Thanks for the information, "mouse mode" was not turned on by default for me in:

WSL, Ubuntu 20.04 where I tested vim 8.1
Windows, where I use neovim v0.5.0-558-g6d1404faf

and links worked OOTB, but I could enable it on either with :set mouse=a and not only did it exhibit the behavior you described but I also learned about mouse-mode today, thanks!

@jantari commented on GitHub (Nov 12, 2020): Thanks for the information, "mouse mode" was not turned on by default for me in: - WSL, Ubuntu 20.04 where I tested vim 8.1 - Windows, where I use neovim v0.5.0-558-g6d1404faf and links worked OOTB, but I could enable it on either with `:set mouse=a` and not only did it exhibit the behavior you described but I also learned about mouse-mode today, thanks!

claunia commented

@abhijit-hota commented on GitHub (Dec 7, 2020):

There's no solid way to detect the version of the Windows Terminal (and this feature) by an application as of now. One more use case to support #1040 .

One way is to trigger wt -v as wt is available in the Path but the again, it shows up an alert rather than just printing it. (Any reasons it does that?)

@abhijit-hota commented on GitHub (Dec 7, 2020): There's no solid way to detect the version of the Windows Terminal (and this feature) by an application as of now. One more use case to support #1040 . One way is to trigger `wt -v` as `wt` is available in the Path but the again, it shows up an alert rather than just printing it. (Any reasons it does that?)

claunia commented

@DHowett commented on GitHub (Dec 7, 2020):

any reasons

About a hundred. The rationale for this spec explains why. https://github.com/microsoft/terminal/blob/dev/duhowett/spec/console-allocation/doc/specs/%237335%20-%20Console%20Allocation%20Policy.md#abstract

@DHowett commented on GitHub (Dec 7, 2020): > any reasons About a hundred. The rationale for this spec explains why. https://github.com/microsoft/terminal/blob/dev/duhowett/spec/console-allocation/doc/specs/%237335%20-%20Console%20Allocation%20Policy.md#abstract

claunia commented

@abhijit-hota commented on GitHub (Dec 7, 2020):

About a hundred. The rationale for this spec explains why. https://github.com/microsoft/terminal/blob/dev/duhowett/spec/console-allocation/doc/specs/%237335%20-%20Console%20Allocation%20Policy.md#abstract

Ah I see. Thanks for the clarification. Waiting for 1040 to get resolved :).

Edit: I don't understand the abstract but I get there are valid reasons.

@abhijit-hota commented on GitHub (Dec 7, 2020): > About a hundred. The rationale for this spec explains why. https://github.com/microsoft/terminal/blob/dev/duhowett/spec/console-allocation/doc/specs/%237335%20-%20Console%20Allocation%20Policy.md#abstract Ah I see. Thanks for the clarification. Waiting for 1040 to get resolved :). Edit: I don't understand the abstract but I get there are valid reasons.

claunia commented

@GoodClover commented on GitHub (Jan 10, 2021):

I was wondering if there was any plans to support data: URIs?
This could be used to embed a (very small) image or just some plain text that would appear, most likely in a popup.

I saw #6747, which suggest support for parsing them is planned for settings.json icons.

There is some info about data: in terminals here: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#gistcomment-2192652

@GoodClover commented on GitHub (Jan 10, 2021): I was wondering if there was any plans to support [`data:` URIs](https://en.wikipedia.org/wiki/Data_URI_scheme)? This could be used to embed a (very small) image or just some plain text that would appear, most likely in a popup. I saw #6747, which suggest support for parsing them is planned for `settings.json` icons. There is some info about `data:` in terminals here: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#gistcomment-2192652

claunia commented

@wongjn commented on GitHub (Jan 28, 2021):

Is there a way to change to modifier key for a link press? I have grown accustomed to using ALT. I couldn't find anything in the documentation, so it would be nice to have this as a keybind setting if it does not exist already.

@wongjn commented on GitHub (Jan 28, 2021): Is there a way to change to modifier key for a link press? I have grown accustomed to using `ALT`. I couldn't find anything in the documentation, so it would be nice to have this as a keybind setting if it does not exist already.

claunia commented