starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

exit command doesn't close the window\tab #7036

New Issue
Closed
opened 2026-01-31 00:53:25 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 00:53:25 +00:00
Owner
Copy Link

Originally created by @fcingolani88 on GitHub (Mar 20, 2020).

Windows build number: 10.0.18363.720
Windows Terminal version (if applicable): 0.10.761.0

Steps to reproduce

Type "EXIT" command after the shell reports an error about the previous command

Expected behavior

The window\tab should be closed

Actual behavior

The window\tab stays open and I can't type anything. The exit code displayed changes on different cases, maybe is related to the error reported before.

Note that this seems to happen only when the previous command terminates with an error; if the previous command is performed correctly, the EXIT command will work as expected.

image

image

Thanks

Originally created by @fcingolani88 on GitHub (Mar 20, 2020). Windows build number: 10.0.18363.720 Windows Terminal version (if applicable): 0.10.761.0 # Steps to reproduce Type "EXIT" command after the shell reports an error about the previous command # Expected behavior The window\tab should be closed # Actual behavior The window\tab stays open and I can't type anything. The exit code displayed changes on different cases, maybe is related to the error reported before. Note that this seems to happen only when the previous command terminates with an error; if the previous command is performed correctly, the EXIT command will work as expected. ![image](https://user-images.githubusercontent.com/47388994/77177531-f46b5d80-6ac5-11ea-8e2c-5ede42e426eb.png) ![image](https://user-images.githubusercontent.com/47388994/77178257-1b765f00-6ac7-11ea-82a7-17ce2f4a8136.png) Thanks
claunia added the Resolution-Duplicate label 2026-01-31 00:53:25 +00:00
claunia commented 2026-01-31 00:53:25 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 20, 2020):

Alas, this is a behavior that's highly conserved across multiple shells and terminal emulators on most mainstream operating systems; more info in https://github.com/microsoft/terminal/issues/4223#issuecomment-574834181. If you'd rather it just exit every time, set closeOnExit to true. 😄 /dup #4223.

@DHowett-MSFT commented on GitHub (Mar 20, 2020): Alas, this is a behavior that's highly conserved across multiple shells and terminal emulators on most mainstream operating systems; more info in https://github.com/microsoft/terminal/issues/4223#issuecomment-574834181. If you'd rather it just exit every time, set `closeOnExit` to true. :smile: /dup #4223.
claunia commented 2026-01-31 00:53:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 20, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Mar 20, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 00:53:26 +00:00
Author
Owner
Copy Link

@fcingolani88 commented on GitHub (Mar 20, 2020):

ok, but I already have closeOnExit to true. I think by default

@fcingolani88 commented on GitHub (Mar 20, 2020): ok, but I already have `closeOnExit` to true. I think by default
claunia commented 2026-01-31 00:53:26 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 20, 2020):

@fcingolani88 would you mind sharing a copy of your profiles.json file?

@DHowett-MSFT commented on GitHub (Mar 20, 2020): @fcingolani88 would you mind sharing a copy of your profiles.json file?
claunia commented 2026-01-31 00:53:26 +00:00
Author
Owner
Copy Link

@fcingolani88 commented on GitHub (Mar 20, 2020):

Sure, here you are
profiles.zip

@fcingolani88 commented on GitHub (Mar 20, 2020): Sure, here you are [profiles.zip](https://github.com/microsoft/terminal/files/4360528/profiles.zip)
claunia commented 2026-01-31 00:53:26 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 20, 2020):

Oh, thanks! I realized my guidance is incorrect. When we changed how closeOnExit worked, we introduced some new values: "graceful", "never" and "always'. We made it so that true was the same as "graceful" (which is the behavior you're seeing.)

You'll need to set it to "always" to make sure it actually exits.

As an aside, it looks like you're using a very old version of our settings file. If you're willing to change it, now would be a great time to start over as described in Scott Hanselman's blog. If you're using older settings like those that bind Ctrl+T and Ctrl+W to new and close tab, you might need to update your new settings file with those options. Otherwise, it's a much better experience. 😄

@DHowett-MSFT commented on GitHub (Mar 20, 2020): Oh, thanks! I realized my guidance is incorrect. When we changed how `closeOnExit` worked, we introduced some new values: `"graceful"`, `"never`" and `"always'`. We made it so that `true` was the same as `"graceful`" (which is the behavior you're seeing.) You'll need to set it to `"always"` to make sure it actually exits. As an aside, it looks like you're using a very old version of our settings file. If you're willing to change it, now would be a great time to [start over](https://hanselman.com/blog/NowIsTheTimeToMakeAFreshNewWindowsTerminalProfilesjson.aspx) as described in Scott Hanselman's blog. If you're using older settings like those that bind <kbd>Ctrl+T</kbd> and <kbd>Ctrl+W</kbd> to new and close tab, you might need to update your new settings file with those options. Otherwise, it's a _much_ better experience. :smile:
claunia commented 2026-01-31 00:53:27 +00:00
Author
Owner
Copy Link

@fcingolani88 commented on GitHub (Mar 23, 2020):

Perfect!!
Thank you, also for Scott Hanselman's info

@fcingolani88 commented on GitHub (Mar 23, 2020): Perfect!! Thank you, also for Scott Hanselman's info
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7036
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?