starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Using cleartype anti aliasing makes dark foreground invisible on light background. #7118

New Issue
Closed
opened 2026-01-31 00:55:34 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 00:55:34 +00:00
Owner
Copy Link

Originally created by @alexFrankfurt on GitHub (Mar 24, 2020).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: 10.0.18363.0
Windows Terminal version: 0.10.781.0
Powershell version: 7.0.0

Steps to reproduce

Setting profile settings to following:

{
    "useAcrylic": false,
    "closeOnExit" : true,
    "colorScheme" : "Campbell",
    "guid": "{a3c89eef-1dbe-4ac1-acc5-2412499f8619}",
    "hidden": false,
    "name": "PowerShell 7",
    "commandline" : "C:\\Program Files\\PowerShell\\7\\pwsh.exe",
    "icon" : "C:\\Program Files\\PowerShell\\7\\assets\\Powershell_av_colors.ico",
    "antialiasingMode": "grayscale",
    "cursorShape" : "bar",
    "cursorColor": "#121005",
    "fontFace" : "Consolas",
    "fontSize" : 10,
    "snapOnInput" : true,
    "historySize" : 9001
}

and theme settings to:

{
    "name" : "Campbell",

    "foreground" : "#020200",
    "background" : "#ffffff",
    "selectionBackground": "#121005",

    "black" : "#0C0C0C",
    "blue" : "#0037DA",
    "brightBlack" : "#767676",
    "brightBlue" : "#3B78FF",
    "brightCyan" : "#61D6D6",
    "brightGreen" : "#16C60C",
    "brightPurple" : "#B4009E",
    "brightRed" : "#E74856",
    "brightWhite" : "#121212",
    "brightYellow" : "#3B78FF",
    "cyan" : "#3A96DD",
    "green" : "#13A10E",
    "purple" : "#881798",
    "red" : "#C50F1F",
    "white" : "#CCCCCC",
    "yellow" : "#C19C00"
}

Expected behavior

Black text F:\> is visible. When antialiasingMode is set to cleartype.

Actual behavior

Black text F:\> is invisible after setting antialiasingMode to cleartype (on the right):
image
Same issue with cmd ("acrylicOpacity" : 0.75):
image

Originally created by @alexFrankfurt on GitHub (Mar 24, 2020). Originally assigned to: @zadjii-msft on GitHub. # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version: 0.10.781.0 Powershell version: 7.0.0 ``` # Steps to reproduce Setting profile settings to following: ```json { "useAcrylic": false, "closeOnExit" : true, "colorScheme" : "Campbell", "guid": "{a3c89eef-1dbe-4ac1-acc5-2412499f8619}", "hidden": false, "name": "PowerShell 7", "commandline" : "C:\\Program Files\\PowerShell\\7\\pwsh.exe", "icon" : "C:\\Program Files\\PowerShell\\7\\assets\\Powershell_av_colors.ico", "antialiasingMode": "grayscale", "cursorShape" : "bar", "cursorColor": "#121005", "fontFace" : "Consolas", "fontSize" : 10, "snapOnInput" : true, "historySize" : 9001 } ``` and theme settings to: ```json { "name" : "Campbell", "foreground" : "#020200", "background" : "#ffffff", "selectionBackground": "#121005", "black" : "#0C0C0C", "blue" : "#0037DA", "brightBlack" : "#767676", "brightBlue" : "#3B78FF", "brightCyan" : "#61D6D6", "brightGreen" : "#16C60C", "brightPurple" : "#B4009E", "brightRed" : "#E74856", "brightWhite" : "#121212", "brightYellow" : "#3B78FF", "cyan" : "#3A96DD", "green" : "#13A10E", "purple" : "#881798", "red" : "#C50F1F", "white" : "#CCCCCC", "yellow" : "#C19C00" } ``` # Expected behavior Black text `F:\>` is visible. When antialiasingMode is set to cleartype. # Actual behavior Black text `F:\>` is invisible after setting antialiasingMode to cleartype (on the right): ![image](https://user-images.githubusercontent.com/11091671/77416329-cbeca780-6dd4-11ea-9e17-eb7ed07ef51b.png) Same issue with cmd ("acrylicOpacity" : 0.75): ![image](https://user-images.githubusercontent.com/11091671/77418748-626e9800-6dd8-11ea-9e9e-e4ff4b8b1dc8.png)
claunia commented 2026-01-31 00:55:35 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 6, 2020):

I'll be damned that repros for me immediately

Huh, seems like we're doing some weird blending for cleartype text:
image

@zadjii-msft commented on GitHub (Apr 6, 2020): I'll be damned that repros for me immediately Huh, seems like we're doing some weird blending for cleartype text: ![image](https://user-images.githubusercontent.com/18356694/78607888-86dd6200-7825-11ea-8271-f98be723715f.png)
claunia commented 2026-01-31 00:55:35 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 7, 2020):

Yikes okay, I'm reading more about this problem and this is sounding harder the more I read about it.

Basically, if you want to use cleartype text, you want to make sure to give the DX target a background behind the cleartext text. Otherwise, it can't really figure out how to blend the cleartype text. We're currently not giving the text a background for the default background color, as to support acrylic. So our dx render target will have a transparent BG, and the entire swapchain is drawn on top of the acrylic background.

I think I can patch this, but I think this basically means that if you want cleartype text, you can't have acrylic, and vice-versa. Since we're able to hot-reload and dynamically change acrylic opacity, but not the antialiasing mode, I think this means we'll need to have cleartype disable acrylic opacity entirely.

Unless there were some way to have the transparent parts of the swapchain not added to the underlying surface, but that's still not the right solution. DWrite just really doesn't want to let us have cleartype on a target where there's no BG already. It also seems like we can't get the rendered acrylic surface before we paint a DX frame to try and manually set that as the background for the target.

Or maybe there's something else I can do with D2D1_LAYER_OPTIONS1_IGNORE_ALPHA? I've got no idea if that'll work

@zadjii-msft commented on GitHub (Apr 7, 2020): Yikes okay, I'm reading more about this problem and this is sounding harder the more I read about it. Basically, if you want to use cleartype text, you want to make sure to give the DX target a background behind the cleartext text. Otherwise, it can't really figure out how to blend the cleartype text. We're currently _not_ giving the text a background for the default background color, as to support acrylic. So our dx render target will have a transparent BG, and the entire swapchain is drawn on top of the acrylic background. I think I can patch this, but I think this basically means that if you want cleartype text, you can't have acrylic, and vice-versa. Since we're able to hot-reload and dynamically change acrylic opacity, but not the antialiasing mode, I think this means we'll need to have cleartype disable acrylic opacity entirely. Unless there were some way to have the transparent parts of the swapchain not _added_ to the underlying surface, but that's still not the right solution. DWrite just really doesn't want to let us have cleartype on a target where there's no BG already. It also seems like we can't get the rendered acrylic surface _before_ we paint a DX frame to try and manually set that as the background for the target. Or maybe there's something else I can do with `D2D1_LAYER_OPTIONS1_IGNORE_ALPHA`? I've got no idea if that'll work
claunia commented 2026-01-31 00:55:35 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 5, 2020):

:tada:This issue was addressed in #5277, which has now been successfully released as Windows Terminal Release Candidate v0.11.1251.0 (1.0rc1).🎉

Handy links:

@ghost commented on GitHub (May 5, 2020): :tada:This issue was addressed in #5277, which has now been successfully released as `Windows Terminal Release Candidate v0.11.1251.0 (1.0rc1)`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1251.0 (1.0rc1)) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7118
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?