starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Background tabs shouldn't actually render their contents #7167

New Issue
Closed
opened 2026-01-31 00:56:52 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:56:52 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Mar 27, 2020).

Originally assigned to: @miniksa on GitHub.

I noticed that while running the tests in the Terminal that we always spend CPU/GPU time rendering a TermControl, even if the hosting tab is in the background. I'm not 100% certain about this, but it sure seemed like this was happening on my slaptop.

IIRC conhost does some logic to no-op rendering when it's minimized - TermControl should probably do something similar, including for when the tab isn't visible.

Basic Repro

  1. Open two tabs
  2. In the first one, run the unit tests, or anything else that'll generate a ton of output.
  3. Switch to the other tab, and do nothing in it.

Expected

The GPU usage for the Terminal should be at the baseline usage for a terminal that's not doing anything.

Actual

GPU seemed to be getting the workout it normally does processing boatloads of output

Originally created by @zadjii-msft on GitHub (Mar 27, 2020). Originally assigned to: @miniksa on GitHub. I noticed that while running the tests in the Terminal that we always spend CPU/GPU time rendering a TermControl, even if the hosting tab is in the background. I'm not 100% certain about this, but it sure seemed like this was happening on my slaptop. IIRC conhost does some logic to no-op rendering when it's minimized - `TermControl` should probably do something similar, including for when the tab isn't visible. ### Basic Repro 1. Open two tabs 2. In the first one, run the unit tests, or anything else that'll generate a ton of output. 3. Switch to the other tab, and do nothing in it. ### Expected The GPU usage for the Terminal should be at the baseline usage for a terminal that's _not_ doing anything. ### Actual GPU seemed to be getting the workout it normally does processing boatloads of output
claunia commented 2026-01-31 00:56:53 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 27, 2020):

I believe this is related to #1989

@DHowett-MSFT commented on GitHub (Mar 27, 2020): I believe this is related to #1989
claunia commented 2026-01-31 00:56:54 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 27, 2020):

/dup #1989

@DHowett-MSFT commented on GitHub (Mar 27, 2020): /dup #1989
claunia commented 2026-01-31 00:56:54 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 27, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Mar 27, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 00:56:54 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 27, 2020):

See, I don't think so. That one is more specifically the whole window, while this one's more specific inactive tabs. I'm fine changing the other one to call out this case better though

@zadjii-msft commented on GitHub (Mar 27, 2020): See, I don't think so. That one is more specifically the _whole window_, while this one's more specific _inactive_ tabs. I'm fine changing the other one to call out this case better though
claunia commented 2026-01-31 00:56:54 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Mar 27, 2020):

I dunno, the title includes "control has been hidden". I think that a solution to one helps the other.

@DHowett-MSFT commented on GitHub (Mar 27, 2020): I dunno, the title includes "control has been hidden". I think that a solution to one helps the other.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Performance Area-Rendering Issue-Bug Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7167
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?