Accessibility: jumps in review #7170

Closed
opened 2026-01-31 00:56:59 +00:00 by claunia · 6 comments
Owner

Originally created by @codeofdusk on GitHub (Mar 27, 2020).

Originally assigned to: @carlos-zamora on GitHub.

Environment

Windows build number: [run [Environment]::OSVersion for powershell, or ver for cmd]: 1909 (18363.720)

Windows Terminal version (if applicable): Terminal as of 5bcf0fc.

Any other software? NVDA, Narrator.

Steps to reproduce

  1. type:
echo 1
echo 2
echo 3
  1. Using NVDA with Windows Terminal support or Narrator, review a few previous lines of output. You should see the prompt, then 3, 2, 1.
  2. wait about three seconds.
  3. Try to review previous line again.

Expected behavior

The screen reader keeps its position, reporting "2" for example if the last-reviewed line was "3".

Actual behavior

The screen reader reads the prompt again, then starts back over with 3, almost as if the cursor bounced back.

Originally created by @codeofdusk on GitHub (Mar 27, 2020). Originally assigned to: @carlos-zamora on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]: 1909 (18363.720) Windows Terminal version (if applicable): Terminal as of 5bcf0fc. Any other software? NVDA, Narrator. # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. type: ``` shell echo 1 echo 2 echo 3 ``` 2. Using NVDA with Windows Terminal support or Narrator, review a few previous lines of output. You should see the prompt, then 3, 2, 1. 3. wait about three seconds. 4. Try to review previous line again. # Expected behavior The screen reader keeps its position, reporting "2" for example if the last-reviewed line was "3". <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior The screen reader reads the prompt again, then starts back over with 3, almost as if the cursor bounced back. <!-- What's actually happening? -->
Author
Owner

@codeofdusk commented on GitHub (Mar 27, 2020):

Cc @carlos-zamora.

@codeofdusk commented on GitHub (Mar 27, 2020): Cc @carlos-zamora.
Author
Owner

@codeofdusk commented on GitHub (Mar 27, 2020):

This cursor bouncing does not occur in open console (that works as expected).

@codeofdusk commented on GitHub (Mar 27, 2020): This cursor bouncing does not occur in open console (that works as expected).
Author
Owner

@carlos-zamora commented on GitHub (Mar 27, 2020):

I tested this with NVDA and Narrator. NVDA 2020.1 does not reproduce the above example, but Narrator does.

After disabling cursor blinking, scan mode on Narrator is no longer interrupted. After #5135 goes in, I may be able to leverage the new winrt event to only fire a CursorChanged event on cursor movements, instead of every time we render the cursor. This should be a lot less noisy.

@carlos-zamora commented on GitHub (Mar 27, 2020): I tested this with NVDA and Narrator. NVDA 2020.1 does not reproduce the above example, but Narrator does. After disabling cursor blinking, scan mode on Narrator is no longer interrupted. After #5135 goes in, I may be able to leverage the new winrt event to only fire a CursorChanged event on cursor movements, instead of every time we render the cursor. This should be a lot less noisy.
Author
Owner

@codeofdusk commented on GitHub (Mar 31, 2020):

After #5135 goes in, I may be able to leverage the new winrt event to only fire a CursorChanged event on cursor movements, instead of every time we render the cursor. This should be a lot less noisy.

Now that #5135 has been merged, does this still seem possible?

@codeofdusk commented on GitHub (Mar 31, 2020): > After #5135 goes in, I may be able to leverage the new winrt event to only fire a CursorChanged event on cursor movements, instead of every time we render the cursor. This should be a lot less noisy. Now that #5135 has been merged, does this still seem possible?
Author
Owner

@carlos-zamora commented on GitHub (Mar 31, 2020):

After #5135 goes in, I may be able to leverage the new winrt event to only fire a CursorChanged event on cursor movements, instead of every time we render the cursor. This should be a lot less noisy.

Now that #5135 has been merged, does this still seem possible?

Yeah. Working on it now. Hoping to get a PR in by the end of the day or tomorrow 😊

@carlos-zamora commented on GitHub (Mar 31, 2020): > > After #5135 goes in, I may be able to leverage the new winrt event to only fire a CursorChanged event on cursor movements, instead of every time we render the cursor. This should be a lot less noisy. > > Now that #5135 has been merged, does this still seem possible? Yeah. Working on it now. Hoping to get a PR in by the end of the day or tomorrow 😊
Author
Owner

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5196, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5196, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7170