starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Resizing a Terminal with retro terminal effects hangs the Terminal #7243

New Issue
Closed
opened 2026-01-31 00:58:51 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 00:58:51 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 1, 2020).

Originally assigned to: @DHowett-MSFT on GitHub.

This is on the selfhost 0.11.912.0 release, but also repro'd on the last 0.11 preview. Unsure if it repros on earlier builds also.

Add the following to a profile:

"experimental.retroTerminalEffect": true

Then open a tab with that profile and try resizing the Terminal.

Expected

The Terminal should not hang.

Actual

It hangs 😢

Looks like we're waiting for the read lock at the top of TermControl::RenderEngineSwapChainChanged on the RenderThread. This is higher on the stack than Renderer::_PaintFrameForEngine, which I believe has a write lock. But it's the same thread, so we should be fine, right?

Oh no the main thread also is waiting on the write lock 😲

03 TerminalControl!std::unique_lock<std::shared_mutex>::{ctor}+0x8 
04 TerminalControl!Microsoft::Terminal::Core::Terminal::LockForWriting+0x14
05 TerminalControl!winrt::Microsoft::Terminal::TerminalControl::implementation::TermControl::_SwapChainSizeChanged+0x37
06 TerminalControl!winrt::Microsoft::Terminal::TerminalControl::implementation::TermControlT<winrt::Microsoft::Terminal::TerminalControl::implementation::TermControl>::Connect::__l10::<lambda_87fbcfa1739d624dde571db8710dac26>::operator()+0x77

Wait no, that's fine. The main thread doesn't have the lock, it's just waiting for it. That's fine. I think the problem is the render thread can't seem to re-enter the lock

because it's a shared_mutex not a recursive_mutex

Originally created by @zadjii-msft on GitHub (Apr 1, 2020). Originally assigned to: @DHowett-MSFT on GitHub. This is on the selfhost 0.11.912.0 release, but also repro'd on the last 0.11 preview. Unsure if it repros on earlier builds also. Add the following to a profile: ```json "experimental.retroTerminalEffect": true ``` Then open a tab with that profile and try resizing the Terminal. ### Expected The Terminal should not hang. ### Actual It hangs 😢 Looks like we're waiting for the read lock at the top of `TermControl::RenderEngineSwapChainChanged` on the `RenderThread`. This is higher on the stack than `Renderer::_PaintFrameForEngine`, which I believe has a write lock. But it's the same thread, so we should be fine, right? Oh no the main thread also is waiting on the write lock 😲 ``` 03 TerminalControl!std::unique_lock<std::shared_mutex>::{ctor}+0x8 04 TerminalControl!Microsoft::Terminal::Core::Terminal::LockForWriting+0x14 05 TerminalControl!winrt::Microsoft::Terminal::TerminalControl::implementation::TermControl::_SwapChainSizeChanged+0x37 06 TerminalControl!winrt::Microsoft::Terminal::TerminalControl::implementation::TermControlT<winrt::Microsoft::Terminal::TerminalControl::implementation::TermControl>::Connect::__l10::<lambda_87fbcfa1739d624dde571db8710dac26>::operator()+0x77 ``` Wait no, that's fine. The main thread doesn't _have_ the lock, it's just waiting for it. That's fine. I think the problem is the render thread can't seem to re-enter the lock because it's a `shared_mutex` not a [`recursive_mutex`](https://en.cppreference.com/w/cpp/thread/recursive_mutex)
claunia commented 2026-01-31 00:58:52 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 1, 2020):

I accept that this is probably my fault: call stack looks like it's in LockForWriting 😉

@DHowett-MSFT commented on GitHub (Apr 1, 2020): I accept that this is _probably_ my fault: call stack looks like it's in `LockForWriting` :wink:
claunia commented 2026-01-31 00:58:53 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 1, 2020):

Oh, you .. already .. did that. Ugh, sorry.

@DHowett-MSFT commented on GitHub (Apr 1, 2020): Oh, you .. already .. did that. Ugh, sorry.
claunia commented 2026-01-31 00:58:53 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 1, 2020):

I'm actually seeing a second thread contending the lock also handling a swap chain change.

02 (Inline Function) --------`-------- TerminalControl!std::shared_mutex::lock_shared+0x5 [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.24.28314\include\shared_mutex @ 55] 
03 (Inline Function) --------`-------- TerminalControl!std::shared_lock<std::shared_mutex>::{ctor}+0x5 [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.24.28314\include\shared_mutex @ 241] 
04 (Inline Function) --------`-------- TerminalControl!Microsoft::Terminal::Core::Terminal::LockForReading+0x17 [E:\BA\193\s\src\cascadia\TerminalCore\Terminal.cpp @ 542] 
05 00000037`4cfff580 00007ffc`cc0931f5 TerminalControl!winrt::Microsoft::Terminal::TerminalControl::implementation::TermControl::RenderEngineSwapChainChanged$_ResumeCoro$2+0xb3 [E:\BA\193\s\src\cascadia\TerminalControl\TermControl.cpp @ 489] 
06 00000037`4cfff690 00007ffc`cc0a1a5b TerminalControl!winrt::Microsoft::Terminal::TerminalControl::implementation::TermControl::RenderEngineSwapChainChanged+0x45 [E:\BA\193\s\src\cascadia\TerminalControl\TermControl.cpp @ 506]
@DHowett-MSFT commented on GitHub (Apr 1, 2020): I'm actually seeing a second thread contending the lock _also_ handling a swap chain change. ``` 02 (Inline Function) --------`-------- TerminalControl!std::shared_mutex::lock_shared+0x5 [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.24.28314\include\shared_mutex @ 55] 03 (Inline Function) --------`-------- TerminalControl!std::shared_lock<std::shared_mutex>::{ctor}+0x5 [C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.24.28314\include\shared_mutex @ 241] 04 (Inline Function) --------`-------- TerminalControl!Microsoft::Terminal::Core::Terminal::LockForReading+0x17 [E:\BA\193\s\src\cascadia\TerminalCore\Terminal.cpp @ 542] 05 00000037`4cfff580 00007ffc`cc0931f5 TerminalControl!winrt::Microsoft::Terminal::TerminalControl::implementation::TermControl::RenderEngineSwapChainChanged$_ResumeCoro$2+0xb3 [E:\BA\193\s\src\cascadia\TerminalControl\TermControl.cpp @ 489] 06 00000037`4cfff690 00007ffc`cc0a1a5b TerminalControl!winrt::Microsoft::Terminal::TerminalControl::implementation::TermControl::RenderEngineSwapChainChanged+0x45 [E:\BA\193\s\src\cascadia\TerminalControl\TermControl.cpp @ 506] ```
claunia commented 2026-01-31 00:58:53 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 1, 2020):

UGH YOU ALREADY DID THAT PART TOO okay i'm stopping

@DHowett-MSFT commented on GitHub (Apr 1, 2020): UGH YOU ALREADY DID THAT PART TOO okay i'm stopping
claunia commented 2026-01-31 00:58:53 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5225, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5225, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Tag-Fix Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7243
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?