starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Restoring a maximized Terminal with an auto-hide taskbar hides the taskbar #7246

New Issue
Closed
opened 2026-01-31 00:58:54 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 00:58:54 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 1, 2020).

I have v0.10.781.0 installed. The issue seems to have been partially fixed. After minimizing then maximizing again the issue returns.

Originally posted by @ARabinovich in https://github.com/microsoft/terminal/issues/1438#issuecomment-607372266

Originally created by @zadjii-msft on GitHub (Apr 1, 2020). I have v0.10.781.0 installed. The issue seems to have been partially fixed. After minimizing then maximizing again the issue returns. _Originally posted by @ARabinovich in https://github.com/microsoft/terminal/issues/1438#issuecomment-607372266_
claunia commented 2026-01-31 00:58:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 1, 2020):

Found the bug.
a12a6285f5/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (L366-L371)

When we're restoring from minimized, that MonitorFromWindow call is returning null. Curious that we're getting null here, when MSDN states:

If the window is currently minimized, MonitorFromWindow uses the rectangle of the window before it was minimized.

Hopefully MONITOR_DEFAULTTONEAREST might just fix this? Otherwise we could manually cache the window pos when we minimize...

EDIT: It did.

@zadjii-msft commented on GitHub (Apr 1, 2020): Found the bug. https://github.com/microsoft/terminal/blob/a12a6285f54a02309da930c7de0682c2d44cf243/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L366-L371 When we're restoring from minimized, that `MonitorFromWindow` call is returning null. Curious that we're getting null here, when MSDN states: > If the window is currently minimized, MonitorFromWindow uses the rectangle of the window before it was minimized. Hopefully `MONITOR_DEFAULTTONEAREST` might just fix this? Otherwise we could manually cache the window pos when we minimize... EDIT: It did.
claunia commented 2026-01-31 00:58:56 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 22, 2020):

:tada:This issue was addressed in #5213, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.🎉

Handy links:

@ghost commented on GitHub (Apr 22, 2020): :tada:This issue was addressed in #5213, which has now been successfully released as `Windows Terminal Preview v0.11.1121.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1121.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Triage Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?