starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

The documentation lacks information about NuGet. #7282

New Issue
Closed
opened 2026-01-31 00:59:56 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 00:59:56 +00:00
Owner
Copy Link

Originally created by @jarkkojs on GitHub (Apr 5, 2020).

The documentation does not instruct to do nuget restore as part of the compilation steps.

Originally created by @jarkkojs on GitHub (Apr 5, 2020). The documentation does not instruct to do `nuget restore` as part of the compilation steps.
claunia commented 2026-01-31 00:59:58 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 5, 2020):

This is because the default configuration of Visual Studio 2019 is to restore packages before building the solution, and some of the build scripts that are recommended in the readme do so as well.

@DHowett-MSFT commented on GitHub (Apr 5, 2020): This is because the default configuration of Visual Studio 2019 is to restore packages before building the solution, and some of the build scripts that _are_ recommended in the readme do so as well.
claunia commented 2026-01-31 00:59:58 +00:00
Author
Owner
Copy Link

@jarkkojs commented on GitHub (Apr 5, 2020):

I took the PS route:

Import-Module .\tools\OpenConsole.psm1
Set-MsBuildDevEnvironment
Invoke-OpenConsoleBuild

nuget restore fixed the issue.

What did I get wrong?

@jarkkojs commented on GitHub (Apr 5, 2020): I took the PS route: ``` Import-Module .\tools\OpenConsole.psm1 Set-MsBuildDevEnvironment Invoke-OpenConsoleBuild ``` `nuget restore` fixed the issue. What did I get wrong?
claunia commented 2026-01-31 00:59:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 6, 2020):

I'm not sure that you did anything wrong - Invoke-OpenConsoleBuild looks like it's supposed to call nuget restore

4f8acb4b9f/tools/OpenConsole.psm1 (L256-L260)

Did you happen to see any errors like "Error parsing solution file", or any errors related to nuget in the initial build that failed?

@zadjii-msft commented on GitHub (Apr 6, 2020): I'm not sure that you did anything wrong - `Invoke-OpenConsoleBuild` looks like it's supposed to call `nuget restore` https://github.com/microsoft/terminal/blob/4f8acb4b9fbd61196d0a5287749a58abe0fbaa28/tools/OpenConsole.psm1#L256-L260 Did you happen to see any errors like "Error parsing solution file", or any errors related to `nuget` in the initial build that failed?
claunia commented 2026-01-31 00:59:58 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 10, 2020):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Apr 10, 2020): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 00:59:58 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Apr 10, 2020):

We also need to document how we're even using Nuget in this project.

@WSLUser commented on GitHub (Apr 10, 2020): We also need to document how we're even using Nuget in this project.
claunia commented 2026-01-31 00:59:59 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 10, 2020):

And why is that? We're using it for packages.

@DHowett-MSFT commented on GitHub (Apr 10, 2020): And why is that? We're using it for packages.
claunia commented 2026-01-31 00:59:59 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Apr 10, 2020):

Indeed but what Nuget packages are in use? I can't even find most of the deps available through the public Nuget feed. We also aren't creating a .net app either. It seems like our deps are supposed to update through this method but they weren't created with .net in mind and we utilize them in C++. It's just a bit confusing on how all the pieces fit together. Maybe if we had a more detailed design flow schematic in the docs, this would be a bit more clear for contributors.

@WSLUser commented on GitHub (Apr 10, 2020): Indeed but what Nuget packages are in use? I can't even find most of the deps available through the public Nuget feed. We also aren't creating a .net app either. It seems like our deps are supposed to update through this method but they weren't created with .net in mind and we utilize them in C++. It's just a bit confusing on how all the pieces fit together. Maybe if we had a more detailed design flow schematic in the docs, this would be a bit more clear for contributors.
claunia commented 2026-01-31 00:59:59 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 14, 2020):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Apr 14, 2020): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Docs Needs-Author-Feedback Needs-Tag-Fix Needs-Triage No-Recent-Activity
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?