starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash in ScrollConsoleScreenBuffer when destination coordinates overflow #7324

New Issue
Closed
opened 2026-01-31 01:01:06 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 01:01:06 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Apr 7, 2020).

Originally assigned to: @lhecker on GitHub.

Environment

Windows build number: Version 10.0.18362.657

Steps to reproduce

Compile and run the following C++ code in a conhost cmd shell:

#include <windows.h>

void main() {
    SMALL_RECT rect = {0, 0, 40, 0};
    COORD dest = {32767, 0};
    CHAR_INFO fill = {L'X', 0x07};
    HANDLE output = GetStdHandle(STD_OUTPUT_HANDLE);
    ScrollConsoleScreenBufferW(output, &rect, NULL, dest, &fill);
}

Expected behavior

The first 40 characters of the first line should fill with X's.

Actual behavior

The console crashes.

When the ScrollRegion function is copying the area that is being scrolled, the _CopyRectangle function makes use of the Viewport::WalkInBoundsCircular method, and that fails when the target position goes out of bounds. See here:

5de9fa9cf3/src/types/viewport.cpp (L411)

Originally created by @j4james on GitHub (Apr 7, 2020). Originally assigned to: @lhecker on GitHub. # Environment Windows build number: Version 10.0.18362.657 # Steps to reproduce Compile and run the following C++ code in a conhost cmd shell: ```cpp #include <windows.h> void main() { SMALL_RECT rect = {0, 0, 40, 0}; COORD dest = {32767, 0}; CHAR_INFO fill = {L'X', 0x07}; HANDLE output = GetStdHandle(STD_OUTPUT_HANDLE); ScrollConsoleScreenBufferW(output, &rect, NULL, dest, &fill); } ``` # Expected behavior The first 40 characters of the first line should fill with X's. # Actual behavior The console crashes. When the `ScrollRegion` function is copying the area that is being scrolled, the `_CopyRectangle` function makes use of the `Viewport::WalkInBoundsCircular` method, and that fails when the target position goes out of bounds. See here: https://github.com/microsoft/terminal/blob/5de9fa9cf375e9b5bdc582d8d166604eeb519844/src/types/viewport.cpp#L411
claunia commented 2026-01-31 01:01:08 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Apr 7, 2020):

FYI, I've just tested with the first open source release (commit d4d59fa339), and the bug was already present there. However, the legacy console doesn't have this issue.

In some ways this is could be considered a part of issue #4153, but I thought it worth raising separately because of the crash, and the fact that it's not obviously "safe math" code.

@j4james commented on GitHub (Apr 7, 2020): FYI, I've just tested with the first open source release (commit d4d59fa3395012ca37ba12665da4ec11c7dcf9cb), and the bug was already present there. However, the legacy console doesn't have this issue. In some ways this is could be considered a part of issue #4153, but I thought it worth raising separately because of the crash, and the fact that it's not obviously "safe math" code.
claunia commented 2026-01-31 01:01:08 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 7, 2020):

Regressed between RS5 (17763) and 19H1 (18362). Thanks!

@DHowett-MSFT commented on GitHub (Apr 7, 2020): Regressed between RS5 (17763) and 19H1 (18362). Thanks!
claunia commented 2026-01-31 01:01:08 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 8, 2020):

Off triage, P2, /cc @miniksa for a conhost regression from the scrolling change in 19H1

@DHowett-MSFT commented on GitHub (Apr 8, 2020): Off triage, P2, /cc @miniksa for a conhost regression from the scrolling change in 19H1
claunia commented 2026-01-31 01:01:09 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 25, 2022):

:tada:This issue was addressed in #12669, which has now been successfully released as Windows Terminal v1.12.1073.🎉

Handy links:

@ghost commented on GitHub (Mar 25, 2022): :tada:This issue was addressed in #12669, which has now been successfully released as `Windows Terminal v1.12.1073`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.12.1073) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 01:01:09 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 25, 2022):

:tada:This issue was addressed in #12669, which has now been successfully released as Windows Terminal Preview v1.13.1073.🎉

Handy links:

@ghost commented on GitHub (Mar 25, 2022): :tada:This issue was addressed in #12669, which has now been successfully released as `Windows Terminal Preview v1.13.1073`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.1073) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Impact-Correctness Issue-Bug Priority-1 Product-Conhost Resolution-Fix-Committed Severity-Crash zInbox-Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7324
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?