ColorTool does not resolve schemes properly, and does not work with WSL paths #7373

Closed
opened 2026-01-31 01:02:13 +00:00 by claunia · 3 comments
Owner

Originally created by @johnazariah on GitHub (Apr 12, 2020).

Environment

10.0.18363.0

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Ubuntu on WSL

Steps to reproduce

  • on Windows Command Shell/PowerShell/GitBash
    • running ColorTool.exe <schemename> (without extension) does not resolve the scheme
    • running ColorTool.exe <schemename.extension> resolves the scheme correctly.

This behaviour is contrary to the advertised behaviour, which says that the scheme will be resolved trying a specific order of extensions

  • on Ubuntu bash running in WSL
    • running ColorTool.exe -x <schemename> (without extension) does not resolve the scheme
    • running ColorTool.exe -x <schemename.extension> does not resolve the scheme and throws exceptions.

This behaviour is also not the expected behaviour.

Expected behavior

ColorTool.exe OneHalfDark should have the same behaviour as ColorTool.exe OneHalfDark.itermcolors, and should actually load the terminal colors on both Windows shells and WSL shells

Actual behavior

before
before-wsl

Originally created by @johnazariah on GitHub (Apr 12, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment 10.0.18363.0 ```none Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] Windows Terminal version (if applicable): Any other software? ``` Ubuntu on WSL # Steps to reproduce - on Windows Command Shell/PowerShell/GitBash * running `ColorTool.exe <schemename>` (without extension) does not resolve the scheme * running `ColorTool.exe <schemename.extension>` resolves the scheme correctly. This behaviour is contrary to the advertised behaviour, which says that the scheme will be resolved trying a specific order of extensions - on Ubuntu bash running in WSL * running `ColorTool.exe -x <schemename>` (without extension) does not resolve the scheme * running `ColorTool.exe -x <schemename.extension>` does not resolve the scheme and throws exceptions. This behaviour is also not the expected behaviour. <!-- A description of how to trigger this bug. --> # Expected behavior `ColorTool.exe OneHalfDark` should have the same behaviour as `ColorTool.exe OneHalfDark.itermcolors`, and should actually load the terminal colors on both Windows shells and WSL shells <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> # Actual behavior <!-- What's actually happening? --> ![before](https://user-images.githubusercontent.com/830311/79059824-3b66f180-7c33-11ea-80f0-fb1686eb0876.JPG) ![before-wsl](https://user-images.githubusercontent.com/830311/79059826-402ba580-7c33-11ea-8f1a-87a3cbe8e8fb.JPG)
Author
Owner

@DHowett-MSFT commented on GitHub (Apr 12, 2020):

It looks like this might be because your color schemes are in the WSL-only part of the filesystem. We haven’t yet done the compatibility work required to make sure ColorTool can use the new \\wsl$ redirector paths from Windows 19H1.

@DHowett-MSFT commented on GitHub (Apr 12, 2020): It looks like this might be because your color schemes are in the WSL-only part of the filesystem. We haven’t yet done the compatibility work required to make sure ColorTool can use the new `\\wsl$` redirector paths from Windows 19H1.
Author
Owner

@johnazariah commented on GitHub (Apr 12, 2020):

Thanks, @DHowett-MSFT

I've put it a fix that works in my test cases...

https://github.com/microsoft/terminal/pull/5327
after
after-wsl

Hope this helps :)

@johnazariah commented on GitHub (Apr 12, 2020): Thanks, @DHowett-MSFT I've put it a fix that works in my test cases... https://github.com/microsoft/terminal/pull/5327 ![after](https://user-images.githubusercontent.com/830311/79060162-859da200-7c36-11ea-9ed2-02b47459b88d.JPG) ![after-wsl](https://user-images.githubusercontent.com/830311/79060166-87fffc00-7c36-11ea-9b2b-3993bca992f6.JPG) Hope this helps :)
Author
Owner

@DHowett-MSFT commented on GitHub (Apr 17, 2020):

Thanks for submitting a fix! We're a little behind on pull request reviews right now, but I'll tag this bug up properly in the meantime.

@DHowett-MSFT commented on GitHub (Apr 17, 2020): Thanks for submitting a fix! We're a little behind on pull request reviews right now, but I'll tag this bug up properly in the meantime.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7373