starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

SGR 0 doesn't work correctly when combined with meta attributes #7398

New Issue
Closed
opened 2026-01-31 01:02:54 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:02:54 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Apr 13, 2020).

Environment

Windows build number: Version 10.0.18362.657
Windows Terminal version (if applicable): Commit ea1bb2ed93

Steps to reproduce

From a bash shell in conhost, execute the following command:

printf "\e[0;7mReverse\e[0;4mUnderline\e[m\n"

Expected behavior

It should display the first word with reversed video, and the second word underlined.

For example, here's what it looks like in mintty:

image

Actual behavior

The SGR 0 in the second sequence doesn't take effect, so the second word is both underlined and reversed.

image

Originally created by @j4james on GitHub (Apr 13, 2020). # Environment Windows build number: Version 10.0.18362.657 Windows Terminal version (if applicable): Commit ea1bb2ed9359fcc6ded32ad11a8cab544b91ae0e # Steps to reproduce From a bash shell in conhost, execute the following command: printf "\e[0;7mReverse\e[0;4mUnderline\e[m\n" # Expected behavior It should display the first word with reversed video, and the second word underlined. For example, here's what it looks like in mintty: ![image](https://user-images.githubusercontent.com/4181424/79155064-7cdcd580-7dc8-11ea-9ab4-a8a6a919b3d5.png) # Actual behavior The `SGR 0` in the second sequence doesn't take effect, so the second word is both underlined and reversed. ![image](https://user-images.githubusercontent.com/4181424/79155101-89612e00-7dc8-11ea-9799-42defc72c26f.png)
claunia commented 2026-01-31 01:02:55 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Apr 13, 2020):

I should mention that I'm currently experimenting with a refactor of the SGR code, based on a discussion we had in PR https://github.com/microsoft/terminal/pull/3160#discussion_r341249386. That refactoring actually fixes this bug (which is how I discovered it in the first place), but it's still a work in progress, and may be in that state for a while. However, if there is an urgent need for this to be fixed I can probably put together a simpler PR targetting just this bug.

@j4james commented on GitHub (Apr 13, 2020): I should mention that I'm currently experimenting with a refactor of the SGR code, based on a discussion we had in PR https://github.com/microsoft/terminal/pull/3160#discussion_r341249386. That refactoring actually fixes this bug (which is how I discovered it in the first place), but it's still a work in progress, and may be in that state for a while. However, if there is an urgent need for this to be fixed I can probably put together a simpler PR targetting just this bug.
claunia commented 2026-01-31 01:02:55 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 14, 2020):

No need for a rush fix on this one. I'll yank the triage tag off (and leave it in 21H1). Thanks for being our VT champion!

@DHowett-MSFT commented on GitHub (Apr 14, 2020): No need for a rush fix on this one. I'll yank the triage tag off (and leave it in 21H1). Thanks for being our VT champion!
claunia commented 2026-01-31 01:02:55 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jun 18, 2020):

:tada:This issue was addressed in #5758, which has now been successfully released as Windows Terminal Preview v1.1.1671.0.🎉

Handy links:

@ghost commented on GitHub (Jun 18, 2020): :tada:This issue was addressed in #5758, which has now been successfully released as `Windows Terminal Preview v1.1.1671.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.1.1671.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Needs-Tag-Fix Priority-2 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7398
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?