starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Lines that wrap on space characters at the bottom of the buffer (“new bottom line”) receive an extra line break #7446

New Issue
Closed
opened 2026-01-31 01:04:19 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:04:19 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Apr 17, 2020).

Originally assigned to: @DHowett-MSFT on GitHub.

With 0.11.xxx selfhost builds, The following steps reliably result in visual corruption (and also drove me a little crazy!)

  1. Terminal width = 120
  2. Go to the terminal source tree
  3. git blame 862793299a src/types/UiaTextRangeBase.cpp
  4. Search for GetTextRects using /:
    • /GetTextRects<CR>
  5. Go to the next match, using n.
  6. Notice that GetTextRects, which should be on the top line, is gone.
  7. Move right, left (arrow keys), and notice that it reappears.

bad

image

good

image

If you look at the bad image, I highlighted two things that caught my eye. Those are lines that have spaces in column 121, before less hard wraps them (!) I don't have 121 columns ...

Confirmed this in a text editor with the debug tap. I highlighted in blue the same regions that caused a break here.

The vertical strip under the cursor (look for the blue boxes) indicates column 121. Most of the escape sequences for cursor movement start here, but in the boxed areas they're not escapes.

image

Is this the exact wrap issue? Except with conpty sending spaces instead?

Originally created by @DHowett-MSFT on GitHub (Apr 17, 2020). Originally assigned to: @DHowett-MSFT on GitHub. With 0.11.xxx selfhost builds, The following steps reliably result in visual corruption (and also drove me a little crazy!) 1. Terminal width = 120 2. Go to the terminal source tree 3. `git blame 862793299a src/types/UiaTextRangeBase.cpp` 4. Search for `GetTextRects` using `/`: * `/GetTextRects<CR>` 5. Go to the next match, using `n`. 6. Notice that `GetTextRects`, which should be on the top line, is _gone_. 7. Move right, left (arrow keys), and notice that it reappears. ### bad ![image](https://user-images.githubusercontent.com/14316954/79520213-0976d600-800b-11ea-9468-5c24ddb10bce.png) ### good ![image](https://user-images.githubusercontent.com/14316954/79520220-0f6cb700-800b-11ea-8e1d-52b506a3d06f.png) If you look at the bad image, I highlighted two things that caught my eye. Those are lines that have spaces _in column 121_, before `less` hard wraps them (!) I don't have 121 columns ... Confirmed this in a text editor with the debug tap. I highlighted in blue the same regions that caused a break here. The vertical strip under the cursor (look for the blue boxes) indicates column _121_. Most of the escape sequences for cursor movement start here, but in the boxed areas they're not escapes. ![image](https://user-images.githubusercontent.com/14316954/79520364-78ecc580-800b-11ea-813b-5b006599ab3c.png) Is this the exact wrap issue? Except with conpty sending spaces instead?
claunia commented 2026-01-31 01:04:21 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 17, 2020):

issue_5386_tap.txt

@DHowett-MSFT commented on GitHub (Apr 17, 2020): [issue_5386_tap.txt](https://github.com/microsoft/terminal/files/4490393/issue_5386_tap.txt)
claunia commented 2026-01-31 01:04:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 17, 2020):

I'm not sure, but I can take a look Monday? Unless you think this should interrupt the DX work I'm on now.

Either this is exact wrap, or more likely, this is an exclusive/inclusive thing. There's one spot in PaintBufferLine that's always been an ExclusiveRight that I've always thought should be an InclusiveRight, and maybe the other conpty changes finally broke that line.

@zadjii-msft commented on GitHub (Apr 17, 2020): I'm not sure, but I can take a look Monday? Unless you think this should interrupt the DX work I'm on now. Either this is exact wrap, or more likely, this is an exclusive/inclusive thing. There's one spot in `PaintBufferLine` that's always been an `ExclusiveRight` that I've always thought should be an `InclusiveRight`, and maybe the other conpty changes finally broke that line.
claunia commented 2026-01-31 01:04:21 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 17, 2020):

Got this down to a perfect repo.

  1. New bottom line
  2. Print width-1 chars followed by a space
  3. Print something else

ConPTY will duplicate the single space into two spaces, causing a wrap on the Terminal side.

@DHowett-MSFT commented on GitHub (Apr 17, 2020): Got this down to a perfect repo. 1. New bottom line 2. Print width-1 chars followed by a space 3. Print something else ConPTY will duplicate the single space into two spaces, causing a wrap on the Terminal side.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Issue-Bug Priority-1 Product-Conpty Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7446
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?