starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

A11y_Windows Terminal_Settings_Non text Contrast: For "Plus(+)" and "Drop down" buttons the non text contrast ratio is not meeting 3:1 ratio #7458

New Issue
Closed
opened 2026-01-31 01:04:37 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 01:04:37 +00:00
Owner
Copy Link

Originally created by @SpandanaPaladi on GitHub (Apr 17, 2020).

#A11y_WindowsTerminal; #WindowsTerminal; #A11yWCAG2.1; #A11yTCS; #DesktopApp; #Win10 ; #C+E-H; #NonTextContrast; #A11ySev2; #BenchMark; #MAS1.4.11

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier

Environment Details:
Version: 0.10.781.0

Repro steps:

  1. Hit the URL ""aka.ms/terminal"" and install ""Windows terminal (Preview)"" application
  2. Open ""Windows terminal (Preview)"" application
  3. Open the "Accessibility insights" tool to check color contrast ratio
  4. Tab to ""Windows Powershell"" tab
  5. Tab till "plus(+)" button and "Drop down" button
  6. Verify whether the color contrast ratio for "Plus(+)" and "drop down" buttons are meeting 3:1 contrast ratio using the "Accessibility insights" tool

Actual Result:​
Both the "Plus(+) and "Drop down" buttons are not meeting the non text contrast ratio 3:1 ratio
​
Expected Result:​
Both the "Plus(+) and "Drop down" buttons should meet the non text contrast ratio 3:1 ratio
​
User Impact:​
Low vision users will face difficulty if the buttons don't meet the non text contrast ratio 3:1
MAS Reference:​
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/Doc.aspx?sourcedoc=%7B6CA3BF14-2635-434A-832C-28DD9A18B9FC%7D&file=MAS%201.4.11%20%E2%80%93%20Non-text%20Contrast.docx&action=default&mobileredirect=true&cid=ab731ae2-c015-4cce-8636-dda5170eef34

Bug_plus button non text contrast
Bug_drop down non text contrast

Originally created by @SpandanaPaladi on GitHub (Apr 17, 2020). #A11y_WindowsTerminal; #WindowsTerminal; #A11yWCAG2.1; #A11yTCS; #DesktopApp; #Win10 ; #C+E-H; #NonTextContrast; #A11ySev2; #BenchMark; #MAS1.4.11 [Check out Accessibility Insights!](https://nam06.safelinks.protection.outlook.com/?url=https://accessibilityinsights.io/&data=02%7c01%7cv-shcha1%40microsoft.com%7cb67b2c4b646d4f9561a208d6f4b5c39b%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c636965458847087032&sdata=uWx6cTEfazn%2BoCV3cL1iYB4KN%2BuXQ/MTlmOVec%2BZgKc%3D&reserved=0) - Identify accessibility bugs before check-in and make bug fixing faster and easier **Environment Details:** Version: 0.10.781.0 **Repro steps:** 1. Hit the URL ""aka.ms/terminal"" and install ""Windows terminal (Preview)"" application 2. Open ""Windows terminal (Preview)"" application 3. Open the "Accessibility insights" tool to check color contrast ratio 4. Tab to ""Windows Powershell"" tab 5. Tab till "plus(+)" button and "Drop down" button 6. Verify whether the color contrast ratio for "Plus(+)" and "drop down" buttons are meeting 3:1 contrast ratio using the "Accessibility insights" tool **Actual Result:​** Both the "Plus(+) and "Drop down" buttons are not meeting the non text contrast ratio 3:1 ratio ​ **Expected Result:​** Both the "Plus(+) and "Drop down" buttons should meet the non text contrast ratio 3:1 ratio ​ **User Impact:​** Low vision users will face difficulty if the buttons don't meet the non text contrast ratio 3:1 **MAS Reference:​** https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/Doc.aspx?sourcedoc=%7B6CA3BF14-2635-434A-832C-28DD9A18B9FC%7D&file=MAS%201.4.11%20%E2%80%93%20Non-text%20Contrast.docx&action=default&mobileredirect=true&cid=ab731ae2-c015-4cce-8636-dda5170eef34 ![Bug_plus button non text contrast](https://user-images.githubusercontent.com/63839131/79557454-346f3180-80c0-11ea-95a9-cdbe2b9696bb.png) ![Bug_drop down non text contrast](https://user-images.githubusercontent.com/63839131/79557481-40f38a00-80c0-11ea-8099-ec8ea47c9d9f.png)
claunia commented 2026-01-31 01:04:38 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Apr 29, 2020):

We just use the built-in resources from the WinUI Theme Dictionary. Submitted the following issue on the WinUI repo:
https://github.com/microsoft/microsoft-ui-xaml/issues/2353

@carlos-zamora commented on GitHub (Apr 29, 2020): We just use the built-in resources from the WinUI Theme Dictionary. Submitted the following issue on the WinUI repo: https://github.com/microsoft/microsoft-ui-xaml/issues/2353
claunia commented 2026-01-31 01:04:38 +00:00
Author
Owner
Copy Link

@Amulya-95 commented on GitHub (May 14, 2020):

Regressed in latest environment, still able issue is not fixed. We will take action and close the bug, once the issue gets resolved.

Attachments:

Bug 5392_Dropdown_Non text contrast

Bug 5392_Non text contrast issue

@Amulya-95 commented on GitHub (May 14, 2020): Regressed in latest environment, still able issue is not fixed. We will take action and close the bug, once the issue gets resolved. **Attachments:** ![Bug 5392_Dropdown_Non text contrast](https://user-images.githubusercontent.com/51435266/81951074-5954b700-9622-11ea-8aca-bd972cf56bd9.png) ![Bug 5392_Non text contrast issue](https://user-images.githubusercontent.com/51435266/81951092-5f4a9800-9622-11ea-9e19-ce56de379961.png)
claunia commented 2026-01-31 01:04:38 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (May 19, 2020):

@Amulya-95 as I said above, we're just using WinUI's resources here. Can we close this in favor of the attached WinUI issue?

CC @DHowett-MSFT

@carlos-zamora commented on GitHub (May 19, 2020): @Amulya-95 as I said above, we're just using WinUI's resources here. Can we close this in favor of the attached WinUI issue? CC @DHowett-MSFT
claunia commented 2026-01-31 01:04:38 +00:00
Author
Owner
Copy Link

@Amulya-95 commented on GitHub (Jun 5, 2020):

#1901 still in Active (open) state.

As per C&AI External bug process we will take action on this bug once the external bug is fixed and verified

@Amulya-95 commented on GitHub (Jun 5, 2020): [#1901](https://github.com/microsoft/microsoft-ui-xaml/issues/1901) still in Active (open) state. As per [C&AI External bug process](https://microsoft.sharepoint.com/teams/ceacc/SitePages/External-Bug-process.aspx) we will take action on this bug once the external bug is fixed and verified
claunia commented 2026-01-31 01:04:38 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 4, 2022):

image
image

(it can't auto-detect the colors for the split button, so I picked them manually)

I believe this was fixed at some point in the past, likely when we updated a MUX version (unclear which).

I also think we've got a new a11y team now so I'm gonna close this one out.

@zadjii-msft commented on GitHub (Jan 4, 2022): ![image](https://user-images.githubusercontent.com/18356694/148084772-413f254e-5f8b-4b0e-b622-68d7f8422d8a.png) ![image](https://user-images.githubusercontent.com/18356694/148085044-56ed5438-4fb8-4d9c-87d2-f9f86fda31d2.png) (it can't auto-detect the colors for the split button, so I picked them manually) I believe this was fixed at some point in the past, likely when we updated a MUX version (unclear which). I also think we've got a new a11y team now so I'm gonna close this one out.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Area-UserInterface Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Tracking-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7458
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?