starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

A11y_Windows Terminal_About_Color Contrast: Links present in the "About" pop up window and the text to the back ground color in the "ok" button are not meeting the color contrast ratio 4.5:1 #7463

New Issue
Closed
opened 2026-01-31 01:04:46 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:04:46 +00:00
Owner
Copy Link

Originally created by @SpandanaPaladi on GitHub (Apr 17, 2020).

#A11y_WindowsTerminal; #WindowsTerminal; #A11yMAS; #A11yTCS; #DesktopApp; #Win10; #C+E-H; #ColorContrast; #A11ySev2; #NonBenchMark; #MAS1.4.3

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier

Environment Details:
Version: 0.10.781.0

Repro steps:

  1. Hit the URL ""aka.ms/terminal"" and install ""Windows terminal (Preview)"" application
  2. Open ""Windows terminal (Preview)"" application
  3. Open the "Accessibility insights" tool to check color contrast ratio
  4. Tab to "Dropdown" control and press enter or use "Ctrl + Shift + Space"
  5. Tab till "About" and press enter
  6. Verify whether the links and the text to the back ground color in the "OK" button are meeting the color contrast ratio 4.5:1 or not

Actual Result:
The links present in the "About" pop up window and the text to the back ground color in the "OK" button are not meeting the color contrast ratio 4.5:1​

Expected Result:​
The links present in the "About" pop up window and the text to the back ground color in the "OK" button should meet the color contrast ratio 4.5:1
​
User Impact:​
Low vision users will face difficulty in viewing the content if the Color Contrast ratio fails to meet 4.5:1 ratio for links and text to the back ground color in the "OK" button

MAS Reference:​
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6}

Bug_links in about popup not meeting color contrast ratio
Bug_text to the back ground color not meeting color contrast ratio

Originally created by @SpandanaPaladi on GitHub (Apr 17, 2020). #A11y_WindowsTerminal; #WindowsTerminal; #A11yMAS; #A11yTCS; #DesktopApp; #Win10; #C+E-H; #ColorContrast; #A11ySev2; #NonBenchMark; #MAS1.4.3 [Check out Accessibility Insights!](https://nam06.safelinks.protection.outlook.com/?url=https://accessibilityinsights.io/&data=02%7c01%7cv-shcha1%40microsoft.com%7cb67b2c4b646d4f9561a208d6f4b5c39b%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c636965458847087032&sdata=uWx6cTEfazn%2BoCV3cL1iYB4KN%2BuXQ/MTlmOVec%2BZgKc%3D&reserved=0) - Identify accessibility bugs before check-in and make bug fixing faster and easier **Environment Details:** Version: 0.10.781.0 **Repro steps:** 1. Hit the URL ""aka.ms/terminal"" and install ""Windows terminal (Preview)"" application 2. Open ""Windows terminal (Preview)"" application 3. Open the "Accessibility insights" tool to check color contrast ratio 4. Tab to "Dropdown" control and press enter or use "Ctrl + Shift + Space" 5. Tab till "About" and press enter 6. Verify whether the links and the text to the back ground color in the "OK" button are meeting the color contrast ratio 4.5:1 or not **Actual Result:** The links present in the "About" pop up window and the text to the back ground color in the "OK" button are not meeting the color contrast ratio 4.5:1​ **Expected Result:​** The links present in the "About" pop up window and the text to the back ground color in the "OK" button should meet the color contrast ratio 4.5:1 ​ **User Impact:​** Low vision users will face difficulty in viewing the content if the Color Contrast ratio fails to meet 4.5:1 ratio for links and text to the back ground color in the "OK" button **MAS Reference:​** https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6} ![Bug_links in about popup not meeting color contrast ratio](https://user-images.githubusercontent.com/63839131/79574860-6d1e0380-80de-11ea-8c09-203e39cf2c65.png) ![Bug_text to the back ground color not meeting color contrast ratio](https://user-images.githubusercontent.com/63839131/79575172-01886600-80df-11ea-9db6-aacf8f5cd4fc.png)
claunia commented 2026-01-31 01:04:47 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Apr 17, 2020):

Isn't this down to the choice of Accent colour in the system?

@mdtauk commented on GitHub (Apr 17, 2020): Isn't this down to the choice of Accent colour in the system?
claunia commented 2026-01-31 01:04:47 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Apr 29, 2020):

We just use the built-in ContentDialog from the WinUI Theme Dictionary. Submitted the following issue on the WinUI repo:
https://github.com/microsoft/microsoft-ui-xaml/issues/2354

@carlos-zamora commented on GitHub (Apr 29, 2020): We just use the built-in ContentDialog from the WinUI Theme Dictionary. Submitted the following issue on the WinUI repo: https://github.com/microsoft/microsoft-ui-xaml/issues/2354
claunia commented 2026-01-31 01:04:47 +00:00
Author
Owner
Copy Link

@Amulya-95 commented on GitHub (May 14, 2020):

Regressed the bug in latest environment. The issue is resolved, controls have color contrast ratio equal to 4.5:1. Hence closing this bug.
Please find the attachments for reference.

Attachments:
Fixed Bug 5395_Color contrast ratio passes for links

Fixed Bug 5395_Note section

@Amulya-95 commented on GitHub (May 14, 2020): Regressed the bug in latest environment. The issue is resolved, controls have color contrast ratio equal to 4.5:1. Hence closing this bug. Please find the attachments for reference. **Attachments:** ![Fixed Bug 5395_Color contrast ratio passes for links](https://user-images.githubusercontent.com/51435266/81946639-3c69b500-961d-11ea-92c6-11dcb4c6e2bb.png) ![Fixed Bug 5395_Note section](https://user-images.githubusercontent.com/51435266/81946508-0fb59d80-961d-11ea-87ac-dff903c397e7.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Area-UserInterface Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7463
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?