starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

A11y_Windows Terminal_Close Window_Color contrast: Color contrast ratio for 'Close all' button is less than 4.5:1 ratio #7509

New Issue
Closed
opened 2026-01-31 01:05:44 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 01:05:44 +00:00
Owner
Copy Link

Originally created by @Amulya-95 on GitHub (Apr 20, 2020).

GitHubTags: #A11y_WindowsTerminal; #WindowsTerminal; #A11yTCS; #A11yMAS; #Win10; #DesktopApp; #ColorContrast; #MAS1.4.3; #C+E-H; #A11ySev2;

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier

Environment Details:
Windows Terminal
Version: 0.10.781.0
OS: Windows 10 (Version 1909, Build: 18363.778)

Repro Steps:
1.Hit the URL "aka.ms/terminal" and install "Windows terminal (Preview)" application
2.Open "Windows terminal (Preview)" application
3.Tab to multiple tabs
4.Use "Alt + F4" to close whole window and pop up will be displayed
5.Verify whether 'Close All" button color contrast ratio is greater or equal to 4.5:1

Actual Result:
Color contrast ratio for 'Close all' button is less than 4.5:1 ratio

Expected Result:
Color contrast ratio for 'Close all' button should be greater than or equal to 4.5:1 ratio

User Impact:
Low vision users will find difficulty, if the color contrast ratio is less than 4.5:1 ratio

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6}

Attachment:
Bug 5425_Color contrast ratio fails for 'Close All' button

Originally created by @Amulya-95 on GitHub (Apr 20, 2020). GitHubTags: #A11y_WindowsTerminal; #WindowsTerminal; #A11yTCS; #A11yMAS; #Win10; #DesktopApp; #ColorContrast; #MAS1.4.3; #C+E-H; #A11ySev2; [Check out Accessibility Insights!](https://nam06.safelinks.protection.outlook.com/?url=https://accessibilityinsights.io/&data=02%7c01%7cv-tagott%40microsoft.com%7cb67b2c4b646d4f9561a208d6f4b5c39b%7c72f988bf86f141af91ab2d7cd011db47%7c1%7c0%7c636965458847261333&sdata=PJMiKjb64uwhBN98LZpctnBiAVeOvw%2BLBrnxBtrjl2M%3D&reserved=0) - Identify accessibility bugs before check-in and make bug fixing faster and easier **Environment Details:** Windows Terminal Version: 0.10.781.0 OS: Windows 10 (Version 1909, Build: 18363.778) **Repro Steps:** 1.Hit the URL "aka.ms/terminal" and install "Windows terminal (Preview)" application 2.Open "Windows terminal (Preview)" application 3.Tab to multiple tabs 4.Use "Alt + F4" to close whole window and pop up will be displayed 5.Verify whether 'Close All" button color contrast ratio is greater or equal to 4.5:1 **Actual Result:** Color contrast ratio for 'Close all' button is less than 4.5:1 ratio **Expected Result:** Color contrast ratio for 'Close all' button should be greater than or equal to 4.5:1 ratio **User Impact:** Low vision users will find difficulty, if the color contrast ratio is less than 4.5:1 ratio **MAS Reference:** https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6} **Attachment:** ![Bug 5425_Color contrast ratio fails for 'Close All' button](https://user-images.githubusercontent.com/51435266/79754443-2ece5180-8335-11ea-9aff-ff104cc38b4d.png)
claunia commented 2026-01-31 01:05:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 20, 2020):

I'm pretty sure this is the same fundamental root as #5395 - these buttons are using the user-defined accent color. I'm not sure how we go about resolving this issue appropriately though.

@zadjii-msft commented on GitHub (Apr 20, 2020): I'm pretty sure this is the same fundamental root as #5395 - these buttons are using the user-defined accent color. I'm not sure how we go about resolving this issue appropriately though.
claunia commented 2026-01-31 01:05:48 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 20, 2020):

Turn on the high contrast mode

The screenshot of the application does not match any known configuration of "high contrast mode" on the Windows operating system. The "contrast analyser" application would appear to be high contrast if it were enabled on the operating system.

Is this bug report valid?

@DHowett-MSFT commented on GitHub (Apr 20, 2020): > Turn on the high contrast mode The screenshot of the application does not match any known configuration of "high contrast mode" on the Windows operating system. The "contrast analyser" application would appear to be high contrast if it were enabled on the operating system. Is this bug report valid?
claunia commented 2026-01-31 01:05:48 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Apr 20, 2020):

On high contrast mode, this dialog looks like:

image

There is strong contrast between the button text and the button background, as is required.

@DHowett-MSFT commented on GitHub (Apr 20, 2020): On high contrast mode, this dialog looks like: ![image](https://user-images.githubusercontent.com/14316954/79778415-8c3eb000-82ed-11ea-87fa-fcbb498f3670.png) There is strong contrast between the button text and the button background, as is required.
claunia commented 2026-01-31 01:05:48 +00:00
Author
Owner
Copy Link

@Amulya-95 commented on GitHub (May 5, 2020):

Fixed Bug 5425

Not able to reproduce the issue. color contrast ratio is equal to 4.5:1. Hence closing the bug.

@Amulya-95 commented on GitHub (May 5, 2020): ![Fixed Bug 5425](https://user-images.githubusercontent.com/51435266/81063131-e5653100-8ef4-11ea-909a-195c4a5181df.png) Not able to reproduce the issue. color contrast ratio is equal to 4.5:1. Hence closing the bug.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Area-UserInterface Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7509
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?