starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Fonts with programming ligatures show weird behavior #755

New Issue
Closed
opened 2026-01-30 22:02:37 +00:00 by claunia · 14 comments
claunia commented 2026-01-30 22:02:37 +00:00
Owner
Copy Link

Originally created by @MCorzo on GitHub (May 7, 2019).

When fonts with programming ligatures is used, a weird behavior is show if write some characters at first, for example with FiraCode.

image

image

Originally created by @MCorzo on GitHub (May 7, 2019). When fonts with programming ligatures is used, a weird behavior is show if write some characters at first, for example with [FiraCode](https://github.com/tonsky/FiraCode). ![image](https://user-images.githubusercontent.com/12452450/57310925-47a40f80-70b0-11e9-93a3-2cc251c618d6.png) ![image](https://user-images.githubusercontent.com/12452450/57310942-512d7780-70b0-11e9-94d3-5a57d5832d0e.png)
claunia commented 2026-01-30 22:02:38 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 7, 2019):

I mean, isn't that how ligatures normally work? They can't really tell the difference between system32>=some_cmd and if (system32>=foo)

@zadjii-msft commented on GitHub (May 7, 2019): I mean, isn't that how ligatures normally work? They can't really tell the difference between `system32>=some_cmd` and `if (system32>=foo)`
claunia commented 2026-01-30 22:02:39 +00:00
Author
Owner
Copy Link

@puco commented on GitHub (May 7, 2019):

Well, but maybe there should be some stop-character (by default?) that prevents a ligature in this case

@puco commented on GitHub (May 7, 2019): Well, but maybe there should be some stop-character (by default?) that prevents a ligature in this case
claunia commented 2026-01-30 22:02:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 7, 2019):

@puco Is there such a character?

If there is, then you could definitely add it to your prompt, with PROMPT $p$g<whatever the char is>.

However, that doesn't really seem like it's a solution that'll work for all cases

@zadjii-msft commented on GitHub (May 7, 2019): @puco Is there such a character? If there is, then you could definitely add it to your prompt, with `PROMPT $p$g<whatever the char is>`. However, that doesn't really seem like it's a solution that'll work for all cases
claunia commented 2026-01-30 22:02:39 +00:00
Author
Owner
Copy Link

@RichiCoder1 commented on GitHub (May 7, 2019):

I think you can use: https://en.wikipedia.org/wiki/Zero-width_non-joiner
According to the wiki, the intent is literally to stop ligatures from joining.

@RichiCoder1 commented on GitHub (May 7, 2019): I think you can use: https://en.wikipedia.org/wiki/Zero-width_non-joiner According to the wiki, the intent is literally to stop ligatures from joining.
claunia commented 2026-01-30 22:02:39 +00:00
Author
Owner
Copy Link

@vapier commented on GitHub (May 7, 2019):

fonts are free to define any arbitrary ligatures they want, so if you were to try to use a ZWNJ character to defeat the ligatures, then you'd have to insert them between every single character. which would probably then break logic related to graphemes when formed by multiple characters (e.g. separate jamo in korean hangul which should be presented as a single glyph).

in css, there is a font-variant-ligatures: none that you can use to disable ligature usage during font rendering. i'd assume that whatever font rendering engine used by the terminal would have a similar knob that could be turned ...

@vapier commented on GitHub (May 7, 2019): fonts are free to define any arbitrary ligatures they want, so if you were to try to use a ZWNJ character to defeat the ligatures, then you'd have to insert them between every single character. which would probably then break logic related to graphemes when formed by multiple characters (e.g. separate jamo in korean hangul which should be presented as a single glyph). in css, there is a [font-variant-ligatures: none](https://developer.mozilla.org/en-US/docs/Web/CSS/font-variant-ligatures) that you can use to disable ligature usage during font rendering. i'd assume that whatever font rendering engine used by the terminal would have a similar knob that could be turned ...
claunia commented 2026-01-30 22:02:40 +00:00
Author
Owner
Copy Link

@RichiCoder1 commented on GitHub (May 7, 2019):

To be clear, I was suggesting zwnj for the end of prompt by default. It would absolutely be a bad idea to use to remove ligatures everywhere.

@RichiCoder1 commented on GitHub (May 7, 2019): To be clear, I was suggesting zwnj for the end of prompt by default. It would absolutely be a bad idea to use to remove ligatures everywhere.
claunia commented 2026-01-30 22:02:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 7, 2019):

i'd assume that whatever font rendering engine used by the terminal would have a similar knob that could be turned ...

I believe this is something we could work with. I believe @miniksa already has a list of renderer knobs he's thinking about exposing as settings

@zadjii-msft commented on GitHub (May 7, 2019): > i'd assume that whatever font rendering engine used by the terminal would have a similar knob that could be turned ... I believe this _is_ something we could work with. I believe @miniksa already has a list of renderer knobs he's thinking about exposing as settings
claunia commented 2026-01-30 22:02:40 +00:00
Author
Owner
Copy Link

@Tyriar commented on GitHub (May 8, 2019):

This looks as designed to me, trying to do some trickery with ZWJ that only works in Windows Terminal sounds like the wrong direction. If you use ligatures and hit this often you should probably just change your prompt.

@Tyriar commented on GitHub (May 8, 2019): This looks as designed to me, trying to do some trickery with ZWJ that only works in Windows Terminal sounds like the wrong direction. If you use ligatures and hit this often you should probably just change your prompt.
claunia commented 2026-01-30 22:02:41 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 8, 2019):

what if we broke ligatures when we were overlaying the COOKED_READ data? That would solve it for CMD specifically ...

From: Daniel Imms notifications@github.com
Sent: Wednesday, May 8, 2019 8:15:50 AM
To: microsoft/Terminal
Cc: Subscribed
Subject: Re: [microsoft/Terminal] Fonts with programming ligatures show weird behavior (#514)

This looks as designed to me, trying to do some trickery with ZWJ that only works in Windows Terminal sounds like the wrong direction. If you use ligatures and hit this often you should probably just change your prompt.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F514%23issuecomment-490527963&data=01%7C01%7Cduhowett%40microsoft.com%7C4c6b0c3ae7184187320a08d6d3c80ea7%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=EtTyMXc0%2FgLyhZ1d9oPsKaaDjf0QrrmGKAPJVAhzOkk%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADNHLGSNVHPU6T2N3FR6U7DPULVCNANCNFSM4HLJZ6GQ&data=01%7C01%7Cduhowett%40microsoft.com%7C4c6b0c3ae7184187320a08d6d3c80ea7%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=w%2Blge7QO2CmIW%2BUbK8GZ5D2xmNQ7K17BgSbReA7xPsw%3D&reserved=0.

@DHowett-MSFT commented on GitHub (May 8, 2019): what if we broke ligatures when we were overlaying the COOKED_READ data? That would solve it for CMD specifically ... ________________________________ From: Daniel Imms <notifications@github.com> Sent: Wednesday, May 8, 2019 8:15:50 AM To: microsoft/Terminal Cc: Subscribed Subject: Re: [microsoft/Terminal] Fonts with programming ligatures show weird behavior (#514) This looks as designed to me, trying to do some trickery with ZWJ that only works in Windows Terminal sounds like the wrong direction. If you use ligatures and hit this often you should probably just change your prompt. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTerminal%2Fissues%2F514%23issuecomment-490527963&data=01%7C01%7Cduhowett%40microsoft.com%7C4c6b0c3ae7184187320a08d6d3c80ea7%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=EtTyMXc0%2FgLyhZ1d9oPsKaaDjf0QrrmGKAPJVAhzOkk%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADNHLGSNVHPU6T2N3FR6U7DPULVCNANCNFSM4HLJZ6GQ&data=01%7C01%7Cduhowett%40microsoft.com%7C4c6b0c3ae7184187320a08d6d3c80ea7%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=w%2Blge7QO2CmIW%2BUbK8GZ5D2xmNQ7K17BgSbReA7xPsw%3D&reserved=0>.
claunia commented 2026-01-30 22:02:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 8, 2019):

@DHowett-MSFT that's not a terrible idea, but I'm not sure how we could render that without sticking a fake ZWNJ in the buffer, or rendering that ZWNJ via conpty. It's certainly something that could be investigated, but I don't have high hopes it would work easily

@zadjii-msft commented on GitHub (May 8, 2019): @DHowett-MSFT that's not a terrible idea, but I'm not sure how we could render that without sticking a fake ZWNJ in the buffer, or rendering that ZWNJ via conpty. It's certainly something that could be investigated, but I don't have high hopes it would work easily
claunia commented 2026-01-30 22:02:41 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 14, 2019):

OK. This weird behavior, as is, is by design. I've created two follow-on issues to dig into the different proposals here as they're separate concerns. I'll close this one as is so other complaints can be duped here.

@miniksa commented on GitHub (May 14, 2019): OK. This weird behavior, as is, is by design. I've created two follow-on issues to dig into the different proposals here as they're separate concerns. I'll close this one as is so other complaints can be duped here.
claunia commented 2026-01-30 22:02:41 +00:00
Author
Owner
Copy Link

@Luuk34 commented on GitHub (Apr 27, 2020):

'Resolutin-By-Design'..... LOL, Design must be .... 👎

@Luuk34 commented on GitHub (Apr 27, 2020): 'Resolutin-By-Design'..... LOL, Design must be .... 👎
claunia commented 2026-01-30 22:02:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 27, 2020):

@Luuk34 This is literally the design of how ligatured fonts work. If you don't like ligatured fonts, then you're free to

  • pick any of the gazillions of fonts that are out there that don't have liagtured glyphs
  • wait for the next release to come out where we switch to "Cascadia Mono" (without ligatures) instead of "Cascadia Code" (with ligatures) (see #5505)
  • Help us implement settings for disabling ligatures #759

but comments like "Design must be .... 👎" aren't really constructive here.

@zadjii-msft commented on GitHub (Apr 27, 2020): @Luuk34 This is literally the design of how ligatured fonts work. If you don't like ligatured fonts, then you're free to * pick any of the gazillions of fonts that are out there that _don't_ have liagtured glyphs * wait for the next release to come out where we switch to "Cascadia Mono" (without ligatures) instead of "Cascadia Code" (with ligatures) (see #5505) * Help us implement settings for disabling ligatures #759 but comments like "Design must be .... 👎" aren't really constructive here.
claunia commented 2026-01-30 22:02:42 +00:00
Author
Owner
Copy Link

@NicTanghe commented on GitHub (Jun 21, 2020):

:edit seeing #757 seems like the disliked comment was actually taken to heart and people are now trying to fix it.

How is it not constructive when someone gives you the most valuable information.
It pops up in a lot of different places.
From the second any other party has any responsibility Microsoft's approach has classically been its fully up to them to resolve any issues especially if it's regarding customizing aesthetics>

All that is being asked is an exception in code that states.

IF 
$path + >+ = 
Don`t
Use the code to render ligatures on  + > =

And of course a toggle switch because people who know what they are doing don't want permanent decisions made for them.

Please don't view negative feedback as unconstructive.|

He is probably not talking about the design of the ligature fonts but about the design of how cmder handles them !

I haven't seen this functionality in any other terminal emulator in windows or Linux. But the goal should always be better than the competition by as large a margin as possible.

And ofc if your code is so bloated by company standard practices adding anything like this adds huge amount of unnecessary bloat.

Don't get me wrong much love to y'all and thx for making this emulator its now my main one.
**to bad i couldn`t figure out how to hide all the ui tho :(

@NicTanghe commented on GitHub (Jun 21, 2020): :edit seeing #757 seems like the disliked comment was actually taken to heart and people are now trying to fix it. How is it not constructive when someone gives you the most valuable information. It pops up in a lot of different places. From the second any other party has any responsibility Microsoft's approach has classically been its fully up to them to resolve any issues especially if it's regarding customizing aesthetics> All that is being asked is an exception in code that states. ``` IF $path + >+ = Don`t Use the code to render ligatures on + > = ``` And of course a toggle switch because people who know what they are doing don't want permanent decisions made for them. Please don't view negative feedback as unconstructive.| He is probably not talking about the design of the ligature fonts but about the design of how cmder handles them ! I haven't seen this functionality in any other terminal emulator in windows or Linux. But the goal should always be better than the competition by as large a margin as possible. And ofc if your code is so bloated by company standard practices adding anything like this adds huge amount of unnecessary bloat. Don't get me wrong much love to y'all and thx for making this emulator its now my main one. **to bad i couldn`t figure out how to hide all the ui tho :(
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Fonts Area-Rendering Issue-Question Needs-Tag-Fix Resolution-By-Design
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#755
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?