starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

TSFInputControl alignment is slightly off on High DPI #7555

New Issue
Closed
opened 2026-01-31 01:07:10 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 01:07:10 +00:00
Owner
Copy Link

Originally created by @miniksa on GitHub (Apr 22, 2020).

Originally assigned to: @miniksa, @zadjii-msft, @leonMSFT on GitHub.

  • - TSFInputControl needs to account for scaling (migrie: ✔️)
    • miniksa 4/20@5:04pm, something's still a little off here cutting off the prev text and being a bit small...
    • DHowett 4/20, seems better after it's been opened and closed once, weirdly, for me

Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/5345#issuecomment-614127648

Originally created by @miniksa on GitHub (Apr 22, 2020). Originally assigned to: @miniksa, @zadjii-msft, @leonMSFT on GitHub. - [ ] - `TSFInputControl` needs to account for scaling (migrie: ✔️) - miniksa 4/20@5:04pm, something's still a little off here cutting off the prev text and being a bit small... - DHowett 4/20, seems better after it's been opened and closed once, weirdly, for me _Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/5345#issuecomment-614127648_
claunia commented 2026-01-31 01:07:11 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Apr 24, 2020):

image
It's a little to the left, but I just checked 0.11 (without incremental) and it's like that too.

However, resizing and moving the window cause the IME popup to go out of alignment until the cursor position changes (by deleting something in the edit line)

EDIT: Also, the covering thing I think was me talking about it being slightly left of the cursor and covering some of the previously written text. Might have also been related to the tracking because I was resizing and moving the window as well as adjusting the font size (ctrl+scroll wheel) while testing High DPI. Those sound related.

@miniksa commented on GitHub (Apr 24, 2020): ![image](https://user-images.githubusercontent.com/18221333/80260382-a6092b80-863c-11ea-8df5-905b80057b03.png) It's a little to the left, but I just checked 0.11 (without incremental) and it's like that too. However, resizing and moving the window cause the IME popup to go out of alignment until the cursor position changes (by deleting something in the edit line) EDIT: Also, the covering thing I think was me talking about it being slightly left of the cursor and covering some of the previously written text. Might have also been related to the tracking because I was resizing and moving the window as well as adjusting the font size (ctrl+scroll wheel) while testing High DPI. Those sound related.
claunia commented 2026-01-31 01:07:11 +00:00
Author
Owner
Copy Link

@leonMSFT commented on GitHub (Apr 24, 2020):

(just a thought, noting it down here) maybe the text box has a slight border thickness and where the ime shows up is actually at the beginning of the text box?

Edit: for whatever reason, bringing emoji IME up on a new tab will overlap the row no matter what

@leonMSFT commented on GitHub (Apr 24, 2020): (just a thought, noting it down here) maybe the text box has a slight border thickness and where the ime shows up is actually at the beginning of the text box? Edit: for whatever reason, bringing emoji IME up on a new tab will overlap the row no matter what
claunia commented 2026-01-31 01:07:11 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 5, 2020):

:tada:This issue was addressed in #5609, which has now been successfully released as Windows Terminal Release Candidate v0.11.1251.0 (1.0rc1).🎉

Handy links:

@ghost commented on GitHub (May 5, 2020): :tada:This issue was addressed in #5609, which has now been successfully released as `Windows Terminal Release Candidate v0.11.1251.0 (1.0rc1)`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1251.0 (1.0rc1)) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7555
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?