starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crashes if zoom font size up and down rapidly with ctrl + scroll wheel #7568

New Issue
Closed
opened 2026-01-31 01:07:29 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 01:07:29 +00:00
Owner
Copy Link

Originally created by @guyrleech on GitHub (Apr 23, 2020).

Originally assigned to: @leonMSFT on GitHub.

Environment

Win10 1909 x64

Windows Terminal version (if applicable): 0.11.1121.0

Steps to reproduce

Increase and decrease the font size rapidly in the first tab using ctrl and mouse scroll wheel

Expected behavior

Not to crash

Actual behavior

Crashes

Crashes every time when I use Ctrl and the mouse wheel to increase and decrease the font rapidly. Only happens with the first tab and regardless of what is running in there. I have crash dumps. Doesn't crash when I try and record a video of it in Snagit.

image

Originally created by @guyrleech on GitHub (Apr 23, 2020). Originally assigned to: @leonMSFT on GitHub. # Environment Win10 1909 x64 Windows Terminal version (if applicable): 0.11.1121.0 # Steps to reproduce Increase and decrease the font size rapidly in the first tab using ctrl and mouse scroll wheel # Expected behavior Not to crash # Actual behavior Crashes --- Crashes every time when I use Ctrl and the mouse wheel to increase and decrease the font rapidly. Only happens with the first tab and regardless of what is running in there. I have crash dumps. Doesn't crash when I try and record a video of it in Snagit. ![image](https://user-images.githubusercontent.com/11651939/80043624-22dfbc80-84fa-11ea-8725-1b62874966cf.png)
claunia commented 2026-01-31 01:07:30 +00:00
Author
Owner
Copy Link

@skyline75489 commented on GitHub (Apr 27, 2020):

It's very easy to reproduce this crash with Release build. The root cause I think is that the render thread clashes with the main thread.

When font size up or down, the main thread will call DxEngine::UpdateFont, in which the render related thing(_dwriteFontFace, for example) is effectively updated. In the meantime, the render thread is happily refreshing the content using PaintBufferLine, which also uses _dwriteFontFace and friends to construct CustomTextLayout. That gives us a race condition. For some reason _dwriteFontFace became a nullptr during the process, causing the crash.

A naive (but acutally working) fix would be adding guard-return for those DX properties to prevent any null-value access. However this is far from ideal. If we going to face these kind of race issue fearlessly, maybe explicit locking is the way to go.

@skyline75489 commented on GitHub (Apr 27, 2020): It's very easy to reproduce this crash with Release build. The root cause I think is that the render thread clashes with the main thread. When font size up or down, the main thread will call `DxEngine::UpdateFont`, in which the render related thing(`_dwriteFontFace`, for example) is effectively updated. In the meantime, the render thread is happily refreshing the content using `PaintBufferLine`, which also uses `_dwriteFontFace` and friends to construct `CustomTextLayout`. That gives us a race condition. For some reason `_dwriteFontFace` became a nullptr during the process, causing the crash. A naive (but acutally working) fix would be adding guard-return for those DX properties to prevent any null-value access. However this is far from ideal. If we going to face these kind of race issue fearlessly, maybe explicit locking is the way to go.
claunia commented 2026-01-31 01:07:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 27, 2020):

Oh that's so on me for not locking that call. I'm pretty sure the right solution here is to have the caller get the write lock before calling TriggerFontChange. Thanks for helping debug this!

@zadjii-msft commented on GitHub (Apr 27, 2020): Oh that's so on me for not locking that call. I'm pretty sure the right solution here is to have the caller get the write lock before calling `TriggerFontChange`. Thanks for helping debug this!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7568
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?