starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

UIA in conhost: issues with visible ranges #7572

New Issue
Closed
opened 2026-01-31 01:07:34 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 01:07:34 +00:00
Owner
Copy Link

Originally created by @codeofdusk on GitHub (Apr 23, 2020).

Originally assigned to: @carlos-zamora on GitHub.

Environment

Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] next (19613.1000).
Windows Terminal version (if applicable): Inbox console

Any other software? NVDA

Steps to reproduce

  1. Download this list of domains.

  2. Start Windows Console and NVDA (with UIA in Windows Console enabled in advanced preferences).

  3. Run a python interpreter: python.

  4. Run:

    fin=open("domains.txt")
    fin.readlines()

Expected behaviour

Like in pre-21H1 conhost and Windows Terminal 0.11, NVDA reads current output immediately.

Actual behaviour

At this point, NVDA's auto-read lags far behind the actual output in the buffer. Quitting Python with quit() continues reading very old output.

Context

When a text change event is received, NVDA takes a diff of the old and new text and reads only the changed portion of the text. Maybe there's a bug in our diffing algorithm (implemented here, in LiveText._calculateNewText)?

Originally created by @codeofdusk on GitHub (Apr 23, 2020). Originally assigned to: @carlos-zamora on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd] next (19613.1000). Windows Terminal version (if applicable): Inbox console Any other software? NVDA ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. Download [this list of domains](https://github.com/microsoft/terminal/files/4519753/domains.txt). 2. Start Windows Console and NVDA (with UIA in Windows Console enabled in advanced preferences). 3. Run a python interpreter: `python`. 4. Run: fin=open("domains.txt") fin.readlines() # Expected behaviour <!-- What's actually happening? --> Like in pre-21H1 conhost and Windows Terminal 0.11, NVDA reads current output immediately. # Actual behaviour <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> At this point, NVDA's auto-read lags far behind the actual output in the buffer. Quitting Python with `quit()` continues reading very old output. # Context When a text change event is received, NVDA takes a diff of the old and new text and reads only the changed portion of the text. Maybe there's a bug in our diffing algorithm (implemented [here](https://github.com/nvaccess/nvda/blob/master/source/NVDAObjects/behaviors.py), in `LiveText._calculateNewText`)?
claunia added the Product-ConhostIssue-BugNeeds-Tag-FixArea-Accessibility labels 2026-01-31 01:07:34 +00:00
claunia commented 2026-01-31 01:07:35 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Apr 23, 2020):

Cc @carlos-zamora.

@codeofdusk commented on GitHub (Apr 23, 2020): Cc @carlos-zamora.
claunia commented 2026-01-31 01:07:35 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Apr 29, 2020):

Do you still intend to look at this for 21H1? It would mean a lot for NVDA. Thanks!

@codeofdusk commented on GitHub (Apr 29, 2020): Do you still intend to look at this for 21H1? It would mean a lot for NVDA. Thanks!
claunia commented 2026-01-31 01:07:35 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Apr 29, 2020):

This bug is not reproducible in Windows Terminal but it is in Conhost.

@codeofdusk commented on GitHub (Apr 29, 2020): This bug is not reproducible in Windows Terminal but it is in Conhost.
claunia commented 2026-01-31 01:07:36 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Apr 29, 2020):

@codeofdusk Yup! At least for now, we're hoping to get this in for 21H1. Just a bit caught up with stabilizing the last bit of Windows Terminal at the moment, so some of these ConHost bugs are lower priority.

@carlos-zamora commented on GitHub (Apr 29, 2020): @codeofdusk Yup! At least for now, we're hoping to get this in for 21H1. Just a bit caught up with stabilizing the last bit of Windows Terminal at the moment, so some of these ConHost bugs are lower priority.
claunia commented 2026-01-31 01:07:36 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Jun 5, 2020):

@carlos-zamora Any updates on this one?

@codeofdusk commented on GitHub (Jun 5, 2020): @carlos-zamora Any updates on this one?
claunia commented 2026-01-31 01:07:36 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jun 5, 2020):

@carlos-zamora Carlos Zamora FTE Any updates on this one?

Haven't had a chance to look at this one. We're prioritizing some other work right now. I'll be sure to get to this when we start working on ConHost issues though.

@carlos-zamora commented on GitHub (Jun 5, 2020): > @carlos-zamora Carlos Zamora FTE Any updates on this one? Haven't had a chance to look at this one. We're prioritizing some other work right now. I'll be sure to get to this when we start working on ConHost issues though.
claunia commented 2026-01-31 01:07:36 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Jul 8, 2020):

Do you still plan to get to this for 30 July (21H1)? For context, it's probably the single biggest issue blocking NVDA from using UIA in conhost.

@codeofdusk commented on GitHub (Jul 8, 2020): Do you still plan to get to this for 30 July (21H1)? For context, it's probably the single biggest issue blocking NVDA from using UIA in conhost.
claunia commented 2026-01-31 01:07:36 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Aug 16, 2020):

Turns out this particular case is due to NVDA's diffing algorithm. Sorry!

@codeofdusk commented on GitHub (Aug 16, 2020): Turns out this particular case is due to NVDA's diffing algorithm. Sorry!
claunia commented 2026-01-31 01:07:36 +00:00
Author
Owner
Copy Link

@codeofdusk commented on GitHub (Oct 4, 2020):

For future reference, this issue has nothing to do with visible ranges after all! See nvaccess/nvda#11639 for a description of the bug. Thanks @carlos-zamora for explaining the new behaviour of conhost and helping me track this down!

@codeofdusk commented on GitHub (Oct 4, 2020): For future reference, this issue has nothing to do with visible ranges after all! See nvaccess/nvda#11639 for a description of the bug. Thanks @carlos-zamora for explaining the new behaviour of conhost and helping me track this down!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Accessibility Issue-Bug Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7572
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?