Context Menu Item for Find #7788

Closed
opened 2026-01-31 01:12:41 +00:00 by claunia · 9 comments
Owner

Originally created by @Chips1234 on GitHub (Apr 29, 2020).

Description of the new feature/enhancement

A menu flyout item for the find feature.

Originally created by @Chips1234 on GitHub (Apr 29, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement A menu flyout item for the find feature.
Author
Owner

@zadjii-msft commented on GitHub (Apr 29, 2020):

Thanks for the offer of help! I think we're trying pretty hard ad the moment to not add additional UI elements to the New Tab flyout we already have. It's really the only UI we have at the moment, but it's a slippery slope towards having just every button in that single UI, and all of a sudden it's a cluttered mess like this:
image

Hopefully once #3789 lands (in 1.1), then we'll be able to add menu entries to the right-click menu on a tab, and I think that's probably a better place to put something like this.

Then there's also #3337 for adding a context menu to the terminal controls themselves, which would also be an appropriate place for this

Then of course, there's always #5400, which is another possible place.

I'm going to leave this open as a potential follow-up task of either #3337 or #3789

@zadjii-msft commented on GitHub (Apr 29, 2020): Thanks for the offer of help! I think we're trying pretty hard ad the moment to _not_ add additional UI elements to the New Tab flyout we already have. It's really the only UI we have at the moment, but it's a slippery slope towards having just every button in that single UI, and all of a sudden it's a cluttered mess like this: ![image](https://user-images.githubusercontent.com/18356694/80601259-3061de80-89f3-11ea-9d38-b11ebbb428e7.png) Hopefully once #3789 lands (in 1.1), then we'll be able to add menu entries to the right-click menu on a tab, and I think that's probably a better place to put something like this. Then there's also #3337 for adding a context menu to the terminal controls themselves, which would also be an appropriate place for this Then of course, there's always #5400, which is another possible place. I'm going to leave this open as a potential follow-up task of either #3337 or #3789
Author
Owner

@Chips1234 commented on GitHub (Apr 29, 2020):

Alright, we'll talk about it when context menu is introduced.

@Chips1234 commented on GitHub (Apr 29, 2020): Alright, we'll talk about it when context menu is introduced.
Author
Owner

@Chips1234 commented on GitHub (Apr 30, 2020):

Thanks for the offer of help! I think we're trying pretty hard ad the moment to not add additional UI elements to the New Tab flyout we already have. It's really the only UI we have at the moment, but it's a slippery slope towards having just every button in that single UI, and all of a sudden it's a cluttered mess like this:
image

Is that Microsoft saying that their own products are a mess? Lol

@Chips1234 commented on GitHub (Apr 30, 2020): > Thanks for the offer of help! I think we're trying pretty hard ad the moment to _not_ add additional UI elements to the New Tab flyout we already have. It's really the only UI we have at the moment, but it's a slippery slope towards having just every button in that single UI, and all of a sudden it's a cluttered mess like this: > ![image](https://user-images.githubusercontent.com/18356694/80601259-3061de80-89f3-11ea-9d38-b11ebbb428e7.png) Is that Microsoft saying that their own products are a mess? Lol
Author
Owner

@DHowett-MSFT commented on GitHub (Apr 30, 2020):

It would not be wise to take the opinion of one person at a company with multiple tens of thousands of employees as representative of the entire company.

@DHowett-MSFT commented on GitHub (Apr 30, 2020): It would not be wise to take the opinion of one person at a company with multiple tens of thousands of employees as representative of the entire company.
Author
Owner

@Chips1234 commented on GitHub (Apr 30, 2020):

I understand. It was an innocent joke.

@Chips1234 commented on GitHub (Apr 30, 2020): I understand. It was an innocent joke.
Author
Owner

@DavidJRWang commented on GitHub (Nov 15, 2021):

In regards to the above discussion, has it been determined whether or not this is something that is wanted?

@DavidJRWang commented on GitHub (Nov 15, 2021): In regards to the above discussion, has it been determined whether or not this is something that is wanted?
Author
Owner

@zadjii-msft commented on GitHub (Nov 15, 2021):

Honestly, I don't remember. I thought I closed this because eventually we were going to make it possible for users to add this on their own. I don't remember why I tagged this easy starter...

...

Okay, now I'm remembering. We thought it was a fine idea for someone to add to the tab context menu
image

And that should be relatively easy to do.

@zadjii-msft commented on GitHub (Nov 15, 2021): Honestly, I don't remember. I thought I closed this because _eventually_ we were going to make it possible for users to add this on their own. I don't remember why I tagged this easy starter... ... Okay, now I'm remembering. We thought it was a fine idea for someone to add to the tab context menu ![image](https://user-images.githubusercontent.com/18356694/141859582-0c10390e-32f0-4b3d-af2b-d3e7705a7932.png) And that should be relatively easy to do.
Author
Owner

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13055, which has now been successfully released as Windows Terminal v1.14.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13055, which has now been successfully released as `Windows Terminal v1.14.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13055, which has now been successfully released as Windows Terminal Preview v1.15.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13055, which has now been successfully released as `Windows Terminal Preview v1.15.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7788