old version of splitHorizontal is not working #7791

Closed
opened 2026-01-31 01:12:45 +00:00 by claunia · 3 comments
Owner

Originally created by @tlsalex on GitHub (Apr 29, 2020).

Environment

Windows build number: Microsoft Windows [Version 10.0.18363.778]
Windows Terminal version (if applicable): v0.11.1191.0

Any other software?

Steps to reproduce

delete all old configuration, and terminal generate a new one , then copy and past my old version's key binding into keybinding section ,e.g.
{"command" : "splitHorizontal","keys" : ["ctrl+shift+m"]},

Expected behavior

a new pane will appear Horizontally

Actual behavior

Nothing happen.
I know the new version is something like this:
{ "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" }
but it always split pane vertically.
How to make it split pane horizontally?
Any example configuration for other key binding?

Originally created by @tlsalex on GitHub (Apr 29, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Microsoft Windows [Version 10.0.18363.778] Windows Terminal version (if applicable): v0.11.1191.0 Any other software? ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> delete all old configuration, and terminal generate a new one , then copy and past my old version's key binding into keybinding section ,e.g. {"command" : "splitHorizontal","keys" : ["ctrl+shift+m"]}, # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> a new pane will appear Horizontally # Actual behavior <!-- What's actually happening? --> Nothing happen. I know the new version is something like this: { "command": { "action": "splitPane", "split": "auto", "splitMode": "duplicate" }, "keys": "alt+shift+d" } but it always split pane vertically. How to make it split pane horizontally? Any example configuration for other key binding?
Author
Owner

@CannedFish commented on GitHub (Apr 29, 2020):

{
  "keybindings": [
    { "command": {"action": "splitPane", "direction": "horizontal"}, "keys": ["ctrl+shift+s"] },
    { "command": {"action": "splitPane", "direction": "vertical"}, "keys": ["ctrl+shift+h"] }
  ]
}

Same issue here with settings above.

@CannedFish commented on GitHub (Apr 29, 2020): ```json { "keybindings": [ { "command": {"action": "splitPane", "direction": "horizontal"}, "keys": ["ctrl+shift+s"] }, { "command": {"action": "splitPane", "direction": "vertical"}, "keys": ["ctrl+shift+h"] } ] } ``` Same issue here with settings above.
Author
Owner

@zadjii-msft commented on GitHub (Apr 29, 2020):

@tlsalex You're absolutely correct, splitHorizontal and splitVertical were deprecated in 0.11. To achieve the same effect, I'll refer you to how they're defined in defaults.json
db5d2fe0a5/src/cascadia/TerminalApp/defaults.json (L309-L310)

@CannedFish Your bindings don't work because the argument isn't direction, it's split 😄

@zadjii-msft commented on GitHub (Apr 29, 2020): @tlsalex You're absolutely correct, `splitHorizontal` and `splitVertical` were deprecated in 0.11. To achieve the same effect, I'll refer you to how they're defined in `defaults.json` https://github.com/microsoft/terminal/blob/db5d2fe0a5f4664c62ca0696a9c4bc14874ae66c/src/cascadia/TerminalApp/defaults.json#L309-L310 @CannedFish Your bindings don't work because the argument isn't `direction`, it's `split` 😄
Author
Owner

@CannedFish commented on GitHub (Apr 29, 2020):

@CannedFish Your bindings don't work because the argument isn't direction, it's split 😄

@zadjii-msft Sorry, my mistake. And Thanks.

@CannedFish commented on GitHub (Apr 29, 2020): > @CannedFish Your bindings don't work because the argument isn't `direction`, it's `split` 😄 @zadjii-msft Sorry, my mistake. And Thanks.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7791