starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

ESC from the Tab ContextMenu should return focus to the Terminal #7949

New Issue
Closed
opened 2026-01-31 01:16:36 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 01:16:36 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (May 5, 2020).

Repro steps

  1. Right click a tab
  2. Hit esc

Expected

  1. Terminal gets focus again

Actual

  1. Focus lands on the tab itself
    image

regressed in #3789

Also, fixing this might just magically fix #3609.

Originally created by @zadjii-msft on GitHub (May 5, 2020). ### Repro steps 1. Right click a tab 2. Hit <kbd>esc</kbd> #### Expected 3. Terminal gets focus again #### Actual 3. Focus lands on the tab itself ![image](https://user-images.githubusercontent.com/18356694/81071815-d5c0fa80-8eaa-11ea-83f5-8339a2fcb2b4.png) regressed in #3789 Also, fixing this might just magically fix #3609.
claunia commented 2026-01-31 01:16:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 8, 2020):

Note from an offline discussion: maybe we could prevent the right click on the tab from focusing the TabViewItem, and then focus would just return to the Terminal? 🤞

@zadjii-msft commented on GitHub (May 8, 2020): Note from an offline discussion: maybe we could prevent the right click on the tab from focusing the TabViewItem, and then focus would just return to the Terminal? 🤞
claunia commented 2026-01-31 01:16:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 6, 2021):

Huh. This was fixed... some time? TabHeaderControl::_CloseRenameBox -> _RenameEndedHandlers -> handled in newTabImpl->TabRenamerDeactivated (lambda in TerminalPage)

Looks like it was originally in #9162, which was in v1.6.10571.0/Preview v1.7.572.0

@zadjii-msft commented on GitHub (May 6, 2021): Huh. This was fixed... some time? `TabHeaderControl::_CloseRenameBox` -> `_RenameEndedHandlers` -> handled in `newTabImpl->TabRenamerDeactivated` (lambda in `TerminalPage`) Looks like it was originally in #9162, which was in `v1.6.10571.0`/`Preview v1.7.572.0`
claunia commented 2026-01-31 01:16:37 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 6, 2021):

Wait no what? I'm crazy, had the wrong thread open this whole time. Ignore me.

@zadjii-msft commented on GitHub (May 6, 2021): Wait no what? I'm crazy, had the wrong thread open this whole time. Ignore me.
claunia commented 2026-01-31 01:16:37 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #10048, which has now been successfully released as Windows Terminal v1.8.1444.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #10048, which has now been successfully released as `Windows Terminal v1.8.1444.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.8.1444.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 01:16:37 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #10048, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #10048, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7949
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?