starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Multiple Selections Rendered with Search Box #7962

New Issue
Closed
opened 2026-01-31 01:16:56 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 01:16:56 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (May 5, 2020).

Originally assigned to: @carlos-zamora on GitHub.

Environment

Windows Terminal version (if applicable): 0.11.1251.0

Any other software?

Steps to reproduce

  1. (Optional) cd to our repo's src\cascadia\CascadiaPackage
  2. ls -R (or just print a lot of output)
  3. Open search box (ctrl+shift+f)
  4. Search png a few times (at least until you force the viewport to scroll)
  5. Scroll up about half a page (current selection should be past halfway down your viewport)
  6. Search png again (just hit enter)

Expected behavior

Only one selection is visible at a time (because only one exists).

Actual behavior

bug image

Originally created by @carlos-zamora on GitHub (May 5, 2020). Originally assigned to: @carlos-zamora on GitHub. # Environment ```none Windows Terminal version (if applicable): 0.11.1251.0 Any other software? ``` # Steps to reproduce 1. (Optional) cd to our repo's src\cascadia\CascadiaPackage 2. `ls -R` (or just print a lot of output) 3. Open search box (<kbd>ctrl+shift+f</kbd>) 4. Search `png` a few times (at least until you force the viewport to scroll) 5. Scroll up about half a page (current selection should be past halfway down your viewport) 6. Search `png` again (just hit enter) # Expected behavior Only one selection is visible at a time (because only one exists). # Actual behavior ![bug image](https://user-images.githubusercontent.com/11050425/81117065-5566bd80-8edb-11ea-8691-79fa09e3f563.png)
claunia commented 2026-01-31 01:16:58 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 5, 2020):

Search probably doesn't lock the renderer when changing its state or trigger scrolling properly. Want to look into this for 1.0?

@DHowett-MSFT commented on GitHub (May 5, 2020): Search probably doesn't lock the renderer when changing its state or trigger scrolling properly. Want to look into this for 1.0?
claunia commented 2026-01-31 01:16:59 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (May 5, 2020):

I can. I think Michael did a recent PR adding a bunch of those locks so I'll take a look at that and try it.

@carlos-zamora commented on GitHub (May 5, 2020): I can. I think Michael did a recent PR adding a bunch of those locks so I'll take a look at that and try it.
claunia commented 2026-01-31 01:16:59 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 7, 2020):

It is so assigned.

@DHowett-MSFT commented on GitHub (May 7, 2020): It is so assigned.
claunia commented 2026-01-31 01:16:59 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 13, 2020):

:tada:This issue was addressed in #5798, which has now been successfully released as Windows Terminal Release Candidate v0.11.1333.0 (1.0rc2).🎉

Handy links:

@ghost commented on GitHub (May 13, 2020): :tada:This issue was addressed in #5798, which has now been successfully released as `Windows Terminal Release Candidate v0.11.1333.0 (1.0rc2)`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.11.1333.0 (1.0rc2)) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Area-TerminalControl Issue-Bug Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7962
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?