starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

"shift extend selection" feature doesn't work in the click->shift-click case because single-cell selection is gone #7974

New Issue
Closed
opened 2026-01-31 01:17:20 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 01:17:20 +00:00
Owner
Copy Link

Originally created by @ymkun on GitHub (May 6, 2020).

Originally assigned to: @carlos-zamora on GitHub.

Environment

Windows build number: [19041.208  wsl ]
Windows Terminal version (if applicable): 0.11.1251.0

Any other software?

Steps to reproduce

  1. Single click.
  2. Hold SHIFT and single click an unselected region.

Expected behavior

Region between two click should be selected.

Actual behavior

region between two click hasn't been selected.
I remeber this feature has been released in "Windows Terminal Preview v0.9.433.0", said: "You can now hold down Shift and click to extend your selection (#4404)". But in recent releases, it gone.

Originally created by @ymkun on GitHub (May 6, 2020). Originally assigned to: @carlos-zamora on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [19041.208 wsl ] Windows Terminal version (if applicable): 0.11.1251.0 Any other software? ``` # Steps to reproduce 1. Single click. 2. Hold SHIFT and single click an unselected region. # Expected behavior Region between two click should be selected. # Actual behavior region between two click hasn't been selected. I remeber this feature has been released in "Windows Terminal Preview v0.9.433.0", said: "You can now hold down Shift and click to extend your selection (#4404)". But in recent releases, it gone.
claunia commented 2026-01-31 01:17:22 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 7, 2020):

So, fair enough. Shift only works to extend an actual extant selection Since single-click no longer selects a cell, it doesn't comprise an active selection.

We should probably expand the touchdown anchor when you click + shift-click. It's not high-priority, because there's a workaround (select 2 cells, then use shift-click.)

@DHowett-MSFT commented on GitHub (May 7, 2020): So, fair enough. Shift only works to extend an _actual extant selection_ Since single-click no longer selects a cell, it doesn't comprise an active selection. We should probably expand the touchdown anchor when you click + shift-click. It's not high-priority, because there's a workaround (select 2 cells, then use shift-click.)
claunia commented 2026-01-31 01:17:22 +00:00
Author
Owner
Copy Link

@ymkun commented on GitHub (May 7, 2020):

So, fair enough. Shift only works to extend an actual extant selection Since single-click no longer selects a cell, it doesn't comprise an active selection.

We should probably expand the touchdown anchor when you click + shift-click. It's not high-priority, because there's a workaround (select 2 cells, then use shift-click.)

Thanks. It's just a little inconvenient when select a long region now.

@ymkun commented on GitHub (May 7, 2020): > So, fair enough. Shift only works to extend an _actual extant selection_ Since single-click no longer selects a cell, it doesn't comprise an active selection. > > We should probably expand the touchdown anchor when you click + shift-click. It's not high-priority, because there's a workaround (select 2 cells, then use shift-click.) Thanks. It's just a little inconvenient when select a long region now.
claunia commented 2026-01-31 01:17:22 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 16, 2020):

@DHowett, @carlos-zamora, @ymkun - ConEmu does something that is IMHO more intuitive:

  1. Shift+Click - selects single cell
  2. The next Shift+Click expands this selection.

ShiftSelect

If you like this approach, I can commit (it is less than one-liner 😊)

@Don-Vito commented on GitHub (Dec 16, 2020): @DHowett, @carlos-zamora, @ymkun - ConEmu does something that is IMHO more intuitive: 1. Shift+Click - selects single cell 2. The next Shift+Click expands this selection. ![ShiftSelect](https://user-images.githubusercontent.com/4639110/102410899-de111480-3ff9-11eb-9955-72d69f7141ec.gif) If you like this approach, I can commit (it is less than one-liner :blush:)
claunia commented 2026-01-31 01:17:22 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 17, 2020):

Sounds great, with one caveat.

We need to figure out how this works with Shift suppressing VT mouse mode. Will any single shift-click on a mouse mode application cause a single cell selection?

I might be okay with that.

@DHowett commented on GitHub (Dec 17, 2020): Sounds great, with one caveat. We need to figure out how this works with <kbd>Shift</kbd> suppressing VT mouse mode. Will any single shift-click on a _mouse mode_ application cause a single cell selection? I might be okay with that.
claunia commented 2026-01-31 01:17:22 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 17, 2020):

@DHowett - I am not sure I understood the concern, can you please explain?

I mean I tried this in tmux with mouse mode on, and it works exactly like shift +drag one char (but with no need to drag).

Guess I am missing something.

@Don-Vito commented on GitHub (Dec 17, 2020): @DHowett - I am not sure I understood the concern, can you please explain? I mean I tried this in tmux with mouse mode on, and it works exactly like shift +drag one char (but with no need to drag). Guess I am missing something.
claunia commented 2026-01-31 01:17:23 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 18, 2020):

Sure.

I was worried that introducing this behavior would make it difficult to single-click on the terminal itself when there was a mouse mode application running without selecting a single cell.

However, thinking about it more: There is no reason to click on the terminal itself during mouse mode unless you are making a selection, so this is okay. As long as it does not highlight a cell when you use Ctrl+Shift+Click on a URL!

@DHowett commented on GitHub (Dec 18, 2020): Sure. I was worried that introducing this behavior would make it difficult to single-click on the _terminal itself_ when there was a mouse mode application running without selecting a single cell. However, thinking about it more: There is no reason to click on the terminal itself during mouse mode _unless_ you are making a selection, so this is okay. As long as it does not highlight a cell when you use Ctrl+Shift+Click on a URL!
claunia commented 2026-01-31 01:17:23 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 18, 2020):

Sure.

I was worried that introducing this behavior would make it difficult to single-click on the terminal itself when there was a mouse mode application running without selecting a single cell.

However, thinking about it more: There is no reason to click on the terminal itself during mouse mode unless you are making a selection, so this is okay. As long as it does not highlight a cell when you use Ctrl+Shift+Click on a URL!

I will try this. If works as expected - should I submit PR under this ticket?

@Don-Vito commented on GitHub (Dec 18, 2020): > > > Sure. > > I was worried that introducing this behavior would make it difficult to single-click on the _terminal itself_ when there was a mouse mode application running without selecting a single cell. > > However, thinking about it more: There is no reason to click on the terminal itself during mouse mode _unless_ you are making a selection, so this is okay. As long as it does not highlight a cell when you use Ctrl+Shift+Click on a URL! I will try this. If works as expected - should I submit PR under this ticket?
claunia commented 2026-01-31 01:17:23 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 18, 2020):

Absolutely! 😄 We love your PRs.

@DHowett commented on GitHub (Dec 18, 2020): Absolutely! :smile: We love your PRs.
claunia commented 2026-01-31 01:17:23 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 18, 2020):

@DHowett - lol. Actually I am asking if I should mark the PR as "Closing" this one.. or not. BTW - URL works like a charm

@Don-Vito commented on GitHub (Dec 18, 2020): @DHowett - lol. Actually I am asking if I should mark the PR as "Closing" this one.. or not. BTW - URL works like a charm
claunia commented 2026-01-31 01:17:23 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 18, 2020):

Yeah, I think that your proposal is sufficient to solve this issue!

@DHowett commented on GitHub (Dec 18, 2020): Yeah, I think that your proposal is sufficient to solve this issue!
claunia commented 2026-01-31 01:17:24 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8611, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8611, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#7974
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?